AddBuff System 2.1

[Moderator]

The system is quite simple, too simple. Better buff systems exist.

The dispel function is not needed since it is just a wrapper for the native function.

 

[Adiktuz]

triggers please...

 

[Mitzui]

what does this do? description please?

 

[Adiktuz]

and its JASS... we already have the ABuff libraries for that... if its meant for GUIers, we have king_drift_alex's buff system for GUI...

 

[zv27]

Use native not BJ
And next time you say that the JASS,then let it be JASS.Thus this is nothing

Since I use the buff system that is based on completely different principles than this(much more advanced and efficient),I must admit that I do not like something like this,but since you are using this system I think that your work should go in this direction.

One of the solutions to your system

function Real_SafeX takes real xx returns real
	local real r=GetRectMinX(bj_mapInitialPlayableArea)+50
	if(xx<r)then
		return r
	endif
	set r=GetRectMaxX(bj_mapInitialPlayableArea)-50
	if(xx>r)then
		return r
	endif
	return xx
endfunction

function Real_SafeY takes real yy returns real
	local real r=GetRectMinY(bj_mapInitialPlayableArea)+50
	if(yy<r)then
		return r
	endif
	set r=GetRectMaxY(bj_mapInitialPlayableArea)-50
	if(yy>r)then
		return r
	endif
	return yy
endfunction

function Unit_CreateDummy takes player id,integer unitid,real x,real y,real facing returns unit
        set udg_j_spellCaster=CreateUnit(id,unitid,x,y,facing)
        return udg_j_spellCaster
endfunction

function Unit_CreateDummySingle takes player p,integer unitid,real x,real y,real facing,integer abilid,integer level,string order,unit target,real interval,real height returns unit  
        if (x!=0) then
             set x=Real_SafeX(x)
        endif
        if (y!=0) then
             set y=Real_SafeY(y)
        endif
        set udg_j_spellCaster=Unit_CreateDummy(p,unitid,x,y,facing)
        call UnitAddAbility(udg_j_spellCaster,abilid)
        call SetUnitAbilityLevel(udg_j_spellCaster,abilid,level)
        call IssueTargetOrderById(udg_j_spellCaster,OrderId(order),target)
        call UnitAddAbility(udg_j_spellCaster,'Aloc')
        call SetUnitPathing(udg_j_spellCaster,false)
        call SetUnitFlyHeight(udg_j_spellCaster,height,0)
        call UnitApplyTimedLife(udg_j_spellCaster,'BTLF',interval)
        return udg_j_spellCaster   
endfunction
//Ahh Necessary evil!!!
function Unit_DummyPreloadAbility takes player whichPlayer,integer unitid,integer abilid returns nothing
        set udg_j_spellCaster=Unit_CreateDummySingle(whichPlayer,unitid,0,0,0,abilid,0,"",null,0,0)
//If you set up UnitApplyTimedLife the greater value of 0  for example Unit_CreateDummySingle(whichPlayer,unitid,0,0,0,abilid,0,"",null,1,0)
	  call UnitRemoveAbility(udg_j_spellCaster,abilid)
//then these last two functions do not need
        call KillUnit(udg_j_spellCaster)
	call RemoveUnit(udg_j_spellCaster)
endfunction

I have used this system 3-4 years ago and from experience can tell you that there are much better ways of doing the buff system,but never mind, maybe in this case this is not such a bad solution(try, test, and you will see perhaps this is crap and maybe not...who knows?)
And next time put a DESCRIPTION and CODE

Your function

function buffs takes location l, unit d, integer s returns nothing
local unit b
call CreateNUnitsAtLoc( 1, 'h000', Player(0), l, 0.00 )
set b = GetLastCreatedUnit()
call UnitAddAbilityBJ( udg_Buff[s], b )
call IssueTargetOrderBJ( b, "bloodlust", d )
call PolledWait (0.5)
call RemoveUnit(b)
set d = null
set l = null
endfunction

Very limited functions everything is within a function.
There is no possibility to directly manipulate with more units, players,integers,orders and so on.
For example, What if someone would want to use a different unit,integer or anything else?
In your case it would have to change everything inside the function.Then it can not be a system.Next time when you work on a system think about it.
Maybe I was too critical, but nothing personal, I just point out how the system should work.That's why I put this simple code.
This code is not perfect but it may well serve(If nothing else, at least as an example)

 

[Magtheridon96]

What?
Buff systems are the new Omnislash?
Can I make one? ^^ (Nah, just kidding)

If you're using JNGP,to get rid of the useless BJs, just press Ctrl, and click on the BJ
The "TESH" window will pop up with exactly how the function should be inlined

 

[OxygenD]

Magtheridon96, wow its realy cool=) Thank u

 

[Magtheridon96]

Magtheridon96, wow its realy cool=) Thank u

No problem =p
I came across it one day while hitting my keyboard because I couldn't learn
how to use structs xD

 

[OxygenD]

lolD

 

[OxygenD]

vote to approved!

 

[OxygenD]

Maker!!!! CHECK IT

 

[Adiktuz]

don't DP please... and if you want to request a mod review, you better PM him...

 

[von_Oberstain]

hey, your test map just crashes... i dl-ed, and found that i already have 1.7something version (which was crashing as well).

now, provided that IS working, i may have need for it (tired of manually making dummy casters), am willing to write array manually (even that is kinda place where mistake can happen - now, how did i numbered the 'frenzy amplified', oh yes, its buff[45])

but - if i go check array codes for each spell, or do a printout or whatever, i may as well look its code in ability editor, and call function with it? maybe save whole array adding thing? may be useful for users who have 100+ buffs already in map, and manual making of array is... well time-taking and unnecessary

isn't removebuffs in gui already?

and i don't pretend to really understand this:
call IssueTargetOrder( b, "bloodlust", d )

but, isn't bloodlust affecting friends/allies only? is it potential problem?

please, take this a an constructive critique from a potential user