Ability trigger help

[illum1nati]

Hey, so i have an ability called "Witch Hunt" and it damages units that cast a spell. I've decided to change the ability a bit and add an AoE silence after the ability is finished casting. I've tried to create a trigger for this, but i'm pretty bad at making them.
Any help would be greatly appreciated.

 

[Vinz]

CasLoc is where? You do not set it. Plus you do not create a group, why destroy one? Position of Triggering Unit leaks.

 

[Death Adder]

is the ability a PBAoE? if it isn't then it should be "target point of ability being cast" instead of unit position of triggering unit.

 

[illum1nati]

CasLoc is where? You do not set it. Plus you do not create a group, why destroy one? Position of Triggering Unit leaks.

I've created this trigger based of another one, didnt delete that part. Just shows how noobish I am at this. Thanks. Is that the only problem tho?

is the ability a PBAoE? if it isn't then it should be "target point of ability being cast" instead of unit position of triggering unit.

It is PBAoE.

 

[Vinz]

Anything you reference more than twice, such as Last Created Unit, should be stored into a variable and nulled afterwards.

 

[Death Adder]

and well for next time you might want to use

• copied text from world editor[\trigger] to post the trigger instead of an image

 

[illum1nati]

and well for next time you might want to use

• copied text from world editor[\trigger] to post the trigger instead of an image[/QUOTE]
• Ok, didnt know i can do this like that.
• I still can't make that ability work tho. Smth isn't right.

 

[Vinz]

Update us with the current trigger. Also Owner of Caster -> Triggering Player.

 

[Death Adder]

Update us with the current trigger. Also Owner of Caster -> Triggering Player.

this applies to anytime you use a generic unit event (ones that start with "a unit ")

 

[illum1nati]

• Witch Hunt Silence
  • Events
    • Unit - A unit Finishes casting an ability
  • Conditions
    • (Ability being cast) Equal to Witch Hunt
  • Actions
    • Set WitchHuntDummy = (Last created unit group)
    • Unit - Create 1 Shards of Ice Dummy for (Owner of (Casting unit)) at CasLoc facing Default building facing degrees
    • Unit - Add a 1.00 second Generic expiration timer to (Last created unit)
    • Unit - Add Witch Hunt Silence to (Last created unit)
    • Unit - Order (Last created unit) to Neutral Dark Ranger - Silence (Position of (Triggering unit))
    • Custom script: call DestroyGroup(udg_WitchHuntDummy)

 

[Vinz]

You don't need a group for this, a unit variable is what you do. Set it after creating the dummy.

Also set CasLoc to the Target Point of Ability being Cast and remove it afterwards.

 

[illum1nati]

• Witch Hunt Silence
  • Events
    • Unit - A unit Finishes casting an ability
  • Conditions
    • (Ability being cast) Equal to Witch Hunt
  • Actions
    • Unit - Create 1 Shards of Ice Dummy for (Owner of (Casting unit)) at CasLoc facing Default building facing degrees
    • Set WitchHunterDummy2 = (Last created unit)
    • Set CasLoc = (Target point of ability being cast)
    • Unit - Add a 1.00 second Generic expiration timer to (Last created unit)
    • Unit - Add Witch Hunt Silence to (Last created unit)
    • Unit - Order (Last created unit) to Neutral Dark Ranger - Silence (Position of (Triggering unit))
    • Custom script: call DestroyGroup(udg_WitchHuntDummy2)
    • Custom script: call RemoveLocation(udg_CasLoc)

Like this?

 

[Death Adder]

yeah, and remove the DestroyGroup custom script too

btw, you probably want to use "a unit starts the effect of an ability" unless it's a channel ability (which i doubt since it's a PBAoE).

also, use the variables now instead of "last created unit" and "unit postition of trigger unit" (otherwise there's no point in creating them and the location would still leak)

• Unit - Order WitchHunterDummy2 to Neutral Dark Ranger - Silence CasLoc

also you forgot to use triggering player

• Unit - Create 1 Shards of Ice Dummy for triggering player at CasLoc facing Default building facing degrees

 

[Vinz]

script: set <unit> = null

Also, move the CasLoc before you create unit and use it as reference point to prevent leaks.

 

[illum1nati]

yeah, and remove the DestroyGroup custom script too

btw, you probably want to use "a unit starts the effect of an ability" unless it's a channel ability (which i doubt since it's a PBAoE).

Witch Hunt ability is a channel ability and i want silence to be used after the unit stops casting that channel ability.

Also, move the CasLoc before you create unit and use it as reference point to prevent leaks.

How do i do that?

This is how my trigger looks like right now :

• Witch Hunt Silence
  • Events
    • Unit - A unit Finishes casting an ability
  • Conditions
    • (Ability being cast) Equal to Witch Hunt
  • Actions
    • Unit - Create 1 Shards of Ice Dummy for (Triggering player) at CasLoc facing Default building facing degrees
    • Set WitchHunterDummy2 = (Last created unit)
    • Set CasLoc = (Target point of ability being cast)
    • Unit - Add a 1.00 second Generic expiration timer to WitchHunterDummy2
    • Unit - Add Witch Hunt Silence to WitchHunterDummy2
    • Unit - Order WitchHunterDummy2 to Neutral Dark Ranger - Silence (Position of (Triggering unit))
    • Custom script: set <unit> = null
    • Custom script: call RemoveLocation(udg_CasLoc)

 

[Death Adder]

since the variable isn't set before you use it, it will not be used it will be used but it will not have been set to something else than x=0, y=0 (center of map).

Set CasLoc = (Target point of ability being cast)
Unit - Create 1 Shards of Ice Dummy for (Triggering player) at CasLoc facing Default building facing degrees

 

[illum1nati]

since the variable isn't set before you use it, it will not be used it will be used but it will not have been set to something else than x=0, y=0 (center of map).

Set CasLoc = (Target point of ability being cast)
Unit - Create 1 Shards of Ice Dummy for (Triggering player) at CasLoc facing Default building facing degrees

Done, now jass gives me an error when i save the map.

• Witch Hunt Silence
  • Events
    • Unit - A unit Finishes casting an ability
  • Conditions
    • (Ability being cast) Equal to Witch Hunt
  • Actions
    • Set CasLoc = (Target point of ability being cast)
    • Unit - Create 1 Shards of Ice Dummy for (Triggering player) at CasLoc facing Default building facing degrees
    • Set WitchHunterDummy2 = (Last created unit)
    • Unit - Add a 1.00 second Generic expiration timer to WitchHunterDummy2
    • Unit - Add Witch Hunt Silence to WitchHunterDummy2
    • Unit - Order WitchHunterDummy2 to Neutral Dark Ranger - Silence CasLoc)
    • Custom script: set udg_WitchHuntDummy2 = null
    • Custom script: call RemoveLocation(udg_CasLoc)

 

[Vinz]

Oh and what I mean by <unit> is udg_WitchHuntDummy2.

You don't need to name these variables specific names; they are temporary. You can use TempUnit, TempPoint, TempPoints (for arrays), etc.

Also Order the dummy to cast at CasLoc.

 

[illum1nati]

GIves me an error "undeclared variable udg_WitchHuntDummy2" Edited: nvm i'm dumb, spelled it wrong. Gonna test the trigger now

• Witch Hunt Silence
  • Events
    • Unit - A unit Finishes casting an ability
  • Conditions
    • (Ability being cast) Equal to Witch Hunt
  • Actions
    • Set CasLoc = (Target point of ability being cast)
    • Unit - Create 1 Shards of Ice Dummy for (Triggering player) at CasLoc facing Default building facing degrees
    • Set WitchHunterDummy2 = (Last created unit)
    • Unit - Add a 1.00 second Generic expiration timer to WitchHunterDummy2
    • Unit - Add Witch Hunt Silence to WitchHunterDummy2
    • Unit - Order WitchHuntDummy2 to Neutral Dark Ranger - Silence CasLoc
    • Custom script: udg_WitchHunterDummy2 = null
    • Custom script: call RemoveLocation(udg_CasLoc)

 

[Death Adder]

because it's udg_WitchHuntERDummy2

 

[Vinz]

Oh crap, "udg_WitchHunterDummy2"; the same name as your variable. Sorry.

 

[illum1nati]

Oh crap, "udg_WitchHunterDummy2"; the same name as your variable. Sorry.

Nah it was my bad, spelled variable "Hunter" and not "Hunt" for some reason
Silence after the ability still doesn't work for some reason. Maybe it has something to do with the end of channeling or silence ability.

 

[Vinz]

a. Can the dummy cast? (spell research requirements, mana cost, etc.)
b. Is the dummy casting fast enough for 1s? (cast backswing/point, ability casting time)
c. Make sure dummy has 0 movement speed, and Flying movement type.

 

[illum1nati]

a. Can the dummy cast? (spell research requirements, mana cost, etc.)
b. Is the dummy casting fast enough for 1s? (cast backswing/point, ability casting time)
c. Make sure dummy has 0 movement speed, and Flying movement type.

This Dummy is already used in other triggers and they're working fine(Those triggers werent made by me), so i think dummy isn't the problem. However the ability is the "Item Silence ability", it could do smth with this. Ima check what you wrote tho.

 

[illum1nati]

Well, it still doesn't work. Anyways, thanks a lot for the help, guys.

 

[Vinz]

Ouh.. most likely the problem is in Object Editor, because there is nothing wrong with the trigger.

 

[Death Adder]

Maybe that item silence ability doesn't have the same order id string as banshee ranger silence, try changing the ability.

also actually, isn't it supposed to be finishes channeling an ability? (not casting)

 

[illum1nati]

Maybe that item silence ability doesn't have the same order id string as banshee ranger silence, try changing the ability.

also actually, isn't it supposed to be finishes channeling an ability? (not casting)

There's no "finishes channeling an ability", only casting. I've tried different abilities, didnt work.

 

[Vinz]

Does it work with starts effect of an ability? Just checking, not really gonna settle with that.

 

[illum1nati]

Does it work with starts effect of an ability? Just checking, not really gonna settle with that.

Nope, it does not. The caster is a flying unit tho (dragon) if that matters

 

[Death Adder]

ehm, I just thought of something, why is it "target point of ability being cast" when it's a PBAoE btw? it should be "unit position of triggering unit" xd

 

[illum1nati]

ehm, I just thought of something, why is it "target point of ability being cast" when it's a PBAoE btw? it should be "unit position of triggering unit" xd

Changed that. It finally works! Thanks a lot guys! I've already gave you both +rep, not sure if i can do that again!

 

[Vinz]

I thought PBAoE is a point target.

 

[Death Adder]

Player Based Area of Effect, it's not a very accurate term to use in an RTS style game (like wc3) though since the player doesn't necessarily control only one character but yeah...

 

[Vinz]

Here it is called instant or No Target abilities. :3

 

[Death Adder]

Here it is called instant or No Target abilities. :3

No Target doesn't specify what it does though. PBAoE means that it's an Area of Effect centered around the player character, like warstomp for instance, while No Target might as well be berserk or something.

For choosing between target point or position of unit we only need what type of targeting. But knowing that the ability were an area of effect (due to the silence ability) I specified it to PBAoE.