Fire Circle v1.06b

Moderator · Feb 9, 2013

Fire Circle v1.06b | Reviewed by Maker | 3rd Aug 2013

APPROVED

	You did a good job fixing the performance issue, now there is no fps drop The effects are good
	Add some follow through time so the caster does the cast animation properly You could store the handle id of picked unit into a variable and use the variable

[tr]

Fire Circle v1.03 | Reviewed by Maker | 21st Jul 2013

NEEDS FIX

	Fire Circle Damage should be initially off and turned off when the trigger is not needed Store the ability level when you cast the spell, and load it in the looping trigger
	Your comments should be in English Remove upgrades used from the dummies You could use looping in Fire Circle Start to shorten the code You could reduce the FPS drop and effect spam by choosing and effect that leaves a trail and creating the effects less often You could reduce the fps drop by using SetUnitX and SetUnitY instead of Move unit instantly

[tr]

Fire Circle v1.02 | Reviewed by Maker | 18th Feb 2013

Needs Fix

Required changes

There is a location leak when you create the tree cutter dummy
You are spamming too many effects causing FPS drop

Suggested changes

You could reduce the amount of lines in Fire Circle Start if you looped the angle.
First the angle is facing - x and then increase by x during every loop
You can simplify your damage condition with this method:
- ((Picked unit) is A structure) Equal to FC_Damage_Building

Useful Links

Things that leak

[td]

[/TD]

Lord_Demon_X · Feb 9, 2013

~Reserved~

retard · Feb 9, 2013

damaging the unit needs some work it just damages one unit

Almia · Feb 10, 2013

Review:
1)Casting Unit -> Triggering Unit
2)Set FC_Caster = Triggering Unit
3)Set FC_Face = Facing Angle of FC_Caster
4)Set FC_Level = Level of FC_Ability for (Casting unit)
5)120.00 add to the configuration
6)Fix your way of indexing
7)Inside the For Loop Integer,please put this:

-------- We create the 1st dummy and save his handle and the value of the angle --------
- Set TmpPoint2 = (TmpPoint offset by 90.00 towards FC_Angle1 degrees)
- UnitÃ© - Create 1 Dummy (Fire Circle) for (Owner of (Casting unit)) at TmpPoint2 facing Orientation bÃ¢timent par dÃ©faut degrees
- Table de hachage - Save FC_Angle1 as 1 of FC_Count in FC_Hashtable
- Table de hachage - Save FC_Angle2 as 3 of FC_Count in FC_Hashtable
- Table de hachage - Save FC_Angle3 as 5 of FC_Count in FC_Hashtable
- Table de hachage - Save Handle Of(Last created unit) as 2 of FC_Count in FC_Hashtable
- UnitÃ© - Set level of FC_Dummies_Ability for (Last created unit) to (Level of FC_Ability for (Casting unit))
- Effet spÃ©cial - Create a special effect at TmpPoint2 using FC_SFX
- Effet spÃ©cial - Destroy (Last created special effect)
- Custom script: call RemoveLocation(udg_TmpPoint2)
- -------- We create the 2nd dummy and save his handle --------
- Set TmpPoint2 = (TmpPoint offset by 90.00 towards FC_Angle2 degrees)
- UnitÃ© - Create 1 Dummy (Fire Circle) for (Owner of (Casting unit)) at TmpPoint2 facing Orientation bÃ¢timent par dÃ©faut degrees
- UnitÃ© - Set level of FC_Dummies_Ability for (Last created unit) to (Level of FC_Ability for (Casting unit))
- Table de hachage - Save Handle Of(Last created unit) as 4 of FC_Count in FC_Hashtable
- Effet spÃ©cial - Create a special effect at TmpPoint2 using FC_SFX
- Effet spÃ©cial - Destroy (Last created special effect)
- Custom script: call RemoveLocation(udg_TmpPoint2)
- -------- We create the 3rd dummy and save his handle --------
- Set TmpPoint2 = (TmpPoint offset by 90.00 towards FC_Angle3 degrees)
- UnitÃ© - Create 1 Dummy (Fire Circle) for (Owner of (Casting unit)) at TmpPoint2 facing Orientation bÃ¢timent par dÃ©faut degrees
- UnitÃ© - Set level of FC_Dummies_Ability for (Last created unit) to (Level of FC_Ability for (Casting unit))
- Table de hachage - Save Handle Of(Last created unit) as 6 of FC_Count in FC_Hashtable
- Effet spÃ©cial - Create a special effect at TmpPoint2 using FC_SFX
- Effet spÃ©cial - Destroy (Last created special effect)

8)TempPoint2 should be PC_TempPoint2
9)You dont need a hashtable for this.Hashtable + indexing for a spell is ugly.
You can get the right unit like this:

set Index = 0
For Each (Integer A) from 1 to MaxIndex , do (Actions)
- Loop - Actions
  - If Unit[Integer A] is Equal To Unit[CurrentIndex] then
    - Set Index = Integer A
  - endif

This is all of the things i can give now because you have a different language

Lord_Demon_X · Feb 10, 2013

I know, indexing + hashtable is ugly but this is the only way I found, because creating dummies used for the handle use more space for each time the spell is casted.

1)Casting Unit -> Triggering Unit

Done.

2)Set FC_Caster = Triggering Unit

It will makes me use an unnecessary variable, and saving the caster is useless if I use hashtable.

3)Set FC_Face = Facing Angle of FC_Caster

Same as 2) , unnecessaries variables, I don't remember that Facing Angle leaks

4)Set FC_Level = Level of FC_Ability for (Casting unit)

Using this variable has the only effect of preventing ability-levelup when the spell is used
and makes the code more readable. Added

5)120.00 add to the configuration

If changed, the circle won't be a circle, it has just for effect to change the graphical effect of the spell. Added

6)Fix your way of indexing

I suppose, you're saying that I must remove the use of hashtable and use indexing method ? I can do this but it will takes a while for rewrite the spell.

7)Inside the For Loop Integer,please put this:

Moving the dummies creation inside of the loop, why ? I don' truely understand.

8)TempPoint2 should be FC_TempPoint2

And I suppose that TmpPoint => FC_TempPoint ? This won't change anything. Done

9)You dont need a hashtable for this.Hashtable + indexing for a spell is ugly.
You can get the right unit like this:

You're saying that I must rewrite the spell with indexing isn't it ?

Almia · Feb 10, 2013

Cache variables adds speed in interpretation.
Computer interprets every functions that are used.That's why you need to cache it.
No.5 must be inside a real variable,put it in the configuration.
Then use it like
set angle = angle - theangle

8)this prevents variable name collision
9)yes
7)You are repeating the actions all over again,which are unacceptable way of coding

DESTROYER123 · Feb 10, 2013

Looks really cool but I believe it will cause lags if overused.......

Lord_Demon_X · Feb 10, 2013

For the 7) can you give me a example how I should index the dummies in the loop please ?

Because I made something but it don't look terrific.

Fire Circle Start
- Events
  - Unit - A unit Initie l'effet d'une compÃ©tence
- Conditions
  - (Ability being cast) Equal to* FC_Ability
- Actions
  - Custom script: local integer i = 1
  - Set FC_Count = (FC_Count + 1)
  - Set FC_Count3 = FC_Count
  - Set FC_Caster[FC_Count] = (Casting unit)
  - Set FC_Level[FC_Count] = (Level of FC_Ability for FC_Caster[FC_Count])
  - -------- We save the handle of the caster in the hashtable and set the angle of the dummies --------
  - Table de hachage - Save Handle Of(Casting unit) as 0 of FC_Count in FC_Hashtable
  - Set FC_Angle1[FC_Count] = (Facing of FC_Caster[FC_Count])
  - Set FC_Angle2[FC_Count] = ((Facing of FC_Caster[FC_Count]) + FC_Angle_Between_Bolts)
  - Set FC_Angle3[FC_Count] = ((Facing of FC_Caster[FC_Count]) - FC_Angle_Between_Bolts)
  - Set FC_TmpPoint = (Position of (Triggering unit))
  - -------- We create the 1st dummy and save his handle and the value of the angle --------
  - Custom script: loop
  - Custom script: exitwhen i > 3
  - Custom script: if i == 1 then
  - Set FC_TmpPoint2 = (FC_TmpPoint offset by 90.00 towards FC_Angle1[FC_Count] degrees)
  - Unit - Create 1 Dummy (Fire Circle) for (Owner of FC_Caster[FC_Count]) at FC_TmpPoint2 facing Orientation default building facing degrees
  - Set FC_Dummy1[FC_Count] = (Last created unit)
  - Unit - Set level of FC_Dummies_Ability for FC_Dummy1[FC_Count] to FC_Level[FC_Count]
  - Custom script: elseif i == 2 then
  - Set FC_TmpPoint2 = (FC_TmpPoint offset by 90.00 towards FC_Angle2[FC_Count] degrees)
  - Unit - Create 1 Dummy (Fire Circle) for (Owner of FC_Caster[FC_Count]) at FC_TmpPoint2 facing Orientation default building facing degrees
  - Set FC_Dummy2[FC_Count] = (Last created unit)
  - Unit - Set level of FC_Dummies_Ability for FC_Dummy2[FC_Count] to FC_Level[FC_Count]
  - Custom script: elseif i == 3 then
  - Set FC_TmpPoint2 = (FC_TmpPoint offset by 90.00 towards FC_Angle3[FC_Count] degrees)
  - Unit - Create 1 Dummy (Fire Circle) for (Owner of FC_Caster[FC_Count]) at FC_TmpPoint2 facing Orientation default building facing degrees
  - Set FC_Dummy3[FC_Count] = (Last created unit)
  - Unit - Set level of FC_Dummies_Ability for FC_Dummy3[FC_Count] to FC_Level[FC_Count]
  - Custom script: endif
  - Special Effect - Create a special effect at FC_TmpPoint2 using FC_SFX
  - Special Effect - Destroy (Last created special effect)
  - Custom script: call RemoveLocation(udg_FC_TmpPoint2)
  - Custom script: set i = i + 1
  - Custom script: endloop

Done all others things you suggested.

gorillabull · Feb 11, 2013

DESTROYER123 said:
Looks really cool but I believe it will cause lags if overused.......

yes it will just like any other spell that gets spammed too many times.........

Almia · Feb 12, 2013

Look at some spells works like yours.
Like this:
http://www.hiveworkshop.com/forums/spells-569/kinetic-ring-v1-3-a-220215/?prev=status=a&u=Almia

T. D. W. · Jul 1, 2013

The Damage trigger is very bad, it uses 1 s loop which is very high for a dynamic spell
and like other users said, it spams particles
It needs fix, contact Maker or magtheridon to at least moderate the current version (1.4)
You like circle spells which destroys trees ha,, check this
oh and btw:
Oh, un français MDR, j'en suis pas un moi

2/5, NEEDS FIX

deathismyfriend · Jul 2, 2013

anything u use twice or more should be stored into a variable and the variable should be used. ex: picked unit.

Uyarrr · Jul 3, 2013

Omg Awesome!

deathismyfriend · Jul 31, 2013

As said this needs to be in english

change this to use the variable u set above it.

Set FC_TmpHandle = (Last created unit)

anything u use twice or more store into a variable and use the variable. ex store this in an integer variable (Key FC_TmpHandle)
This is for speed and efficiency

use the variable u set above this.

Set FC_TmpHandleDummy = (Picked unit)

store picked unit b4 this and use it in place of picked unit.

((Picked unit) is Un bÃ¢timent) Egal Ã* FC_Damage_Building
((Picked unit) is Insensible Ã* la magie) Egal Ã* FC_Damage_Immune

Lord_Demon_X · Aug 1, 2013

deathismyfriend said:
As said this needs to be in english

Eveything is in english (in fact, everything except comments is between french and english but that's because I'm french so I don't often install games in english.)

change this to use the variable u set above it.

Set FC_TmpHandle = (Last created unit)

Groupe unitÃ© - Add (Last created unit) to FC_Group

I can't do it because that's not "allowed" by the editor to store a handle in the unit group (I can load the handle of an unit from an hashtable but not add the handle into a group)

anything u use twice or more store into a variable and use the variable. ex store this in an integer variable (Key FC_TmpHandle)
This is for speed and efficiency

I'm not really sure that storing the handle variable in another variable will really increase the speed.

use the variable u set above this.

Set FC_TmpHandleDummy = (Picked unit)

Groupe unitÃ© - Remove (Picked unit) from FC_Group

Done, nothing to say.

store picked unit b4 this and use it in place of picked unit.

((Picked unit) is Un bÃ¢timent) Egal Ã* FC_Damage_Building

((Picked unit) is Une unitÃ© volante) Egal Ã* FC_Damage_Air

((Picked unit) is Un hÃ©ros) Egal Ã* FC_Damage_Heroes

((Picked unit) is MÃ©canique) Egal Ã* FC_Damage_Mechanical

((Picked unit) is Insensible Ã* la magie) Egal Ã* FC_Damage_Immune

((Picked unit) is Une unitÃ© terrestre) Egal Ã* FC_Damage_Ground

You want me to store a group that is instantly destroyed with the bj_wantDestroyGroup into a group variable that I'll have to nullify just 5-6 lines after ? I don't really see the point.

So, it would be great to explain me why the changes mentionned above are necessary and how could/should I do with those which aren't "allowed" by the editor.

Tasyen · Nov 7, 2018

This spell does not deal damage V1.06b: Detector nerdcafe. This spell deal zero damage

Fire Circle v1.06b

Fire Circle v1.06b (Map)

Moderator

Moderator

Similar threads