[size=5
Arena of Might
[/size]]
IamFootman061 Review
...
How can this post possible be map review?
You must not discourage him. Maybe just put some suggestions. Do not put people down on their map. It will discourage them to make another map.
He did gave him suggestions. But I can't agree on this 2nd part. You see life will never go easy on you. As soon as you learn that life is harsh and that you are alone in everything you do, that's better for you. When you gather strength to stand and fight alone you will have some chance to succeed. Same goes for map section, it's not about how much 5/5 ratings you can get, it's about how many 1/5 you won't. There is no point in making 2 or 10 maps if they all suck.
Ok, but i don't get one thing, how did this map
http://www.hiveworkshop.com/forums/...77838/?prev=status=a&search=arena&d=list&r=20 got 4 rating + approved and it too doesn't have custom items, abilities, few icons not matching the heroes , not a lot of items, skills are copy-pasted, not impressive terrain?? Can someone answer me that? Basicly same things my map has/had
Maps uploaded in that time were accepted here like they are on EpicWar. Only requirements were no viruses and no porn.
EDIT:
Map terrain is horrible.
Space is divided into 4 sections (hero selection, arena, abilities upgrade area and battleground or whatever).
Now all those shops take 2 much space, they are small sized and could fit into some corner of the map just fine or some base, creep camp whatever.
Recipe shop show recipes as icons, pro map makers don't do it like that, you display item with icons, swap those with recipes after selling and use recipes in crafting again to get final items.
All that space around (shallow water around map is useless, you should add some ramps or something to increase playable area size).
Missing environment doodads.
Missing lightning and special effect doodads.
Missing terrain tiles variation and some unique terrain crafting skills worth showing.
Dunno how to help you here, start with Blizzard melee maps, check how they made terrain.
When you understand basic of it you should move forward advanced tutorials.
Coding is really as well bad.
Memory leaks.
JASS:
function Trig_Vampiric_Aura_2_Actions takes nothing returns nothing
call RemoveItem(GetItemOfTypeFromUnitBJ(GetManipulatingUnit(),'I01E'))
call UnitRemoveAbilityBJ('A01R',GetTriggerUnit())
call UnitAddAbilityBJ('A01S',GetTriggerUnit())
call AddSpecialEffectLocBJ(GetUnitLoc(GetTriggerUnit()),"Abilities\\Spells\\Human\\ThunderClap\\ThunderClapCaster.mdl")
call DisableTrigger(GetTriggeringTrigger())
endfunction
This is how your gui trigger Vampiric Aura 2 actions look like when converted to jass.
You never destroy special effect you create.
Also GetUnitLoc will return unit location that won't be destroyed as well.
Should I mention that you have quite a lot of those triggers.
JASS:
if(Trig_Remove_Units_Func002001())then
call ForGroupBJ(GetUnitsOfPlayerAll(Player(0)),function Trig_Remove_Units_Func002002002)
else
call DoNothing()
endif
if(Trig_Remove_Units_Func003001())then
call ForGroupBJ(GetUnitsOfPlayerAll(Player(1)),function Trig_Remove_Units_Func003002002)
else
call DoNothing()
endif
// this goes down forever...
Don't use Do Nothing trigger action it create this
call DoNothing()
jass line that call empty function.
JASS:
function DoNothing takes nothing returns nothing
endfunction
Just ignore that and code will work perfectly fine.
This was added only for one lined if the else gui trigger action where you needed field value to be filed.
Another bad thing here is that you create same checking for each player.
Use for loop and instead of Player(0), Player(1) use IndexA or custom variable.
GetUnitsOfPlayerAll(Player(0))
Here you leak unit group.
Ok will stop for now, this should be more than enough for start.
Search for tutorials about memory leaks.
Search for tutorials about GUI trigger efficiency.
Gameplay is all about fancy custom imported models.
You just increase map size for nothing. Use those models for bosses or some epic units in game.
No game modes.
No game difficulties or some special setup.
There is no re-playability in 1 word, after 1 or 2 games no one will play map again.
You must keep players interested, each game should be unique and different.
May I ask why you use 3 same abilities when you can use 3 levels of same ability instead?
Just level up ability when you learn level instead of removing old and adding new one.
There are many flaws and errors in general here.
You should work more on this map before next update.
Useful Links:
The Important Site Rules.
You can use Map Development Section for testing and improving your maps.
Need help with triggers/memory leaks? Make a thread in the Triggers & Scripts Section.
Got any World Editor related questions? Make a thread in the World Editor Help Zone Section
Got any Requests (Terrain, resources, spells, systems, loading screens...)? Make a thread in the Requests Section.
The Important Site Tutorials.
If you have any complaints or questions about your map, please make a thread here: Map Resource Moderation.