19:53, 30th Nov 2009
TriggerHappy:

Some of the effects are a little... much.

• Point_Temp leaks. You need to store the casting unit's position.
• It leaks in several triggers (most in which it's been used).

Aside from that, it looks good. Fix the leaks first.

nice in-game although the effect is a bit slow, ehmm... too slow.
it leaks a lot of location, and the spells aren't MUI either..
but the idea is great, and the way the effect move is so smooth...

I don't use any waits and I properly use RemoveLocation each time I call a point. So, it is MUI and location-leakless. That is danmaku, the effect is slow, coz it is an instant kill if you use fast effects

Would you be so kind to post the triggers here?

• AtChannelLunaticBullets
  • Events
    • Unit - A unit Begins channeling an ability
  • Conditions
    • (Ability being cast) Equal to Mind Sign - Lunatic Bullets
  • Actions
    • For each (Integer Int_Temp[1]) from 1 to 12, do (Actions)
      • Loop - Actions
        • Set Point_Temp = ((Position of (Casting unit)) offset by 10.00 towards ((Real(Int_Temp[1])) x 30.00) degrees)
        • Unit - Create 1 Danmaku Bullet 1 for (Owner of (Casting unit)) at Point_Temp facing ((Real(Int_Temp[1])) x 30.00) degrees
        • Custom script: call RemoveLocation (udg_Point_Temp)
        • Set Point_Temp = ((Position of (Last created unit)) offset by 300.00 towards (Facing of (Last created unit)) degrees)
        • Unit - Order (Last created unit) to Move To Point_Temp
        • Custom script: call RemoveLocation (udg_Point_Temp)
        • Unit - Add a 1.50 second Generic expiration timer to (Last created unit)

You only need to remove locations at the end of every loop/trigger. Remove the others and save a lot of line space. Also use triggering unit instead of casting/dying etc.

Frunck said:

• AtChannelLunaticBullets
  • Events
    • Unit - A unit Begins channeling an ability
  • Conditions
    • (Ability being cast) Equal to Mind Sign - Lunatic Bullets
  • Actions
    • For each (Integer Int_Temp[1]) from 1 to 12, do (Actions)
      • Loop - Actions
        • Set Point_Temp = ((Position of (Casting unit)) offset by 10.00 towards ((Real(Int_Temp[1])) x 30.00) degrees)
        • Unit - Create 1 Danmaku Bullet 1 for (Owner of (Casting unit)) at Point_Temp facing ((Real(Int_Temp[1])) x 30.00) degrees
        • Custom script: call RemoveLocation (udg_Point_Temp)
        • Set Point_Temp = ((Position of (Last created unit)) offset by 300.00 towards (Facing of (Last created unit)) degrees)
        • Unit - Order (Last created unit) to Move To Point_Temp
        • Custom script: call RemoveLocation (udg_Point_Temp)
        • Unit - Add a 1.50 second Generic expiration timer to (Last created unit)

Click to expand...

thank God finally someone upload the trigger...

• Set Point_Temp = ((Position of (Casting unit)) offset by 10.00 towards ((Real(Int_Temp[1])) x 30.00) degrees)

this is the location that leaks, because it creates 2 location, one is the position of casting unit, and 2nd is the polar projection. you only save the polar one so the 1st location leaks...

and yes, I have to admit that your spells is MUI after further read IMO. sorry

• Set Point_Temp = ((Position of (Casting unit)) offset by 10.00 towards ((Real(Int_Temp[1])) x 30.00) degrees)

You should use as many variables as many you need. Not only one, because it will cause leaks.

• AtChannelLunaticBullets
• Events
• Unit - A unit Begins channeling an ability
• Conditions
• (Ability being cast) Equal to Mind Sign - Lunatic Bullets
• Actions
• For each (Integer Int_Temp[1]) from 1 to 12, do (Actions)
• Loop - Actions
• Set Point_Temp = ((Position of (Casting unit)) offset by 10.00 towards ((Real(Int_Temp[1])) x 30.00) degrees)
• Unit - Create 1 Danmaku Bullet 1 for (Owner of (Casting unit)) at Point_Temp facing ((Real(Int_Temp[1])) x 30.00) degrees
• Custom script: call RemoveLocation (udg_Point_Temp)
• Set Point_Temp = ((Position of (Last created unit)) offset by 300.00 towards (Facing of (Last created unit)) degrees)
• Unit - Order (Last created unit) to Move To Point_Temp
• Custom script: call RemoveLocation (udg_Point_Temp)
• Unit - Add a 1.50 second Generic expiration timer to (Last created unit)

Oh yeah I missed that It should be something like this:

• AtChannelLunaticBullets
• Events
• Unit - A unit Begins channeling an ability
• Conditions
• (Ability being cast) Equal to Mind Sign - Lunatic Bullets
• Actions
• For each (Integer Int_Temp[1]) from 1 to 12, do (Actions)
• Loop - Actions
• Set Point_Temp = ((Position of (Casting unit)) offset by 10.00 towards ((Real(Int_Temp[1])) x 30.00) degrees)
• Unit - Create 1 Danmaku Bullet 1 for (Owner of (Casting unit)) at Point_Temp facing ((Real(Int_Temp[1])) x 30.00) degrees
• Set Point_Temp = ((Position of (Last created unit))
• Set Point_Temp2 = Point_Temp offset by 300.00 towards (Facing of (Last created unit)) degrees)
• Unit - Order (Last created unit) to Move To Point_Temp
• Unit - Add a 1.50 second Generic expiration timer to (Last created unit)
• Custom script: call RemoveLocation (udg_Point_Temp)
• Custom script: call RemoveLocation (udg_Point_Temp2)

So I don't need to remove the point every time I use it?
I should remove it before waits or at the end of the trigger instead?
Thank you guys
I'll fix it ^^;

btw, can I use Point_Temp[1] ~ Point_Temp[n]?

So I don't need to remove the point every time I use it?

Click to expand...

No. If you don`t change it, you can remove it at the end of trigger.

EDIT:

• Set Point_Temp = ((Position of (Casting unit)) offset by 10.00 towards ((Real(Int_Temp[1])) x 30.00) degrees)
• Unit - Create 1 Danmaku Bullet 1 for (Owner of (Casting unit)) at Point_Temp facing ((Real(Int_Temp[1])) x 30.00) degrees
• Set Point_Temp = ((Position of (Last created unit))
• Set Point_Temp2 = Point_Temp offset by 300.00 towards (Facing of (Last created unit)) degrees)

But this one leaks.

• Custom script: call RemoveLocation (udg_Point_Temp)

This function is to not overwrite variable, because it takes more memory. In your trigger you leak it

• Set Point_Temp = ((Position of (Casting unit)) offset by 10.00 towards ((Real(Int_Temp[1])) x 30.00) degrees)
• Unit - Create 1 Danmaku Bullet 1 for (Owner of (Casting unit)) at Point_Temp facing ((Real(Int_Temp[1])) x 30.00) degrees
• Set Point_Temp = ((Position of (Last created unit))

here.

You overwrite once setted Point_Temp.

It should be

• Set Point_Temp = ((Position of (Casting unit)) offset by 10.00 towards ((Real(Int_Temp[1])) x 30.00) degrees)
• Unit - Create 1 Danmaku Bullet 1 for (Owner of (Casting unit)) at Point_Temp facing ((Real(Int_Temp[1])) x 30.00) degrees
• Custom script: call RemoveLocation (udg_Point_Temp)
• Set Point_Temp = ((Position of (Last created unit))

Or even better Position of Last Created Unit set to other variable, to make coding clearlier.

Lol. Not becuz u dont use any waits that the triggers are in MUI.
there is 2 way to make ur triggerd in MUI : Using Indexes or Hashtables.
didnt check ur trigger so idk if u use indexs or hashtables.

(For spells that are needing a Periodic Event)

I've checked the triggers and u have 2 periodic events...
witch means u have 2 triggers that arent in MUI

effects of the spells are tooooooo big and it cuz lag.
also.. i got a fatal error using the Lunatic Bullets spell >.>

Nice effects! But the coding you need to improve.

I am waiting for this to get cleared off leaks. Then, I'm definitively using it. Thanks.