Would this trigger cause lag?

[Qrom Bellascream]

• ZombieSpawnsSpawn
  • Events
    • Time - Every (Random real number between 2.00 and 4.00) seconds of game time
  • Conditions
  • Actions
    • Unit - Create 1 Zombie for Player 12 (Brown) at (Center of SpawnZombieSpawner[(Random integer number between 1 and AmountOfZombieSpawners)]) facing Default building facing degrees
    • For each (Integer A) from 1 to 10, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Or - Any (Conditions) are true
              • Conditions
                • (Distance between (Position of (Last created unit)) and (Position of PlayerUnit[(Integer A)])) Greater than Distance
          • Then - Actions
            • Unit - Remove (Last created unit) from the game
            • Trigger - Run (This trigger) (ignoring conditions)
          • Else - Actions
    • Unit Group - Add (Last created unit) to ALLZombies
    • AI - Ignore (Last created unit)'s guard position
    • Unit - Order (Last created unit) to Attack-Move To (Position of PlayerUnit[(Random integer number between 1 and 4)])

I'm mostly worried about the distance check part. It checks if the place where the zombie spawned is atleast 6000 meters from the nearest hero unit, and if it isn't it kills the zombie and spawns it at another random location, hopefully near the hero. Would this trigger cause lag if the zombie somehow spawned like 5 times in a row at a distance too far away from a hero?

 

[KILLCIDE]

Yes it would. You are creating a ton of locations and not clearing them properly. I advise you take a look at Memory Leaks.

 

[Dr Super Good]

Time - Every (Random real number between 2.00 and 4.00) seconds of game time

This might not do what you think it does. At map initialization it will roll a random real between 2 and 4 and then periodically every that period run the trigger. For example if it rolled 2.50 it would then have a period of exactly 2.50 seconds for the rest of the game. You might want to use a timer instead that each tick you restart with a random timeout of 2.00 to 4.00.

As KILLCIDE mentioned, it leaks a lot of location object. These can degrade game performance over time.

 

[Qrom Bellascream]

yeah, I looked over some triggers and noticed alot of leaks with the "location of unit" and I've cleaned them already. But the part with rerunning the trigger, would that cause lag on its own?

 

[KILLCIDE]

If you have cleared the 4 location leaks (technically 22), then it shouldn't. You can improve it by not repeating function calls and storing things into variables and referencing them instead (like Last created unit).

You should also keep note of what DSG said about the periodic event.

 

[Dr Super Good]

But the part with rerunning the trigger, would that cause lag on its own?

Getting the trigger to start a timer does not produce any leaks. Trigger event should be when a timer expires and the trigger restarts the timer at the end of the actions.