[vJass] (System) CustomInventory

[CHA_Owner]

All i can say is +rep not 1 bug for me

 

[Vengeancekael]

Alright now implement this in d3w and release 1.20 already

 

[Catch_ya]

When you press ESC during loading, the inventory system gets fired. So please do not do that.

What about turning on the ESC trigger 1 second after the game start?

 

[Anachron]

The bugs only appear when you INSTANTLY pickup all the items, so I guess its just overloading the wc3 to cause random bugs.

What about turning on the ESC trigger 1 second after the game start?

Good idea, I will implement it in the next version.

 

[CHA_Owner]

Actually i have a bug to report whenever i try to save the map using JNGP with EGUI it gives me this error (image attached)

EDIT*

my bad thats hard to read it says:
Line 923: unable to find textmacro: "optional"

 

[Anachron]

Actually i have a bug to report whenever i try to save the map using JNGP with EGUI it gives me this error (image attached)

EDIT*

my bad thats hard to read it says:
Line 923: unable to find textmacro: "optional"

This was asked before.
Also answered.

 

[mattstheman]

also i would like to see that a Two hand weapon really fils in the two weapon slots
now it looks strange with still one empty slot when you cannot equip anything there

Same here... when you equip a two handed weapon it would make sense to remove the other weapon slot.

 

[Anachron]

Same here... when you equip a two handed weapon it would make sense to remove the other weapon slot.

Yes, but its kinda hard to program.

 

[CHA_Owner]

This was asked before.
Also answered.

Alright i did what you said and it worked at first but when i saved a second time i got this error:

External not found in config file: "ObjectMerger"

sorry to bother you anachron

 

[Catch_ya]

Sorry if I missed something but where do you declare that the item slots and such is trackables? I need to change it to units. Will this be a big problem?

 

[Anachron]

Alright i did what you said and it worked at first but when i saved a second time i got this error:

External not found in config file: "ObjectMerger"

sorry to bother you anachron

Install a new JNGP version.

Sorry if I missed something but where do you declare that the item slots and such is trackables? I need to change it to units. Will this be a big problem?

Its a bigger thing. I will make it easier in the future.

 

[Catch_ya]

Its a bigger thing. I will make it easier in the future.

well I guess I have to wait more . By the way im glad you finished this congratulations.

 

[CloudMax]

Directors cut. This system soooo deserves it! Awesome that it is finally here! now i can try it myself insted of seeing you using it live

 

[CHA_Owner]

Yep system works fine now i just needed to update my jass helper thanks again anachron there not enough rep in the world

 

[Anachron]

No problem. Glad it helped.

 

[88WaRCraFT3]

I nice idea that can be add : something like double click on an item and that item will replace or move instantly to slot where it must be.

 

[Anachron]

Yeah, already suggested! Thanks anyway

 

[CHA_Owner]

Alright after playing around with your system some i found that if you clear the players selection when he presses the Esc. key (opens the inventory) that there will be no false right clicks which is what currently happens.

This is just a quick fix of course but you might want to try to get Ammorths right click detection script and disable right clicks while the inventory is opened which would be much more efficient then what i did.

Just thought this might help good luck on making this awesome system.

 

[Anachron]

Well I will just disable target object orders. So no problem.

 

[Roolipelaaja]

Niceeeeeeeeeeeeeee!

 

[bigapple90]

sweet. i assume you made this for your map ?

 

[Adiktuz]

yeah! downloading!

 

[Catch_ya]

Wuhu im in credits . Anachron I will review this when I get home. I also might ask some questions.

By the way this is the first spell / system that has gotten a Directors Cut!

 

[88WaRCraFT3]

Wuhu im in credits . Anachron I will review this when I get home. I also might ask some questions.

By the way this is the first spell / system that has gotten a Directors Cut!

And the best system.
Edit : Wooohooo im redownloaded a JNGP and Jasshelper, no problems. Thx i will +rep you when i can because you're get +rep.
Edit 2 : Shaman claws or Claws of attack are unable do set at left hand.
Edit 3 :

Is this bug?

Weapons can be on the potion slots? :/

 

[Anachron]

Shaman claws or Claws of attack are unable do set at left hand.

Excuse me, but they can? Try again?! Maybe you did something wrong.
Claws of attack is onehand, while Shamans Claws is twohander weapon.

Weapons can be on the potion slots? :/

Fixed.

 

[88WaRCraFT3]

Yeah, it works now. Maybe again something like lag or leak?-or blizzards mistake.
Do you want to make a video where will you show how to do something in fullscreen? - you 're say that before you post video
Edit : Can you make slots bigger, its hard to set an item when all other items are on requested slots.

 

[Anachron]

Check the main thread, I have already made 4 videos about this system.

 

[88WaRCraFT3]

Update inventory on hive. I was test the system again and potions can go on the weapon or every other slot but weapons can go on potions slots.
Yeah i see all 4 videos but it shows all things that this system have. Videos don't show how to do this.

 

[Anachron]

Guys, I found the source of ALL your problems. It has to do with the loading process.
I will update the hive version ASAP. Currently fixing all your bugs (hopefully).

 

[Vercas]

I once started working on a system like this too... And I've had to cancel it because something was crashing while loading...
That's not nice...

Anyway, is that thing with the doubled borders a bug or what? Ô_Ô

 

[Anachron]

Double borders? Where? He created them. Its just a destructable.

 

[88WaRCraFT3]

One suggestion maybe to move camera or inventory buttons a bit right?

 

[Catch_ya]

One suggestion maybe to move camera or inventory buttons a bit right?

I guess it would be easiest to move the camera. Else you have to give all the buttons a little higher x coordinate.

 

[Anachron]

0.1.U is now released.

Changelog:
Fixed some bugs when picking up items to fast. Now you can not pick items before the loading process has been finished.
Now only Potions can be equipped in potion slots.

Please tell me whether you still have bugs or not.
[Alright, still the pickup shouldn't be immediate.]

 

[wcOOOfan]

WOW so cool

 

[CHA_Owner]

Bugs/glitches

1.When the inventory is open you can still right click and run in random direction.

2.When i pick up a clarity potion my game now crashes.

3.When you move your mouse over the "sell" button or the "exit" button it should show on the multiboard what they are and what they are used for.

4.i personally think that the icons/buttons used are too dark and need to brighter but that could be changed by the users.

Thats all for now i will report more after next release hope this helps.

 

[mattstheman]

Yea, I also think that mousing over an empty slot, or the exit and drop buttons should all have something on the multiboard to say what they do.

 

[Catch_ya]

Yea, I also think that mousing over an empty slot, or the exit and drop buttons should all have something on the multiboard to say what they do.

It ain't that hard to code at all. You just add an On-Hover function to the exit and drop trackables. I guess Anachron could easily do this.

 

[karland90]

Weapons can be on the potion slots? :/

i actually regarded to that as a feature
i liked it

btw the overlapping borders dont look so good. when you do some things like equip an item then the borders flicker. a piece of border should end where the other piece of border starts.

imo you for the 2handers you should maybe use somekind of filter destructible (e.g. 75% transparent) on the other slot, so it shows that both slots are already used. but thats just my opinion.

about the nocturnal darkness of the icons you could use some kind of light source (similar to torches or more precisely the "light" doodad in UTM).

EDIT: if it isnt too difficult/time consuming then you could add stack numbers to items that can stack. just like the wow or standard w3 inventory.

btw why do you only use 4 of the 6 potion slots?

 

[Anachron]

To allow picking up items that are non-useable but still can be picked when all 4 slots are filled with potions.

 

[mattstheman]

About the potions, is there a way that you could make the potions move into their slot when you pick them up, instead of moving them there from your inventory.

 

[CHA_Owner]

Bugs/glitches

1.When the inventory is open you can still right click and run in random direction.

2.When i pick up a clarity potion my game now crashes.

3.When you move your mouse over the "sell" button or the "exit" button it should show on the multiboard what they are and what they are used for.

4.i personally think that the icons/buttons used are too dark and need to brighter but that could be changed by the users.

Thats all for now i will report more after next release hope this helps.

Just wandering if you read my suggestions since they were on the page before.

 

[Anachron]

It ain't that hard to code at all. You just add an On-Hover function to the exit and drop trackables. I guess Anachron could easily do this.

Exactly.

About the potions, is there a way that you could make the potions move into their slot when you pick them up, instead of moving them there from your inventory.

I will, but not now

Just wandering if you read my suggestions since they were on the page before.

I did, was just busy, sorry.

Bugs/glitches

1.When the inventory is open you can still right click and run in random direction.
>> That was more a feature that the hero can actually do any action while checking the inventory.
2.When i pick up a clarity potion my game now crashes.
>> With the last version? (0.1.U)?
3.When you move your mouse over the "sell" button or the "exit" button it should show on the multiboard what they are and what they are used for.
>> Yeah, I maybe add that later.
4.i personally think that the icons/buttons used are too dark and need to brighter but that could be changed by the users.
>> You can easily change that by changing the icons in the object editor.
Thats all for now i will report more after next release hope this helps.

Thanks.

 

[CHA_Owner]

Thanks for answering my post and also i do like the fact that you can still move with inventory open BUT i just want right clicks to be disabled while its open.

As in click to run to an area then open inventory do w/e then close inventory and your still on your way to the same area but without any accidental right clicks while inventory is open.

I'm shure you understand what im saying and i really enjoy how you can continue actions while the inventory is open.

Thats the whole reason i must edited it to deselect all unit/s belonging to triggering player then when you close it to reselect the unit/s which really works like a charm.

like i said thanks again and i will definitely be using this

 

[Anachron]

I already answered it here.

 

[mattstheman]

Thanks Anachron, good to know your working out all the flaws (although there are very few and putting in new features.

 

[The_Witcher]

Great System definitly deserves DC but it's very difficult for jass newbies to understand...

maybe add a HOW TO for them...

But for me it's perfect

Just one question: how did you rotate the pala in the inventory view so he can be seen in the window... you didn't create a custom unit and i don't want to look through that huge code....

 

[Anachron]

Well, its not even triggered, check object editor and the fake paladin.

About the howto:
Really no. I mean its that complicated that you really need high vJass knowledge to change it, so a how to for non-Jassers would really be bad.

Edit: Okay guys, I finally know what to do.
Because of the really fast pickups I will have to wait until you haven't picked up for a second.
That means, after 1 second of your last pickup, the inventory goes through all kind of functions, like stacking, forging, combining, enchanting, item set checking and such.
This means you either have to pick up items slower or wait for the inventory for being finished.

This will hopefully remove all the pickup bugs which are created through stack overflow.

 

[Alfagar]

Holly shit! I just peed my pants! It's finally here(I still won't use it lol)! You're the man, Anachron, whose the man? You!
I like that you added those icons there.

Edit: I'm still peeing

 

[Anachron]

Rofl, glad you like it.
Why won't you use it anyway?

Edit:
# Update - 0.1.V is online.

Changelog
Inventory now refreshes after one second doing something,
preventing mass item pickups to cause a stack overflow at wc3 and creating bugs in my system.

# Update - 0.1.W is online.

Changelog
Fixed a very big bug in the stacking module, causing random items to be removed,
inventory to not displayed correctly, thread crashes and such things. Now its fixed.

# Update - 0.1.X is online.

Changelog
Added an automatic destructable creater script written by Ammorth at wc3c.net.
You can check it here.