Revive System v1.1

[Moderator]

16:18, 4th Mar 2011
Bribe:

I can't see this getting an approval as Base's library is so much better as-is. It's Ryoko's submission, as well, it's not even yours :O

Next time you submit something, make sure it's yours and also ... post the triggers!

Status: Rejected

 

[baassee]

This is made from a tutorial by Ryoko. This tutorial is very outdated and it uses polledwait which leaks a timer as it isn't nulled only destroyed.

And it uses loads of BJs and leaks a location too.

 

[Magtheridon96]

post the triggers please
-----------------------

this system is only useful because it saves time. Instead of writing the code, you could just download it from here and copy-paste it. (unless it's horrible)

I think it's AWESOME... Scratch that: HORRIBLE

I implemented this system from thehelper.net 7 months ago, but I had to do A LOT of modifications to it.

As "baassee" said, i had to null the timer and fix the location leak.

 

[baassee]

• Revive Hero
  • Events
    • Unit - A unit Dies
  • Conditions
    • ((Triggering unit) is A Hero) Equal to True
  • Actions
    • Custom script: local timerdialog WINDOW
    • Custom script: local integer HEROWAIT
    • Custom script: local timer OURTIMER
    • Custom script: local unit OURHERO
    • Custom script: set OURHERO = GetDyingUnit()
    • Custom script: set HEROWAIT = ( GetHeroLevel(OURHERO) * 5 )
    • Custom script: set OURTIMER = CreateTimer()
    • Custom script: call StartTimerBJ( OURTIMER, false, ( I2R(HEROWAIT) ))
    • Custom script: call CreateTimerDialogBJ( OURTIMER, GetPlayerName(GetOwningPlayer(OURHERO)) )
    • Custom script: set WINDOW = GetLastCreatedTimerDialogBJ()
    • Custom script: call TimerDialogDisplayForPlayerBJ( true, WINDOW, GetOwningPlayer(OURHERO) )
    • Custom script: call PolledWait( HEROWAIT )
    • Custom script: call ReviveHeroLoc(OURHERO, GetRectCenter(GetPlayableMapRect()), true )
    • Custom script: call PanCameraToTimedLocForPlayer( GetOwningPlayer(OURHERO), GetUnitLoc(OURHERO), 0.60 )
    • Custom script: call DestroyTimerDialog(WINDOW)

No it's not useful at all because it is so wrong. I've made 2 easy systems that have 0 leaks and yet the best performance. Easy to implement to with a great GUI example.

Yet instead of advertsing, let me fix this crap in 2 seconds. For those of you who are way too GUI.

EDIT:

Copy this straight into the custom script section

function PolledWaitFixed takes real dur returns nothing
    local timer t
    local real timeRemain
    if dur > 0. then
        set t = CreateTimer()
        call TimerStart(t, dur, false, null)
        loop
            set timeRemain = TimerGetRemaining(t)
            exitwhen timeRemain <= 0.
            if timeRemain > bj_POLLED_WAIT_SKIP_THRESHOLD then
                call TriggerSleepAction(0.1 * timeRemain)
            else
                call TriggerSleepAction(bj_POLLED_WAIT_INTERVAL)
            endif
        endloop
        call DestroyTimer(t)
        set t = null
    endif
endfunction

function HeroRevive takes unit hero, real time returns nothing
    local unit h = hero
    local real t = time
    local real x = GetUnitX(h)
    local real y = GetUnitY(h)
    local timer tim = CreateTimer()
    local timerdialog td
    local player p = GetOwningPlayer(hero)
    call TimerStart(tim, t, false, null)
    set td = CreateTimerDialog(tim)
    if GetLocalPlayer() == p then
        call TimerDialogDisplay(td, true)
    endif
    call PolledWaitFixed(t)
    call ReviveHero(h, x, y, true)
    if GetLocalPlayer() == p then
        call PanCameraTo(x, y)
    endif
    set h = null
    call DestroyTimer(tim)
    set tim = null
    call DestroyTimerDialog(td)
    set td = null
endfunction

and then you will just need this function

• Revive Hero
  • Events
    • Unit - A unit Dies
  • Conditions
    • ((Triggering unit) is A Hero) Equal to True
  • Actions
    • Custom script: call HeroRevive(GetTriggerUnit(), 15.)

 

[Cihparg]

Well baassee, you should define the "custom script section" a little better there, perhaps create a tutorial about it? Because hardly no GUI'er knows what you mean there.

~

 

[baassee]

lol there is nothing to explain, it's the same as above except no leaks and a remaked polledwait.

I should, I should. Because I'm sick off people not using my stuff

 

[pizzaDoXx]

i appreciate your feedbacks

 

[bloodmaster-77]

can't u make a youtube vid of how to do it? o.o

 

[baassee]

I can make a tutorial lol but why make a tutorial when there are revival systems out there.

 

[bloodmaster-77]

I can make a tutorial lol but why make a tutorial when there are revival systems out there.

cause i can't anything about revival systems.....
and hero selecting systems? -.-

 

[baassee]

cause i can't anything about revival systems.....
and hero selecting systems? -.-

I guess you haven't read the instructions clearly then. Most of them got a simple yet contains tons of informations just in the documentation. Try to read that next time.

Seems that you haven't looked into the tutorial section?

 

[bloodmaster-77]

I guess you haven't read the instructions clearly then. Most of them got a simple yet contains tons of informations just in the documentation. Try to read that next time.

Seems that you haven't looked into the tutorial section?

can't i just send u my map project, so can u import the revive system? x)

 

[Magtheridon96]

Baassee, thnks for that JASS revival system. (You know, the one that you ADVERTISED)
I'm gonna implement it in my map.
CREDITS to you
+rep