KB3D - Knock back 3D

[T. D. W.]

It seems you and maker both don't get problems, wrathion and I had the same errors, malhorne do you get any?

 

[Malhorne]

Did you fix the problems I said xD ?
(Joking dude)

 

[Malhorne]

With which version shall I open this ?
And what WE ?

 

[chobibo]

Did you download the map?

 

[T. D. W.]

Not yet.. I'm studying (supposed to - don't tell my mom xD)

 

[T. D. W.]

Any version with 1.7.1+ or chobi's
And normal WE

 

[Malhorne]

Got no problem I'm on 1.26.a with chobi's version

Not yet.. I'm studying (supposed to - don't tell my mom xD)

I'm on class dude !

 

[T. D. W.]

Lol?!?

 

[T. D. W.]

Hell what!
In class and how hell did you test it !

 

[chobibo]

I'm using normal WE, maybe you misunderstood what I said, I fixed the errors on the map. I downloaded it again and opened it on WE, the loop errors popped up, then I fixed it, renamed the map fixed.w3x, then uploaded it. The errors are fixed man...

 

[T. D. W.]

okay, tested myself
chobi's one doesn't generate Errors .. what the hell?

Chobibo, can you do the same things you did with this one

 

[chobibo]

I kept telling you it was fixed...

 

[T. D. W.]

No no, this one is v. 1.8.0 beta.. I can't restart all the work WTH

 

[chobibo]

http://www.hiveworkshop.com/forums/pastebin.php?id=bay5y7

 

[T. D. W.]

okay, now that all of this is fixed........ chobi, what did the hell you do to fix the loops????

 

[chobibo]

I already told you, GroupEnums require boolexpr not code:
call GroupEnumUnitsInRange(g, x, y, KB3D_AlwaysPos(AoE), Filter(function KB3D_True))

 

[T. D. W.]

Oh, sorry i was lost between the threads ^^'

 

[chobibo]

Don't apologize, I was just saying I already did. Your heart must be pumping from all the action from your mom. XD

 

[T. D. W.]

xD, i dunno how i managed to sit on the laptop without catching her attention xD

 

[chobibo]

Good thing your mom is updating her map lol, kidding.

 

[Malhorne]

I got my pc in some class

 

[T. D. W.]

Ah, and at what time you have class? Afternoons it seems

 

[Malhorne]

Monday, Tuesday, Wenesday, Thursday (not the afternoon) and Friday.
From 8am to 5h30-6hpm in GMT+1

 

[T. D. W.]

Gosh... 3 hrs more than me xD

 

[Malhorne]

Ahah ^^

 

[chobibo]

Malhorne just stays at school to look at chemistry gurlz, gotta love them chemical vixens.

 

[Malhorne]

Malhorne just stays at school to look at chemistry gurlz

Kinda true sometimes

 

[T. D. W.]

okay, First of the monthly spell resources
First in the most downloaded spell in the month
Best KB system of all, deliberating on the features
This System is flawless xD ~~ the best

 

[Malhorne]

Ahah nice
Did you correct things I mentionned in the thread ?

 

[chobibo]

This System is flawless xD ~~ the best

I wouldn't say that dude, if it's flawless then you don't need to add anything further to it, which means no more updates are necessary, including bugfixes.

 

[T. D. W.]

In the 1.8.0 malhorne yes

@chobi, i know, but i wanted to add a third point xD

 

[chobibo]

Just say it's awesome lol xD

 

[T. D. W.]

Olay, it's awesome xD

 

[chobibo]

Olay, the skincare product? I never knew you use that stuff, swag...

 

[T. D. W.]

What?!?

 

[chobibo]

Olay!

 

[Malhorne]

Ahah nice jk

 

[T. D. W.]

hey guys, i have some exciting news... at least they seem to be for me...
the thing is.. i managed to make the KB system, destroy destructables ...
like when 'common' spells destroy trees
the KB3D is now able to destroy all 'possible' destructables >> this does not include brdges, pathing blockers, elevators...
only the things you can right click on them and order the unit to attack it

this feature is simple, but really cool when you see it in the test map:
KB3D_KillDestructables

 

[Malhorne]

Yes this can be cool for sure

 

[T. D. W.]

+ Bounce feature is 100% working
i will see what tweaks i can make now, tomorrow i'll send here the new code, and you will be able to track some wrong script..

 

[T. D. W.]

click here to see the codee
< the message what too long xD

Here is the 1.8.0 CODE, can someone see for defections in it?

 

[Malhorne]

Yop I'm gonna do it

 

[T. D. W.]

Okay

 

[Malhorne]

if IsUnitType(U, UNIT_TYPE_DEAD) then
else

Still useless xD -> Use not

        elseif not((LoadBoolean(udg_KB3D_HA, 48, Loop)) and ( IsUnitType(U, UNIT_TYPE_STRUCTURE))) then
                if not(LoadBoolean(udg_KB3D_HA, 49, Loop)) and ( IsUnitType(U, UNIT_TYPE_MECHANICAL)) then
                    return false
                endif
        endif

-> Fix indentation

        elseif not((LoadBoolean(udg_KB3D_HA, 48, Loop)) and ( IsUnitType(U, UNIT_TYPE_STRUCTURE))) then
            if not(LoadBoolean(udg_KB3D_HA, 49, Loop)) and ( IsUnitType(U, UNIT_TYPE_MECHANICAL)) then
                return false
            endif
        endif

loop
        exitwhen udg_CP_HiddenItemsIndex == 0 //Use equality :p
        set udg_CP_HiddenItemsIndex = udg_CP_HiddenItemsIndex - 1
        call SetItemVisible(udg_CP_HiddenItems[udg_CP_HiddenItemsIndex], true)
        set udg_CP_HiddenItems[udg_CP_HiddenItemsIndex] = null
    endloop

->

loop
        exitwhen udg_CP_HiddenItemsIndex <= 0
        set udg_CP_HiddenItemsIndex = udg_CP_HiddenItemsIndex - 1
        call SetItemVisible(udg_CP_HiddenItems[udg_CP_HiddenItemsIndex], true)
        set udg_CP_HiddenItems[udg_CP_HiddenItemsIndex] = null
    endloop

if KB3D_CW(x,y) then
else
    return 1
endif

->

if not KB3D_CW(x,y) then
    return 1
endif

function KB3D_Bounce takes unit U, real x, real y, integer Loop returns boolean
    local group g
    local unit u
    local real Angle
    local real S
    local real R
    //---------------------------
    if KB3D_BounceDetection(U,x,y) == 0 then
        return false
    endif
    //---------------------------
    if KB3D_BounceDetection(U,x,y) == 1 and LoadBoolean(udg_KB3D_HA, 60, Loop) then
        set Angle = LoadReal(udg_KB3D_HA, 5, Loop)*57.29578 + GetRandomReal(-15,15) + 180
        set S = LoadReal(udg_KB3D_HA, 2, Loop)
        set S = S*.8
        set R = 1.5*S/.03125
        call KB3D_Add_Bounce(U, Angle, S, R, true, Loop)
        return true
    endif
    
    //---------------------------
    set g = CreateGroup()
    call GroupEnumUnitsInRange(g, x, y, KB3D_InBetween(100,KB3D_GetUnitCollision(U)*2.5,999), null)
    if KB3D_BounceDetection(U,x,y) == 2 and KB3D_FilterLoop(g, Loop) != null then
        set u = KB3D_FilterLoop(g, Loop)
        set Angle = (Atan2(GetUnitY(u) - GetUnitY(U), GetUnitX(u) - GetUnitX(U)) *57.29578) + GetRandomReal(-15,15) + 180
        set S = LoadReal(udg_KB3D_HA, 2, Loop)
        set S = S*.8
        set R = 1.5*S/.03125
        if LoadBoolean(udg_KB3D_HA, 60, Loop) then
            call KB3D_Add_Bounce(U, Angle, S, R, true, Loop)
        endif
        set Angle = Angle -180
        if LoadBoolean(udg_KB3D_HA, 61, Loop) then
            call KB3D_Add_Bounce(u, Angle, S, R, false, Loop)
        endif
        set u = null
        return true
    endif
    //---------------------------
    return false
endfunction

You never destroy the group nor nulling it.

            else
            call SaveBoolean(udg_KB3D_HA, 52, Loop, false)
            endif

-> Fix indentation

            else
                call SaveBoolean(udg_KB3D_HA, 52, Loop, false)
            endif

    if not (LoopD == 0) and not (Damager == null ) then
        call UnitDamageTarget(Damager, U, LoopD, true, false, AType, DType, WEAPON_TYPE_WHOKNOWS)
    endif

->

    if (LoopD != 0) and (Damager != null ) then
        call UnitDamageTarget(Damager, U, LoopD, true, false, AType, DType, WEAPON_TYPE_WHOKNOWS)
    endif

    if not (Fx == "") then
        if ( z > 20 ) then
            if not (Attach == "") then
                call DestroyEffect(AddSpecialEffectTarget(Fx, U, Attach))//attach the effect on the unit if he is flying
            endif
        else
            call DestroyEffect(AddSpecialEffect(Fx, x, y))//create the effect on his location if he is not flying
        endif
    endif

->

    if (Fx != "") then
        if ( z > 20 ) then
            if (Attach != "") then
                call DestroyEffect(AddSpecialEffectTarget(Fx, U, Attach))//attach the effect on the unit if he is flying
            endif
        else
            call DestroyEffect(AddSpecialEffect(Fx, x, y))//create the effect on his location if he is not flying
        endif
    endif

-> There is many things like this -> Prefer != to not for readability.


set B = ( not(StopTime == 0) and ( Time > StopTime ) )
->
set B = ( StopTime != 0 and Time > StopTime )


Okay so I didn't rewrite every one of your not to [/icode]!=[/icode]

 

[T. D. W.]

Okay, then the version will be released by the afternoon
"i did fix some of those you just pointed xD" like the group thing
oh and the else thing instead of not is an efficiency stuff noticed by bowser ^^' so since it does the same.. w/e

 

[Malhorne]

The not thing don't do it ....
It killed the readability for 10^(-5 or -6) each time ...

 

[T. D. W.]

:/
I'll see if i am not too lazy xD

 

[Malhorne]

Ok....

 

[chobibo]

OMG, text wall! haha xD
How fast is not compared to !=?

 

[T. D. W.]

fixed everything, and i think all of the "not s" are fixed (just that the code is huge.. so i'm not 100% certain)
Now, i'm making an all new description and preview image .. and'we're up