KB3D - Knock back 3D

[T. D. W.]

Hello Helpers!

Go check out our KB3D System:

KNOCK-BACK 3D

Some Noticed things in the System:

The System has 180+ comments! within just 12 days!!
the system has 4 5/5 votes by users
and a 5/5 Moderation vote

 

[IcemanBo]

Cant participate, I only use GUI.

 

[T. D. W.]

The System MUST be in JASS, i want to hit the most users possible with this, making it in vJASS makes too much users unable to use it
Chobibo, what do you mean by wrong calculations?
Z isn't yet here because i have that problem i said in the first post
No problem IcemanBo
and hell, i subscribed to this thread why didn't i have an email notif?!!?
Attached the triggers in first post

 

[T. D. W.]

Ok, i will change those 2, but i doubt this will fix the current problem :/

 

[Malhorne]

Why don't we use vJASS XD ?
Making a Knockback library ?
I'll not be able to create one at all right now since i'm totally exhausted (feat. student party xD)

 

[T. D. W.]

I told chobibo the reason: i want the system to be affecting the most users possible
yes a 3D Knockback system
and so bored i hate school

BTW: I found the bug that makes the instances go wrong, but still wondering why the hell the system kncockbacks one unit at a time!

 

[Malhorne]

May I be boring on a few things xD ?
Try to avoid triggeraddaction as possible.
You can use local trigger variable instead of the global "gg_trg____" since it will take less place.

 

[T. D. W.]

no not u, school is boringly boring
and i use a udg_ variable not a gg_trg_ nor a local one because a local one won't be able to be used outside it, the triggers need to be turned on/off

 

[T. D. W.]

ok, done

 

[Malhorne]

The first trigger should to be turn on/off ?
Anyway you can use triggeraddcondition instead of triggeraddaction
If i'm saying random things don't pay attention i'm totally dead ^^

 

[T. D. W.]

Oh i see it now, thx for the help ^^"
XD

 

[T. D. W.]

UPDATED, now includes the Z offset implementation

But the One knockback / instance BUG is still there

 

[T. D. W.]

Yes the map and scripts are updated here

 

[Rheiko]

from what i seen, you are using hashtable
why don't you use trigger and custom script instead of jass? because i can't use or read jass

 

[chobibo]

Leaks:

    call RemoveLocation(L)
    call RemoveLocation(L1)
    call RemoveLocation(L2)

fix:

    call RemoveLocation(L)
    call RemoveLocation(L1)
    call RemoveLocation(L2)
    set L=null
    set L1=null
    set L2=null

 

[T. D. W.]

Remember when maker told jakezinc to do the whole spell in jass because most of the code was Custom scripts?
That's the case, + i use lots and lots of locals


Chobibo, fixed

 

[T. D. W.]

I'm used to gui (i mean when i create fxs in gui i directly scroll a little and add destroy last fx... So i forgot to destroy it here :/

Edit: here it is now:

if ( z > 0 ) then
        call DestroyEffect(AddSpecialEffectTarget(Fx, U, Attach))
    else
        call DestroyEffect(AddSpecialEffect(Fx, x, y))
    endif

 

[T. D. W.]

I'll fix what you just told me,
The problem, yh, i just figured almost out the exact source of it, if like 2-5 units are knockbacked at the same time, no problem, but if more (when i order some of my units to attack the blue ones, = many instances, the problem starts and it starts to knockback 1 at a time)

second possible source: if the same unit has 2 or more instances running on him
like he was attacked 2 times at once

 

[T. D. W.]

Wow, this system is cursed, within the last 3 tests, the instancing was correct even with lots of units, but lagged with more than 300 instances xD
anw, for the radians, i think you missed one thing:

if ( Target == null ) then
        set Angle = LoadReal(udg_KB3D_HA, 5, Loop)

shouldn't it be changed?
and secondly, if i added a unit target, so we will use this one:

set Angle = Atan2(Y - GetUnitY(Target), X - GetUnitX(Target))

this makes the unit move like 180 degrees wrong, meaning that he should move toward the attacking unit, he moves backward..... if you got my idea

 

[Rheiko]

i see, okay then
good luck

 

[T. D. W.]

i see, okay then
good luck

thanks, i think we're close to the finish

 

[T. D. W.]

and for this?

set Angle = LoadReal(udg_KB3D_HA, 5, Loop)

 

[chobibo]

function KB3D_Registration_Actions takes nothing returns nothing
    set udg_KB3D_Counter = udg_KB3D_Counter + 1
    set udg_KB3D_Instances = udg_KB3D_Instances + 1
    set udg_KB3D_Zoffset = 2 * udg_KB3D_Zoffset
    call SaveUnitHandle( udg_KB3D_HA, 0, udg_KB3D_Counter, udg_KB3D_Unit )
    call SaveReal( udg_KB3D_HA, 1, udg_KB3D_Counter, udg_KB3D_Range )
    call SaveReal( udg_KB3D_HA, 2, udg_KB3D_Counter, udg_KB3D_Speed )
    call SaveReal( udg_KB3D_HA, 3, udg_KB3D_Counter, udg_KB3D_Zoffset )
    call SaveReal( udg_KB3D_HA, 4, udg_KB3D_Counter, udg_KB3D_Accel )
    if ( udg_KB3D_Targeted_Unit == null ) then
        call SaveReal( udg_KB3D_HA, 5, udg_KB3D_Counter, udg_KB3D_Angle*bj_DEGTORAD )
    else
        call SaveUnitHandle( udg_KB3D_HA, 5, udg_KB3D_Counter, udg_KB3D_Targeted_Unit )
    endif
    call SaveBoolean( udg_KB3D_HA, 6, udg_KB3D_Counter, udg_KB3D_DisableUnit )
    call SaveBoolean( udg_KB3D_HA, 7, udg_KB3D_Counter, udg_KB3D_UnpathableStop )
    call SaveBoolean( udg_KB3D_HA, 8, udg_KB3D_Counter, udg_KB3D_DestroyTree )
    call SaveStr( udg_KB3D_HA, 9, udg_KB3D_Counter, udg_KB3D_Fx )
    call SaveStr( udg_KB3D_HA, 10, udg_KB3D_Counter, udg_KB3D_Fx_Attach )
    call SaveReal( udg_KB3D_HA, 11, udg_KB3D_Counter, -1 * udg_KB3D_Speed / udg_KB3D_Accel )
    call SaveReal( udg_KB3D_HA, 12, udg_KB3D_Counter, udg_KB3D_Zoffset / (-1 * udg_KB3D_Speed / udg_KB3D_Accel / 2) )
    call SaveReal( udg_KB3D_HA, 13, udg_KB3D_Counter, ( -1 * udg_KB3D_Zoffset / (-1 * udg_KB3D_Speed / udg_KB3D_Accel / 2) ) / (-1 * udg_KB3D_Speed / udg_KB3D_Accel / 2) )
    call SaveBoolean( udg_KB3D_HA, 15, udg_KB3D_Counter, true )
    if UnitAddAbility(udg_KB3D_Unit, 'Amrf') then
        call UnitRemoveAbility(udg_KB3D_Unit, 'Amrf')
    endif
    if ( udg_KB3D_Counter == 1 ) then
        call EnableTrigger(udg_KB3D_Loop)
    endif
    //Nulling
    set udg_KB3D_Accel = 0.00
    set udg_KB3D_Angle = 0.00
    set udg_KB3D_DestroyTree = false
    set udg_KB3D_DisableUnit = false
    set udg_KB3D_Fx = ""
    set udg_KB3D_Fx_Attach = ""
    set udg_KB3D_Range = 0.00
    set udg_KB3D_Speed = 0.00
    set udg_KB3D_Targeted_Unit = null
    set udg_KB3D_Unit = null
    set udg_KB3D_UnpathableStop = false
    set udg_KB3D_Zoffset = 0.00
endfunction

EDIT: wouldn't be sensible to make it hog processing time, it shouldn't be in the periodic function, it should be on the registration function.

 

[T. D. W.]

Ok, chobibo, left one thing now, LAG
I'll update in a minute the first post, with the new triggers and the new testmap
what do you have to do?
do whatever is possible for assassinating this fu**ing lag

 

[chobibo]

I'm having a hard time figuring out what your saving on the hashtables Jad, could you help me by making a detailed list of what the saved data are?

i.e.:
udg_KB3D_Unit - this one is the unit knocked back if there is no target.
udg_KB3D_Targeted_Unit - this one is the omg I dunno?

like that lol, I'm confused.

 

[T. D. W.]

Explanations are in the example trigger..
And then trace where the functions go

 

[chobibo]

So what is the relationship between the target_unit and the unit? I don't get it. I also don't know what 11 to 15 are. I'll skip them temporarily then.

 

[T. D. W.]

unit is the knockbacked unit
targeted_unit is (if not null) the direction where the Kbed unit goes, meaning it is like he follows the unit, try setting this to attacking unit for example, the kbed unit will then go to the attacking unit's location
11>13 are basically not fixed yet, they work, but i will enhance them afterwards, but just to tell you what they are:
11>>time taken to finish the knockback
12>>speed of Z changing (AKA 'rate')
13>>Acceleration of Z changing speed >> you can see them in the loop where they are named
14>>empty space if required
15>> if the specific instance is finished = false, if not = true

 

[chobibo]

Ah! so when a target unit is set, the kbed unit acts like a projectile right?

 

[T. D. W.]

yes!

 

[T. D. W.]

that's why i told first that this spell can be used in each and every spell possible (like 90% of spells can use it)
even missile projectile spells can use it

 

[Malhorne]

Is the first post at last update ?
I'm gonna check it right now since i slept (long sleep xD)

 

[T. D. W.]

It is updated, lol i took time for me to understand what you meant xD

 

[Malhorne]

Ahah no problem ^^'
I got a bunch of time before eating now so i'll see it.
What are the known bugs that we should correct ?

 

[T. D. W.]

Currently, it's a lag with over 300 instances or 200

 

[Malhorne]

set udg_KB3D_HA = InitHashtableBJ()
Use
set udg_KB3D_HA = InitHastable()

Why don't use triggeraddcondition for the reg trigger ? It is still better than using triggeraddaction.

call TriggerRegisterTimerEvent( udg_KB3D_Loop, 0.03125, TRUE )
TRUE refers to true so just write this :
call TriggerRegisterTimerEvent( udg_KB3D_Loop, 0.03125, true )

There is also a non-indented loop but that's only verbose x)

 

[Rheiko]

i thought BJ is bad?

 

[Malhorne]

BJ is often bad that's why i told to use InitHashtable and not InitHashtableBJ
I'm going to eat right now.

 

[T. D. W.]

For the hashtable, it's a forgot to do
Are you serious with this condition/action thing?
K, changed to true
and for he final line: english plz

 

[Rheiko]

@Malhorne
okay

@Jad
verbose? it's english

 

[T. D. W.]

What does it mean xD (the whole sentence)

 

[chobibo]

minor error.

 

[Malhorne]

Yeah I wanted to say that's only matter of text and not of coding
I'm serious for the condition/action
That's why i'm trying to avoid action

 

[chobibo]

Good thing malhorne's here, he can help us get rid of the lag!

 

[Malhorne]

Ahah ^^
I'll try to help
So the problem is when there is a (large ?) number of instances it starts to lag ?

if ( LoadBoolean(udg_KB3D_HA, 15, x) == true ) then
->
if ( LoadBoolean(udg_KB3D_HA, 15, x) ) then

call EnumItemsInRectBJ( udg_CP_Rect, function KB3D_CW_Loop )
->
call EnumItemsInRect(udg_CP_Rect, null, function KB3D_CW_Loop )

There is a trick to get the z offset of a unit.
You can add a location at the position of the unit and then use the formula : GetUnitFLyHeight(u) + GetLocationZ(L)

if ( (UnpathableStop == false) or ( KB3D_CW(x, y) == true ) ) then
->
if ( not(UnpathableStop) or KB3D_CW(x, y) ) then

if ( DisableUnit == true ) then
-> Oh by the way this condition got nothing if it is true so just do the complementary version and delete the else.
if DisableUnit then

( GetUnitState(U, UNIT_STATE_LIFE) <= 0 )
->
( GetWidgetLife(U) <= 0 )

 

[Rheiko]

detailed, lengthy, prolix, ample, redundant, verbose, wordy, long-winded

 

[Malhorne]

Ok guys i'll be off for sometimes since i have to go somewhere then work a bit then WHOKNOWS XD!
Anyway i think i pointed out all the coding mistakes and i'll see about the algorithm later.

Be sure to check the conditon where there is nothing after the if and instanly an else

 

[T. D. W.]

Sorry for the late reply...
Any way malhorne, thanks for poiting all those out
Chobibo, what did you come up with ?
Btw, in the version i am working on, i merged the 2 triggers into 1 and added credits to you 2 for helping in the triggers

 

[chobibo]

I tried using arrays to replace the hashtable use, but it's still not done.

 

[T. D. W.]

Okay, notify it when you're done