Hero Wound Sounds

[Vidar]

An excellent choice of image!

 

[Wrda]

You could use EVENT_PLAYER_UNIT_DAMAGED since it combined with the AnyUnitBJ would result in just 1 trigger for all units registered. This is easier to do in Lua as if not woundSound[u] then would then mean unit isn't registered at all, then skip. Due to fact that the system doesn't clean the removal of units from the hashtable/table when they don't exist anymore, it would a good idea to put a note that it requires manual removal (wound sounds can also be applied to non-hero units). You should upload another map, with the lua version code in it, it's faster to test, and even copy (if the map contained libraries).
Otherwise, this is pretty nice.

Approved

 

[Pyrogasm]

Aren't raw Do...Ends bad because of garbage recycle in Lua?
(I don't much Lua.)

 

[Wrda]

That's the case with blizzard.j transpiled Lua. bj_lastStartedTimer used in StartTimerBJ desyncs. So using GUI and starting timers, you go poof.

Only most critical thing not to do inside of lua root (whether inside of do ... end or not) is to never create wc3 objects at this point, since most Wc3 functions arent' available. FourCC is one of the few.
If you do create objects like that, Wc3 invites you to take a swim to the deep down ocean of the game main menu.

 

[Antares]

You could use EVENT_PLAYER_UNIT_DAMAGED since it combined with the AnyUnitBJ would result in just 1 trigger for all units registered. This is easier to do in Lua as if not woundSound[u] then would then mean unit isn't registered at all, then skip. Due to fact that the system doesn't clean the removal of units from the hashtable/table when they don't exist anymore, it would a good idea to put a note that it requires manual removal (wound sounds can also be applied to non-hero units). You should upload another map, with the lua version code in it, it's faster to test, and even copy (if the map contained libraries).
Otherwise, this is pretty nice.

Approved

I uploaded a Lua test map and renamed the functions from DoXToHero to DoXToUnit, to show that the unit doesn't necessarily have to be a hero. I added an option to automatically clear leaks on a nonhero unit's death. I still think it's better to have a trigger for each unit separately, because if it's going to be used on nonhero units, it's probably only going to be a few, and having a specific trigger for those units prevents it from firing on every damage event, which I assume must be more of a performance concern than a few memory leaks here and there.

Thanks for the review!