Movement Spell Pack V1

[Moderator]

http://www.hiveworkshop.com/forums/spells-569/identify-system-1-00-a-183934/?prev=r%3D20%26status%3Dr2%26page%3D4113:12, 4th Mar 2011
Bribe:

Post the triggers. I don't blindly download maps.

Status: Rejected until updated

 

[Titania]

What is semi-MUI?

 

[Darkzealot_128]

Use trigger tags, gonna check.

Edit: It's only GUI, not UMSWE GUI, it's too simple, and you don't even know what MUI is.

 

[Adiktuz]

Since when is there a SEMI-MUI?

and please use JASS tags...

 

[Maker]

Triggers

• Casting
  • Events
    • Unit - A unit Begins casting an ability
  • Conditions
  • Actions
    • -------- Set Spell --------
    • Set Pull_Spell = |cffffd700P|rull
    • -------- Set Buff --------
    • Set Pull_Buff = Pull
    • -------- Set Caster and Target of the spell. --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Ability being cast) Equal to Pull_Spell
      • Then - Actions
        • Set Caster_Of_Pull[(Player number of (Triggering player))] = (Casting unit)
        • Set Target_Of_Pull[(Player number of (Triggering player))] = (Target unit of ability being cast)
      • Else - Actions

• Pulling
  • Events
    • Time - Every 0.02 seconds of game time
  • Conditions
  • Actions
    • Player Group - Pick every player in (All players) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Or - Any (Conditions) are true
              • Conditions
                • (Target_Of_Pull[(Player number of (Picked player))] has buff Pull_Buff) Equal to True
          • Then - Actions
            • Unit - Move Target_Of_Pull[(Player number of (Picked player))] instantly to ((Position of Target_Of_Pull[(Player number of (Picked player))]) offset by ((Distance between (Position of Caster_Of_Pull[(Player number of (Picked player))]) and (Position of Target_Of_Pull[(Player number of (Picked player))])) / (100.00 x -1.00)) towards (
          • Else - Actions

The "begins casting..." needs to have the ability as a condition.
You could use "starts" the effect" instead of "begins casting".
Don't set the ability and buff to a variable every time you cast the spell.
The spell is not MUI, it's MPI. Spells should be MUI.
You leak locations.
The loop trigger is always on.
The ability doesn't support levels.
The tooltip is bad.
Instead of "pick all players", pick all units in unit group. Add units to the unit group in the casting trigger.
The spell is very simple.

Fix those.

 

[Bribe]

Post the triggers.