Would this cause a desync?

[Rugarus]

  if (IsSlayer(uD)) {
    DisplayTimedTextToPlayer(GetLocalPlayer(), 0, 0, 10, GetPlayerNameColored(Player(pD)) + "'s " + GetUnitName(uD) + " has fallen");
    StartSound(gg_snd_HPitLordWhat1);
  }

We we're playing the game and right when one of the player's Hero died which triggers the above code, he desyncd.

If so is it the sound or the text message that would cause it?

Let me know if you want me to paste the whole code.

 

[MyPad]

If isSlayer has even one GetLocalPlayer call, it will desync.

As it is, I don't see any possibility of desyncs in the code. If you say otherwise, I defer to the former statement above.

 

[Rugarus]

If isSlayer has even one GetLocalPlayer call, it will desync.

As it is, I don't see any possibility of desyncs in the code. If you say otherwise, I defer to the former statement above.

But the message is displaying to the local player, you say that if it is local player it will desync?


This is the isslayer function

public function IsSlayer(unit u) -> boolean {
    return IsSlayerId(GetUnitTypeId(u));
}

This is the main function that happens on death

private function OnDeath() -> boolean {
  unit u;
  unit uD = GetDyingUnit();
  unit uK = GetKillingUnit();
  integer uDId = GetUnitTypeId(uD);
  integer uKId = GetUnitTypeId(uK);
  integer pD = GetPlayerId(GetOwningPlayer(uD));
  integer pK = GetPlayerId(GetOwningPlayer(uK));

  UpdateOnDeath(uD, uK);

  if (IsSlayer(uD)) {
    DisplayTimedTextToPlayer(GetLocalPlayer(), 0, 0, 10, GetPlayerNameColored(Player(pD)) + "'s " + GetUnitName(uD) + " has fallen");
    StartSound(gg_snd_HPitLordWhat1);
  }

 

[MyPad]

Try exposing the IsSlayerId function and UpdateOnDeath.

EDIT:

If isSlayer has even one GetLocalPlayer call, it will desync.

I am pertaining to the isSlayer function, due to the possibility of it returning a different value for each player.

Displaying in-game text messages with GetLocalPlayer would not desync at all as long as all the clients have the same string table.