[Trigger] Whats wrong with the MUI aspect of this trigger

[Goldbach]

The spell works well, but its not completely MUI, actually the first half ( creating the dummy units at castloc offset -- facing -- degrees ) is MUI, but the second isnt ( both instances ( even if casted some time apart ) finish in the same time ) .


[TRIGGER=text]SF
Events
Unit - A unit Starts the effect of an ability
Conditions
(Ability being cast) Equal to Spell of Fire
Actions
Set SF_caster = (Triggering unit)
Set SF_counter = 30
Hashtable - Save Handle OfSF_caster as 0 of (Key (Triggering unit)) in SF_hash
Hashtable - Save SF_counter as 1 of (Key (Triggering unit)) in SF_hash
Hashtable - Save Handle OfSF_Pgroup as 3 of (Key (Triggering unit)) in SF_hash
Animation - Play SF_caster's Spell Channel animation
For each (Integer A) from 1 to 4, do (Actions)
Loop - Actions
Set SF_PLoc = ((Position of SF_caster) offset by 600.00 towards (360.00 - ((Real((Integer A))) x 90.00)) degrees)
Unit - Create 1 Burning Energy (Level 3) for (Owner of SF_caster) at SF_PLoc facing (Position of SF_caster)
Set SF_Pillar[(Integer A)] = (Last created unit)
Unit - Add a 29.00 second Generic expiration timer to SF_Pillar[(Integer A)]
Unit Group - Add SF_Pillar[(Integer A)] to SF_Pgroup
Unit Group - Add SF_caster to SF_castergroup
Trigger - Turn on SFLoop <gen>[/TRIGGER]


[TRIGGER=text]SFLoop
Events
Time - Every 1.00 seconds of game time
Conditions
Actions
Unit Group - Pick every unit in SF_castergroup and do (Actions)
Loop - Actions
Set SF_counter = (Load 1 of (Key (Picked unit)) from SF_hash)
Set SF_Pgroup = (Load 3 of (Key (Picked unit)) in SF_hash)
Unit Group - Pick every unit in SF_Pgroup and do (Actions)
Loop - Actions
Unit - Order (Picked unit) to Human Blood Mage - Flame Strike ((Position of (Picked unit)) offset by (Random real number between 100.00 and 300.00) towards (Random angle) degrees)
Hashtable - Save (SF_counter - 1) as 1 of (Key (Picked unit)) in SF_hash
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
SF_counter Equal to 0
Then - Actions
Hashtable - Clear all child hashtables of child (Key (Picked unit)) in SF_hash
Unit Group - Remove SF_caster from SF_castergroup
Trigger - Turn off (This trigger)
Else - Actions[/TRIGGER]


[TRIGGER=text]SFDisable
Events
Unit - A unit Stops casting an ability
Conditions
(Ability being cast) Equal to Spell of Fire
Actions
Set SF_caster = (Triggering unit)
Set SF_Pgroup = (Load 3 of (Key (Triggering unit)) in SF_hash)
Unit Group - Pick every unit in SF_Pgroup and do (Actions)
Loop - Actions
Unit - Remove (Picked unit) from the game
Unit Group - Remove SF_caster from SF_castergroup
Hashtable - Clear all child hashtables of child (Key (Triggering unit)) in SF_hash
Trigger - Turn off SFLoop <gen>[/TRIGGER]

 

[Almia]

The if-block in the loop is outside the pick unit group
Also,keys should be cached.
Example:
set mykey = GetHandleId(myunit)
key is an integer
also you have 4 memory leaks(locations leaks)
what is the counter for?

 

[Goldbach]

Putting the if-part inside didnt solve it.

Also,keys should be cached.

Ok, but doesnt this happen when saving a variable to the key of e.g. Triggering unit inside the hashtable already ? I dont understand it quite right then. What do I use the key for ?
I thought the counter was necessary to remove the caster from castergroup after 30 seconds ( or if the casting was interrupted - disable trigger ) ....also if the casting is interrupted by casting another spell, the disabling trigger doesnt work. I suppose that doesnt count as stops casting an abillity. But how else should I solve that ?
Yes, Im aware of the leaks, I just wanted to finish the main process of the spell.

 

[Almia]

cacheing makes the interpreting faster

 

[Goldbach]

Anyway, I dont think any of those suggestions are aimed at/solve the defect MUI aspect. Anyone got an idea of how to fix that ?

 

[Maker]

// No need to do the following line at all. Delete it.

• Hashtable - Save Handle OfSF_caster as 0 of (Key (Triggering unit)) in SF_hash

// Instead of

• Hashtable - Save Handle OfSF_Pgroup as 3 of (Key (Triggering unit)) in SF_hash

->

• Custom script: set udg_SF_Pgroup = CreateGroup()
• Hashtable - Save Handle OfSF_Pgroup as 3 of (Key (Triggering unit)) in SF_hash

// The following line leaks Position of SF_caster, and you don't remove SF_PLoc

• Set SF_PLoc = ((Position of SF_caster) offset by 600.00 towards (360.00 - ((Real((Integer A))) x 90.00)) degrees)

// Leaks two locations:

• Unit - Order (Picked unit) to Human Blood Mage - Flame Strike ((Position of (Picked unit)) offset by...

// This should be inside "Unit Group - Pick every unit in SF_castergroup and do (Actions)"

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • SF_counter Equal to 0

// You should have "if SF_castergroup is empty then" if/then/else thingy here:

• Trigger - Turn off (This trigger)

In SFDisable you also need if/then/else to turn off the loop and remember to destroy the group that was created and stored in the first trigger.

 

[Goldbach]

the spell works, thanx