[JASS] What's wrong here?

[naitsirk]

scope HolyExpl initializer Init
//-----------------Setup Start--------------------------
    globals
        private constant integer SPELL_ID = 'A000'


    endglobals
    
    private function Damage takes integer level returns real
        return level * 50.
    endfunction
    
    private function heal takes integer level returns real
        return level * 25.
    endfunction
    
    private function Loopdam takes integer level returns real
        return level * 35.
    endfunction
//-----------------Setup End----------------------------
    globals
        private boolexpr b
    endglobals

private function c takes nothing returns boolean
    return GetSpellAbilityId() == SPELL_ID
endfunction

private function Pick takes nothing returns boolean
    return Target(GetFilterUnit())

private function a takes nothing returns nothing
    local unit caster = GetTriggerUnit()
    local integer loopsec = 0
    local integer level = GetUnitAbilityLevel(caster, SPELL_ID)
    local location one = GetUnitLoc(caster)
    local location two = GetRandomLocInRect(RectFromCenterSizeBJ(one, 500.,500.))
    local location effectLoc = OffsetLocation(two,-50.00, 50.00)
    local location effectLoc2 = OffsetLocation(two,50.00,-50.00)
    local location effectLoc3 = OffsetLocation(two,50.00,50.00)
    local location effectLoc4 = OffsetLocation(two,-50.00,-50.00)
    local location three
    local unit target
    call DestroyEffect(AddSpecialEffectLoc("Abilities\\Spells\\Human\\HolyBolt\\HolyBoltSpecialArt.mdl", two))
    call DestroyEffect(AddSpecialEffectLoc("Abilities\\Spells\\Human\\HolyBolt\\HolyBoltSpecialArt.mdl", effectLoc))
    call DestroyEffect(AddSpecialEffectLoc("Abilities\\Spells\\Human\\HolyBolt\\HolyBoltSpecialArt.mdl", effectLoc2))
    call DestroyEffect(AddSpecialEffectLoc("Abilities\\Spells\\Human\\HolyBolt\\HolyBoltSpecialArt.mdl", effectLoc3))
    call DestroyEffect(AddSpecialEffectLoc("Abilities\\Spells\\Human\\HolyBolt\\HolyBoltSpecialArt.mdl", effectLoc4))
    
    call GroupEnumUnitsInRangeOfLoc(groups, two, 200., b)
    set target = FirstOfGroup(groups)
    if IsUnitEnemy(target, GetOwningPlayer(caster)) then
        call UnitDamageTarget( caster, target, Damage(level), true, false, ATTACK_TYPE_MAGIC, DAMAGE_TYPE_NORMAL) 
    endif
    loop
        set three = GetRandomLocInRect(RectFromCenterSizeBJ(one, 500., 500.))
        exitwhen loopsec == 10
        call PolledWait(0.15)
        call DestroyEffect(AddSpecialEffectLoc("Abilities\\Spells\\Human\\Resurrect\\ResurrectTarget.mdl",three))
        set loopsec = loopsec + 1
        call RemoveLocation(three)
    endloop
    set loopsec = 0
    call RemoveLocation(two)
    call RemoveLocation(one)
    call RemoveLocation(effectLoc)
    call RemoveLocation(effectLoc2)
    call RemoveLocation(effectLoc3)
    call RemoveLocation(effectLoc4)
endfunction


private function Init takes nothing returns nothing
    local trigger Holy = CreateTrigger()

    call TriggerRegisterAnyUnitEventBJ(Holy, EVENT_PLAYER_UNIT_SPELL_EFFECT)
    call TriggerAddAction(Holy, function a)
    call TriggerAddCondition(Holy, Condition(function c))
    
    set b = Condition(function Pick)
    
    
    
    
endfunction
endscope

I get an error when trying to save this... The Takes nothing seems to be unexpected or something.... Anyone knows why this is happening?

(ohh.. and if you find a way to make the special effects with just 2 or 1 variable please tell me...)

 

[Cheezeman]

Please post the entire code, I'm missing your scope and globals.

 

[naitsirk]

Please post the entire code, I'm missing your scope and globals.

will do then:;P

 

[Komaqtion]

You're missing an "endfunction" here:

private function Pick takes nothing returns boolean
    return Target(GetFilterUnit())

 

[naitsirk]

ehmm... I am not too sure how to make it Pick the Units its supose to damage... in the loop that is... it's supose to Heal friendly units and damage enemies... so i am not too sure how to set the variable...

 

[Yixx]

Gosh, you are using JASS, but still stuck to locations? Learn about coordinates!

 

[naitsirk]

Gosh, you are using JASS, but still stuck to locations? Learn about coordinates!

I'm trying... just cant seem to find any turts about the most things!!!!

 

[Cheezeman]

You don't have an endfunction for private function Pick

Edit: Lol I didn't see someone else found that.

 

[naitsirk]

You don't have an endfunction for private function Pick

Edit: Lol I didn't see someone else found that.

can you anything about coordinates? if so... would you mind telling me?

 

[TriggerHappy]

Locations are a group of coordinates.

Now tell me, which do you think is easier, locations or coordinates.

local unit u = GetTriggerUnit()
local location l = GetUnitLoc()
call AddSpecialEffectLoc("", l)
call RemoveLocation(l)
set l = null
set u = null

or..

local unit u = GetTriggerUnit()
call AddSpecialEffect("", GetUnitX(u), GetUnitY(u))
set u = null

 

[naitsirk]

Locations are a group of coordinates.

Now tell me, which do you think is easier, locations or coordinates.

local unit u = GetTriggerUnit()
local location l = GetUnitLoc()
call AddSpecialEffectLoc("", l)
call RemoveLocation(l)
set l = null
set u = null

or..

local unit u = GetTriggerUnit()
call AddSpecialEffect("", GetUnitX(u), GetUnitY(u))
set u = null

The Second one But both leaks...

DestroyEffect(AddSpecialEffect("", GetUnitX(u), GetUnitY(u))

 

[TriggerHappy]

It was just an example. I wrote it in the quick reply box.

 

[naitsirk]

It was just an example. I wrote it in the quick reply box.

ah... never mind then... probelly should stop saying this stuff... Well... Ty for atleast explaining Coordinates...