[Trigger] Unit Group - Fail?

[TheWhiteWolf]

The trigger works, except for the part where it should filter out the units that have already been hit...

Trigger

• Attack StrikeLoop
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • For each (Integer A) from 1 to 4, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Remaining time for Attack_StrikeTimer[(Integer A)]) Greater than 0.00
            • Attack[(Integer A)] Equal to True
            • Or - Any (Conditions) are true
              • Conditions
                • Player_WeaponOption[(Integer A)] Equal to 0
                • Player_WeaponOption[(Integer A)] Equal to 1
          • Then - Actions
            • Set Blank_Point[0] = (Position of Player[(Integer A)])
            • Set Blank_Point[1] = (Blank_Point[0] offset by 3.50 towards (Facing of Player[(Integer A)]) degrees)
            • Custom script: call SetUnitX(udg_Player[bj_forLoopAIndex], (GetLocationX(udg_Blank_Point[1])))
            • Custom script: call SetUnitY(udg_Player[bj_forLoopAIndex], (GetLocationY(udg_Blank_Point[1])))
            • Set Blank_Point[2] = (Blank_Point[0] offset by 80.00 towards (Facing of Player[(Integer A)]) degrees)
            • Set Attack_Group = (Units within 80.00 of Blank_Point[2] matching ((((Matching unit) belongs to an enemy of (Player((Integer A)))) Equal to True) and (0.00 Greater than or equal to 0.00)))
            • Unit Group - Pick every unit in Attack_Group and do (Actions)
              • Loop - Actions
                • Set TempUnit = (Picked unit)
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • (TempUnit is in Attack_HitGroup[(Integer A)]) Equal to False
                  • Then - Actions
                    • Unit - Cause Player[(Integer A)] to damage TempUnit, dealing (Weapon_Damage[(Integer A)] x (1.00 + ((Real(Player_StatsConstitution[(Integer A)])) / 100.00))) damage of attack type Normal and damage type Normal
                    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                      • If - Conditions
                        • (Number of units in Attack_HitGroup[(Integer A)]) Equal to 0
                      • Then - Actions
                        • Set Attack_HitGroup[(Integer A)] = (Units owned by Player 1 (Red))
                        • Unit Group - Remove all units from Attack_HitGroup[(Integer A)]
                        • Unit Group - Add TempUnit to Attack_HitGroup[(Integer A)]
                      • Else - Actions
                        • Unit Group - Add TempUnit to Attack_HitGroup[(Integer A)]
                  • Else - Actions
            • Custom script: call DestroyGroup(udg_Attack_Group)
            • Custom script: call RemoveLocation(udg_Blank_Point[0])
            • Custom script: call RemoveLocation(udg_Blank_Point[1])
            • Custom script: call RemoveLocation(udg_Blank_Point[2])
          • Else - Actions

Any ideas?

 

[GywGod133]

i dont understant what do you want to show this.. sorry for that

 

[TheWhiteWolf]

Because a part of the trigger doesn't work, and I need someone to fix it for me?

 

[Razer!X]

Don't use Integer A. Use an integer variable instead.

 

[GywGod133]

Because a part of the trigger doesn't work, and I need someone to fix it for me?

I suggest to you use Variables instead Interger A / B
and Try it if its work or not

 

[TheWhiteWolf]

Tried it. Still doesn't work.

 

[deathismyfriend]

As said above remove integer A / B and replace with a custom integer variable. (Will not fix problem. It is only for optimizations as integer A / B are slower)

Place some debug messages to make sure this trigger fires. Then place a few messages in the code to see what runs and what doesn't.

This also loops from 1 - 4 which means it is not MUI.
Please supply the other code for adding units to unit group.

 

[TheWhiteWolf]

I managed to fix the problem. However, it was not due to help I received here

The problem was that the variable TempUnit was used in a trigger I made for calculating damage. At the end of that other trigger, TempUnit was set to No unit, which caused this trigger to malfunction

This can be closed.