Trigger stops working

[DESTROYER123]

Hello again Everyone!!!
It's the second time I spam this forum today.
I have created this trigger:

• Space Orcs Spawn
  • Events
    • Time - Every 10.00 seconds of game time
  • Conditions
  • Actions
    • Unit - Create 1 (Unit-type of (Random unit from SpaceOrcsLivingUnitGroup)) for Player 2 (Blue) at (Center of Region 001 <gen>) facing 270.00 degrees
    • Wait 2.00 seconds
    • Unit - Create 1 (Unit-type of (Random unit from SpaceOrcsLivingUnitGroup)) for Player 2 (Blue) at (Center of Region 001 <gen>) facing 270.00 degrees

and it works perfect.
However after sometime of gameplay (about 2-3 minutes) it stops working.
Why??

 

[rulerofiron99]

Probably because SpaceOrcsLivingUnitGroup becomes empty.

Note your trigger leaks. http://www.hiveworkshop.com/forums/triggers-scripts-269/things-leak-35124/

You should have posted this in your previous thread, it's the same thing.

 

[DESTROYER123]

How to stop my unit group from becoming empty??

 

[rulerofiron99]

Err, that's something for you to figure out. I don't know how you're using this group, when you're adding and removing units.

I'm assuming you set it to some units at map initialization, and those units eventually die and you never put more units in it.

 

[DESTROYER123]

XD you found it out!!

• Space Orcs Living Unit Group
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Unit Group - Pick every unit in (Units in Region 005 <gen>) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Owner of (Picked unit)) Equal to Player 2 (Blue)
          • Then - Actions
            • Unit Group - Add (Picked unit) to SpaceOrcsLivingUnitGroup
          • Else - Actions

Is the problem with this trigger???

PS!!!
There is and another one trigger that kills all units in region 005 after they have been picked.

 

[rulerofiron99]

There isn't a problem with the trigger, but you haven't explained how you use the unit group further.

When all the units that you add to the group at the start die, it is empty and your other trigger stops working.

I'm really annoyed that you aren't being clear (which would help me help you), but the fix will probably be this:

• Space Orcs Spawn
• Events
  • Time - Every 10.00 seconds of game time
• Conditions
• Actions
  • Unit - Create 1 (Unit-type of (Random unit from SpaceOrcsLivingUnitGroup)) for Player 2 (Blue) at (Center of Region 001 <gen>) facing 270.00 degrees
  • Unit Group - Add (Last created unit) to SpaceOrcsLivingUnitGroup

 

[ap0calypse]

Instead of doing that, you can store all those unit-types at map init.
After that, they can die or whatever. Doesn't really matter .

In that unit-group trigger you have there ("Space Orcs Living Unit Group"), you can do this:

• Unit Group - Pick every unit in (Units in Region 005 <gen> owned by Player 2 (Blue)) and do (Actions)
  • Loop - Actions
    • Set Count = (Count + 1)
    • Set UnitType[Count] = (Unit-type of (Picked unit))

To create a unit, you then do this:

• Set TempLoc1 = (Center of Region 001 <gen>)
• Unit - Create 1 UnitType[(Random integer number between 1 and Count)] for Player 2 (Blue) at TempLoc1 facing Default building facing degrees
• Custom script: call RemoveLocation( udg_TempLoc1 )

(since this trigger is periodic, it's highly recommended to remove those location leaks!)

 

[DESTROYER123]

Hey rulerofiron99!!!
That worked perfect!!
+rep

But I also have another problem.
If they are at a disadvantage, the units retreat back to the base.
How can I prevent that???
I have unchecked some boxes in the Ai editor but nothing happened.

 

[rulerofiron99]

You should use ap0calypse's solution, it's better for your map's performance.

Explain what you mean by "they retreat when at a disadvantage", I've never seen this happen. Creeps do retreat when they've gone a certain distance from where they were created.

 

[DESTROYER123]

I'll use ap0calypse soloution then (+rep ap0calypse).
What I meant was that those spawned units are ordered to attack-move at a specific location.
However when they reach this area, they are attacked by enemies.
Then istead of attacking them they retreat and form a group witch acts strange.
What I want is a way to stop units from dissobeying my orders and fight to the death.

PS: Ordered units are owned by Player 2 not Neutral Hostile or something like that.

 

[ap0calypse]

Do you still have the action "Run Melee AI Scripts"? Because those AI's are made so they removed injured units from the fight and heal up, or move in groups, or retreat. Those kind of things.

 

[DESTROYER123]

Oh right.
Forgot that one.
Thanks everyone.
Problem solved!!!!!!