[JASS] Thread crashing?

[Eleandor]

While making a system for a clan project, I encountered a problem I haven't been able to solve so far...

Some of you might (or might not) know the "InputMsg" function made by vexorian: it displays a dialog with certain options and returns an integer declaring the chosen option. Well, it has always been working so far, but it looks like the dialog is causing a thread crash as soon as it is shown.

In-game, writing "-dialog" will show a test dialog, which is working perfectly fine.
But when you create a team, and try to disband it (using the abilities on your hero), the disband dialog shows, but the dialog crashes and thus I'm currently not able to disband my team... Online tests also showed the same happens when inviting another player to your team. Those are the only 2 occasions I use dialogs.

The functions that make use of the Dialog are: Team.invitePlayer and Team.disband...

What is the cause of this problem and how do I solve it?

 

[Element of Water]

It looks to me like it's something to do with TSA. Maybe the code is moving on before TSA has finished?

 

[Eleandor]

But why would the code move on in a method but not in a normal function? I mean, when I'm using it in a normal trigger there's no problem, but when I use it in a method the trigger just stops...

It also stops displaying debug messages after the dialog shows, so I think the thread is crashing rather than the code simply moving on...

 

[Element of Water]

exitwhen GetTriggerEvalCount(trig[0]) > 0
        call TriggerSleepAction(0)

It must be one of these 2 lines which cause it... look up problems with those 2 functions and you might get some results.

 

[Eleandor]

Maybe, but I still can't see the precise problem... And neither can I see why the problem occurs in methods but not in functions?

 

[Element of Water]

It might be to do with the and boolean? Just throwing around guesses now I suppose.

 

[peq]

Methods are sometimes run with TriggerEvaluate and TSAs are not allowed there.

 

[Element of Water]

Methods are never run with TriggerEvaluate. Where did you get that from?

 

[peq]

struct test
    method tester takes nothing returns nothing
        call .evaluateme()
    endmethod
    
    method evaluateme takes nothing returns nothing
    endmethod
endstruct

gets compiled to

globals

//JASSHelper struct globals:
constant integer si__test=1
integer si__test_F=0
integer si__test_I=0
integer array si__test_V
trigger st__test_evaluateme
integer f__arg_this

endglobals

//Generated method caller for test.evaluateme
function sc__test_evaluateme takes integer this returns nothing
    set f__arg_this=this
    call TriggerEvaluate(st__test_evaluateme)
endfunction

//Generated allocator of test
function s__test__allocate takes nothing returns integer
 local integer this=si__test_F
    if (this!=0) then
        set si__test_F=si__test_V[this]
    else
        set si__test_I=si__test_I+1
        set this=si__test_I
    endif
    if (this>8190) then
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,1000.,"Unable to allocate id for an object of type: test")
        return 0
    endif

    set si__test_V[this]=-1
 return this
endfunction

//Generated destructor of test
function s__test_destroy takes integer this returns nothing
    if this==null then
            call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,1000.,"Attempt to destroy a null struct of type: test")
        return
    elseif (si__test_V[this]!=-1) then
            call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,1000.,"Double free of type: test")
        return
    endif
    set si__test_V[this]=si__test_F
    set si__test_F=this
endfunction

    function s__test_tester takes integer this returns nothing
        call sc__test_evaluateme(this)
    endfunction
    
    function s__test_evaluateme takes integer this returns nothing
    endfunction


//Struct method generated initializers/callers:
function sa__test_evaluateme takes nothing returns boolean
local integer this=f__arg_this
   return true
endfunction

function jasshelper__initstructs8318378 takes nothing returns nothing
    set st__test_evaluateme=CreateTrigger()
    call TriggerAddCondition(st__test_evaluateme,Condition( function sa__test_evaluateme))

endfunction

 

[Element of Water]

Why doesn't the JassHelper manual say anything about this? If it's true though, I doubt it's his problem, because he calls the method from a function.

 

[Eleandor]

It uses TriggerEvaluate? That sucks terribly. And no mention of that in the manual sucks even harder.

Any way to easily fix this? Well, any way to fix this in the first place, except messing with the mapscript? Changing that Dialog function of vexorian with timers sounds a pain in the ass too...

 

[Element of Water]

It's not even possible to do it without TSA, or it isn't using just one function call inside an if statement anyway. And I think the workaround around is to call the method from below it in the map code.

 

[Eleandor]

I've solved it by making functions that basically do everything that used to be in the method. Ugly solution, especially because I'm using the struct's private members, but the only solution available I fear.

 

[Element of Water]

So it all works now?

 

[Eleandor]

Yeah. Well, technically it doesn't, but that's because of an unrelated bug . The dialog stuff now works by avoiding using methods.

 

[Element of Water]

Ok then, problem kinda solved. I won't bother with this thread no more...