• 🏆 Texturing Contest #33 is OPEN! Contestants must re-texture a SD unit model found in-game (Warcraft 3 Classic), recreating the unit into a peaceful NPC version. 🔗Click here to enter!

Thread Crash

Status
Not open for further replies.

Arhowk

Arhowk

Arhowk

Level 19
Joined
Aug 8, 2007
Messages
2,765
I cant figure out why this thread is crashing.. Most likely its because of a squareroot(negative) but I'm unable to locate it

crit

damage detector

JASS: 
library crit initializer Init
    globals
        private hashtable critHash = InitHashtable()
        private real ExternalFactorRate = 20
        private real ExternalFactorPower = 200
        private real InternalFactorRate = 20
        private real InternalFactorPower = 20
        private real SubtractionFactorRate = 25
        private real SubtractionFactorPower = 25
    endglobals
    function registerCritRate takes item i, real critRate returns nothing
        call SaveReal(critHash, GetItemTypeId(i), 0, critRate) 
    endfunction
    function registerCritPow takes item i, real critPow returns nothing
        call SaveReal(critHash, GetItemTypeId(i), 1, critPow) 
    endfunction
    function getCritRate takes unit u returns real
        local boolean test = SubtractionFactorRate > GetHeroInt(u, true)
        local real rate
        local real r = 0
        local integer i = 0
        if test then
            set rate = 0
           // set rate = (ExternalFactorRate * SquareRoot((1/(GetHeroLevel(u) + InternalFactorRate)) * SquareRoot(GetHeroInt(u, true) - SubtractionFactorRate)))
        else
            set rate = 0
        endif
        if u == udg_PlayerUnit[GetConvertedPlayerId(GetOwningPlayer(u))] then
            loop
                exitwhen i == 10
                set r = 100 - rate
                set r = ModuloReal(r, LoadReal(critHash, GetEquippedItemTypeId(GetOwningPlayer(u), i), 0))
                set rate = rate + r
                set r = 0
                set i = i + 1
                call print(R2S(r))
                call print(R2S(rate))
            endloop
        endif
        return rate
    endfunction
    function getCritPow takes unit u returns real
        local boolean test = SubtractionFactorPower > GetHeroAgi(u, true)
        local real rate
        local real r = 0
        local integer i = 0
        if test then
            set rate = -0
           // set rate = (ExternalFactorPower * SquareRoot((1/(GetHeroLevel(u) + InternalFactorPower)) * SquareRoot(GetHeroAgi(u, true) - SubtractionFactorPower)))
        else
            set rate = 0
        endif
        if u == udg_PlayerUnit[GetConvertedPlayerId(GetOwningPlayer(u))] then
            loop
                exitwhen i == 10
                set r = 100 - rate
                set r = ModuloReal(r, LoadReal(critHash, GetEquippedItemTypeId(GetOwningPlayer(u), i), 1))
                set rate = rate + r
                set r = 0
                set i = i + 1
                call print(R2S(r))
                call print(R2S(rate))
            endloop
        endif
        return rate
    endfunction
    private function Init takes nothing returns nothing
    endfunction
endlibrary

JASS: 
function Trig_Set_Damage_Copy_Actions takes nothing returns nothing
    local unit s = udg_DamageEventSource
    local unit t = udg_DamageEventTarget
    local unit udum = null
    local unit caster
    local group g = CreateGroup()
    local location l
    local location l2
    local integer i = GetPlayerId(GetOwningPlayer(s))
    local integer i2
    local integer i3
    local real i4
    local real amount = udg_DamageEventAmount
    local boolean crit
    
    if GetPlayerId(GetOwningPlayer(s)) < 10 then
        if s != udg_PlayerUnit[i + 1] then
            if GetRandomInt(1, 100) < getCritRate(s) then
                set crit = true
                set udg_DamageEventAmount = getCritPow(s)
                set amount = udg_DamageEventAmount
            endif
        else
            if GetRandomInt(1,100) < getCritRate(udg_PlayerUnit[i + 1]) then
                set crit = true
                set udg_DamageEventAmount = getCritPow(udg_PlayerUnit[i + 1])
                set amount = udg_DamageEventAmount
            endif
        endif
    else
        call print(I2S(i))
    endif
            
    //chop//
    
    if ( crit ) then
        call CreateTextTagUnitBJ( ( I2S(R2I(udg_DamageEventAmount)) + "!" ), udg_DamageEventTarget, 50.00, 13.00, 100, 5.00, 10.00, 0 )
        call SetTextTagVelocityBJ( GetLastCreatedTextTag(), 75.00, 90.00 )
        call SetTextTagPermanentBJ( GetLastCreatedTextTag(), false )
        call SetTextTagLifespanBJ( GetLastCreatedTextTag(), 3.50 )
        call SetTextTagFadepointBJ( GetLastCreatedTextTag(), 1.40 )
    endif
    
    call DestroyGroup(g)
    set s = null
    set t = null
    set udum = null
    set caster = null
    set l = null
    set l2 = null
    set g = null
    //ll TimerStart(time, 0.01, false,function timerEnd)
endfunction

//===========================================================================
function InitTrig_Set_Damage_Copy takes nothing returns nothing
    set gg_trg_Set_Damage_Copy = CreateTrigger(  )
    call TriggerRegisterVariableEvent( gg_trg_Set_Damage_Copy, "udg_DamageModifierEvent", EQUAL, 1.00 )
    call TriggerAddAction( gg_trg_Set_Damage_Copy, function Trig_Set_Damage_Copy_Actions )
endfunction



yes i know i need to switch to Nestharus's DDS, ill get to it when i get to it.
 

Arhowk

Arhowk

Arhowk

Level 19
Joined
Aug 8, 2007
Messages
2,765
Dr Super Good said:
Which thread? I cannot see any possible thread to crash.
Click to expand...

herp de derp i was editing the version from the skydrive and not the version in my maps folder

E/ spoke too fast. yes its crashing

JASS: 
if GetPlayerId(GetOwningPlayer(s)) < 10 then
        if s != udg_PlayerUnit[i + 1] then
            if GetRandomInt(1, 100) < getCritRate(s) then
                set crit = true
                set udg_DamageEventAmount = getCritPow(s)
                set amount = udg_DamageEventAmount
                call print(R2S(getCritRate(s)) + " 11")
                call print(R2S(getCritPow(s)) + " 10")
            else
                call print(R2S(getCritRate(s)) + " 11")
            endif
        else
            if GetRandomInt(1,100) < getCritRate(udg_PlayerUnit[i + 1]) then
                set crit = true
                set udg_DamageEventAmount = getCritPow(udg_PlayerUnit[i + 1])
                set amount = udg_DamageEventAmount
                call print(R2S(getCritRate(udg_PlayerUnit[i + 1])) + " 12")
                call print(R2S(getCritPow(udg_PlayerUnit[i + 1])) + " 13")
            endif
        endif
    else
    endif

crashes if the first if then else returns false.

updated crit

JASS: 
library crit initializer Init
    globals
        private hashtable critHash = InitHashtable()
        private real ExternalFactorRate = 20
        private real ExternalFactorPower = 200
        private real InternalFactorRate = 20
        private real InternalFactorPower = 20
        private real SubtractionFactorRate = 25
        private real SubtractionFactorPower = 25
    endglobals
    function registerCritRate takes item i, real critRate returns nothing
        call SaveReal(critHash, GetItemTypeId(i), 0, critRate) 
    endfunction
    function registerCritPow takes item i, real critPow returns nothing
        call SaveReal(critHash, GetItemTypeId(i), 1, critPow) 
    endfunction
    function getCritRate takes unit u returns real
        local boolean test = SubtractionFactorRate > GetHeroInt(u, true)
        local real rate
        local real r = 0
        local integer i = 0
        if test then
            set rate = 0
            set rate = (ExternalFactorRate * SquareRoot((1/(GetHeroLevel(u) + InternalFactorRate)) * SquareRoot(GetHeroInt(u, true) - SubtractionFactorRate)))
        else
            set rate = 0
        endif
        if u == udg_PlayerUnit[GetConvertedPlayerId(GetOwningPlayer(u))] then
            loop
                exitwhen i == 10
                set r = 100 - rate
                set r = ModuloReal(r, LoadReal(critHash, GetEquippedItemTypeId(GetOwningPlayer(u), i), 0))
                set rate = rate + r
                set r = 0
                set i = i + 1
            endloop
        endif
        return rate
    endfunction
    function getCritPow takes unit u returns real
        local boolean test = SubtractionFactorPower > GetHeroAgi(u, true)
        local real rate
        local real r = 0
        local integer i = 0
        if test then
            set rate = -0
            set rate = (ExternalFactorPower * SquareRoot((1/(GetHeroLevel(u) + InternalFactorPower)) * SquareRoot(GetHeroAgi(u, true) - SubtractionFactorPower)))
        else
            set rate = 0
        endif
        if u == udg_PlayerUnit[GetConvertedPlayerId(GetOwningPlayer(u))] then
            loop
                exitwhen i == 10
                set r = 100 - rate
                set r = ModuloReal(r, LoadReal(critHash, GetEquippedItemTypeId(GetOwningPlayer(u), i), 1))
                set rate = rate + r
                set r = 0
                set i = i + 1
            endloop
        endif
        return rate
    endfunction
    private function Init takes nothing returns nothing
    endfunction
endlibrary

2E/ I found my problem. ModuloReal(x,y) doesnt make sure that y isnt <=0.
 
Last edited:
Status
Not open for further replies.

Similar threads

hell gate
  • Locked
[JASS] Is this more efficient?
Replies
18
Views
950
YourNameHere
YourNameHere
Arhowk
  • Locked
Reverse Distance-based Damage
Replies
1
Views
526
PurplePoot
PurplePoot
JC Helas
  • Locked
[vJASS] Simple Unit Custom Data
Replies
0
Views
475
JC Helas
JC Helas
I-am-murloc
  • Locked
Need to modify this JASS a bit
Replies
2
Views
708
I-am-murloc
I-am-murloc
Komaqtion
  • Locked
[JASS] GroupEnumUnitsInRangeOfXYEx which count Locusted units is useful ? :o
Replies
13
Views
872
Komaqtion
Komaqtion
Top