[Trigger] This trigger gt any leaks?or will make game lag?

[nightwalkerg]

• Shuriken Effect
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • For each (Integer A) from 1 to 28, do (Actions)
      • Loop - Actions
        • Set Shuriken_point = (Shuriken_area offset by 560.00 towards ((Real((Integer A))) x 15.00) degrees)
        • Unit - Create 1 Shuriken for (Owner of ShurikenCaster) at Shuriken_point facing Shuriken_area
        • Set ShurikenDummy[(Integer A)] = (Last created unit)
        • Unit - Add ShurikenAbility[(Level of Shuriken for ShurikenCaster)] to ShurikenDummy[(Integer A)]
        • Unit - Add a 1.50 second Generic expiration timer to ShurikenDummy[(Integer A)]
        • Custom script: call RemoveLocation (udg_Shuriken_point)

This trigger gt any leaks?or will make game lag?

 

[Geries]

It not leaks but if you will not remove those units it will lagg a lot after a time

Edit: Every 1 second you create unit for 1.5 second so after 10 mins( 600 secs ) there will be 600*28*( 1.5 - 1 ) = 8400!!!!!! units on the map...

 

[Bannar]

I don't get why you set (Last created unit) to variable since it will expire in 1.5 sec anyways so you cant do much with it.

It not leaks but if you will not remove those units it will lagg a lot after a time

Long way to goooo.
Adding expiration timer fixs that problem.

 

[nightwalkerg]

It not leaks but if you will not remove those units it will lagg a lot after a time

Edit: Every 1 second you create unit for 1.5 second so after 10 mins( 600 secs ) there will be 600*28*( 1.5 - 1 ) = 8400!!!!!! units on the map...

if wan to remove need how to edit???

I don't get why you set (Last created unit) to variable since it will expire in 1.5 sec anyways so you cant do much with it.


Long way to goooo.
Adding expiration timer fixs that problem.

adding expiration timer...to other trigger for remove units?

 

[Geries]

set the expiration timer from 1.5 to 1 that will fix. Or sometimes disable trigger( if it is not )

 

[Bannar]

@nightwalkerg You can leave 1.5 sec expiration, no problem

@geries Man, what are you talking about?
Expiration timer by itself times unit's life, enables to play death animation and unit will be removed like normal dead unit with time. Ofcourse spamming 28 isn't good especialy if he doesnt disable trigger from time to time but if its dummy unit (with no model) expiration timer removes it instantly.

 

[nightwalkerg]

@nightwalkerg You can leave 1.5 sec expiration, no problem

that mean this trigger has no problem???will not cause any lag???
this is a skill~when been use...it will spawn 28 dummy around casting unit for 10 seconds...unit model is mirror image <special>...but it will show one time the animation...so i create this trigger ><

 

[Geries]

if you not use all the time it is good. No problem with it. If you would use it all time game it would lag after a time

 

[Bannar]

If units are created just for effect better use special effects - they take up much less memory.

 

[nightwalkerg]

If units are created just for effect better use special effects - they take up much less memory.

but i wan the animation is facing casting unit...

 

[mckill2009]

Shuriken_area offset by 560.00 creates a location so it leak, where is Shuriken_area btw???...

 

[nightwalkerg]

Shuriken_area offset by 560.00 creates a location so it leak, where is Shuriken_area btw???...

it remove in other trigger...><

 

[mckill2009]

it remove in other trigger...><

really?, if you remove it before, then this trigger doesnt make sense...if you remove it after then it's the position of ???...

offsets suppose to be done like this;

loc1 - position of ???
loc2 - loc1 offset by ...
move unit to loc2
createunit at loc2
remove loc1
remove loc2

 

[Bannar]

I would like to see other trigger as well nightwalkerg.

 

[nightwalkerg]

• Shuriken
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Shuriken
  • Actions
    • Set ShurikenCaster = (Casting unit)
    • Set Shuriken_area = (Position of ShurikenCaster)
    • Trigger - Turn on Shuriken Effect <gen>
    • Wait 6.00 seconds
    • Trigger - Turn off Shuriken Effect <gen>
    • Custom script: call RemoveLocation (udg_Shuriken_area)

• Shuriken Effect
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • For each (Integer A) from 1 to 24, do (Actions)
      • Loop - Actions
        • Set Shuriken_point = (Shuriken_area offset by 560.00 towards ((Real((Integer A))) x 15.00) degrees)
        • Unit - Create 1 Shuriken for (Owner of ShurikenCaster) at Shuriken_point facing Shuriken_area
        • Set ShurikenDummy[(Integer A)] = (Last created unit)
        • Unit - Add ShurikenAbility[(Level of Shuriken for ShurikenCaster)] to ShurikenDummy[(Integer A)]
        • Custom script: call RemoveLocation (udg_Shuriken_point)
    • Wait 0.50 seconds
    • For each (Integer A) from 1 to 24, do (Actions)
      • Loop - Actions
        • Unit - Remove ShurikenDummy[(Integer A)] from the game

if i change like this...is it ok???

 

[Bannar]

Remove the Wait from trigger above and use real variable to store duration:

• Set Duration = 6.00

And by the may, using location this way is risky, better refer to Caster unit itself:

• Shuriken
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Shuriken
  • Actions
    • Set ShurikenCaster = (Casting unit)
    • Set Duration = 6.00
    • Trigger - Turn on Shuriken Effect <gen>

Now in the loop:

• Shuriken Effect
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • If (All conditions are true) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Duration Greater than 0
      • Then - Actions
        • Set Duration = Duration - 1.00
        • Set Shuriken_area = (Position of ShurikenCaster)
        • For each (Integer A) from 1 to 28, do (Actions)
          • Loop - Actions
            • Set Shuriken_point = (Shuriken_area offset by 560.00 towards ((Real((Integer A))) x 15.00) degrees)
            • Unit - Create 1 Shuriken for (Owner of ShurikenCaster) at Shuriken_point facing Shuriken_area
            • Set ShurikenDummy[(Integer A)] = (Last created unit)
            • Unit - Add ShurikenAbility[(Level of Shuriken for ShurikenCaster)] to ShurikenDummy[(Integer A)]
            • Unit - Add a 1.50 second Generic expiration timer to ShurikenDummy[(Integer A)]
            • Custom script: call RemoveLocation (udg_Shuriken_point)
        • Custom script: call RemoveLocation (udg_Shuriken_area)
      • Else - Actions
        • Trigger - Turn off (This trigger)

If you want to make this trigger MUI let me know.

 

[mckill2009]

the wait looks horrible without using local variables...

 

[nightwalkerg]

@Spinnaker
i tried the expiration timer and remove unit...
expiration timer will be lag...
and remove unit will not lag...
how to put remove unit into trigger???using wait or other trigger to remove???

 

[Bannar]

If you would be using empty model for dummy unit (since it's just created to cast one spell - it's appearance is not needed). To do that go to Object Editor, find given dummy unit and in Art - Model enter ".mdl" (without "").

By the way, I have forgotten that you do not require array variable for unit, use non array one.
If you really want to do that using unit removal, use:

• Shuriken Effect
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • If (All conditions are true) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Duration Greater than 0
      • Then - Actions
        • Set Duration = Duration - 1.00
        • Set Shuriken_area = (Position of ShurikenCaster)
        • For each (Integer A) from 1 to 28, do (Actions)
          • Loop - Actions
            • Set Shuriken_point = (Shuriken_area offset by 560.00 towards ((Real((Integer A))) x 15.00) degrees)
            • Unit - Create 1 Shuriken for (Owner of ShurikenCaster) at Shuriken_point facing Shuriken_area
            • Set ShurikenDummy = (Last created unit)
            • Unit - Add ShurikenAbility[(Level of Shuriken for ShurikenCaster)] to ShurikenDummy
            • Trigger - Run init <gen> (ignoring conditions)
            • Custom script: call RemoveLocation (udg_Shuriken_point)
        • Custom script: call RemoveLocation (udg_Shuriken_area)
      • Else - Actions
        • Trigger - Turn off (This trigger)

• init
  • Events
  • Conditions
  • Actions
    • Custom script: local unit u = udg_ShurikenDummy
    • Custom script: call TriggerSleepAction(1.5)
    • Custom script: call RemoveUnit(u)
    • Custom script: set u = null

 

[nightwalkerg]

init trigger error><can't be run

 

[Bannar]

Show me error window please. It's your mistake/misstype.

 

[nightwalkerg]

this one

 

[Bannar]

It's all because you don't read carefully. I have said that you should change ShurikenDummy variable from array to non array one.

If you will have troubles fixing this anyways, post map - it's 5 sec.

 

[nightwalkerg]

it work^^~thanks spinnaker!!!!^^