[Snippet] TextBar

[Nestharus]

This resource has moved here.

--

gone

 

[Magtheridon96]

Can you change the underscores and add some other suffix instead? :/
The underscores are fugly D:

 

[Nestharus]

that's how I do private fields now. It helps me organize. _p = private.

 

[Bribe]

that's how I do private fields now. It helps me organize. _p = private.

        @private@ static string array @bars@
        
        @private@ string bar@_p@

oic

 

[Nestharus]

I didn't do bars because I was too lazy to change it (started the _p thing after I did the bars var) + it's never accessed from the outside, but yea, all private fields I think should have a _p to denote that they are private ; ). I'll probably be doing that in my resources from now on ; ).

 

[Bribe]

I sometimes do similar things and often so does Berbanog, if you look at his Custom Projectiles for example.

 

[Magtheridon96]

I usually use short variable names for private stuff, and I use long ones for public things

 

[Troll-Brain]

I usually use short variable names for private stuff, and I use long ones for public things

Wait, you are using long ones ?

Seems a nice convention Nestharus (couldn't imagine i would say that)

 

[Magtheridon96]

Wait, you are using long ones ?

Yush
If you would look at my Atomic Bomb spell in the Spells section, you'd notice how I use meaningful names everywhere
Advanced Streak System is an excellent example for that too (Super long names like killingPlayerId, killingName, dyingName, etc...


I don't like underscores at all D:
I don't know what you people see in them D:

 

[Troll-Brain]

I don't like underscores at all D:
I don't know what you people see in them D:

v__jass

Spoiler

Well, since it's not Mag the owner of the thread, it's the end of the flood from me.

 

[Magtheridon96]

Well, this is a solid, simple resource.
I love how it's incredibly fast during game-time

The only thing I hate is the number of string leaks this is creating :L

I will approve this, I just need an opinion or two. C:

 

[Bribe]

You can't always avoid string leaks.

Although if Nestharus changed "max width" to a power of two he could drastically reduce the number of leaks in the Init function down to 9 or 10.

 

[Magtheridon96]

Yeah, that is a much better solution.
512 would be excellent.

edit
It would be slower during game-time, but I wouldn't care. 9 iterations along with some subtraction operations and a dynamic bool array shouldn't hurt.

 

[Nestharus]

I initially thought that the power of 2 idea was good, but then I saw this

set bar_p = color_p.apply(bars[R2I(width_p*percent_p + .5)]) + Color.convert(0, 0, 0, 0) + bars[R2I(width_p*(1 - percent_p) + .5)] + "|r"

Remember, the bars are colored and are split (colored portion + blank portion, like health bar with one portion empty and one portion filled). With power of 2, you'd be up to the exact same amount of leaks with substrings in the worst case scenario with worse performance and less accuracy.

I think that it's fine as is and is ready for approval.

 

[Magtheridon96]

Hmm.
Seems about right

I guess this does what it was written for and has a lot of practical applications like channeling bars, multiboard bar systems, etc...

Approved.