[Snippet] DamageEvent

[jim7777]

vampiric aura will trigger lifesteal whether you like it or not
and perhaps you may just filter those out upon index but there will be some instances that the units will have some upgrades like increase attack range and such o.o

@nes
lol this:

The only system I have out there right now that I wouldn't count as super optimal is Damage Modification Effect. You can count on everything else being extremely optimal and modular, running off of normally much better algorithms than you will find in any other system on any other site. The trade off for this is that some of these algorithms are much more complex to code, meaning that you may run into bugs in some systems if the version number is low. This one doesn't have said bugs, but I do still have one system out there right now that is known to have 1 bug =P. BigInt also had 1 bug in the division algorithm (which was handcrafted by me and somewhat complex, but super fast).

 

[Laiev]

Obvious you should remove the ability when you're done.

 

[jim7777]

it will still trigger lifesteal events D:
even though it's not that noticeable if there are no melee units nearby and perhaps and when it is removed immediately
you know that buffs aren't removed immediately when the ability is removed....

 

[Laiev]

'Lifesteal Events' = ?

Also, you can always set % of lifesteal to 0.

 

[jim7777]

it's more useful if i guess i'll use the natives...

there are still (i think two) buff problems.. either the removal is not immediate or another buff is added to the unit with the same base buff ID causing the first buff to extend its duration... o.o

anyways lets just see if nes nes can make an extension for it o.o

 

[Nestharus]

I don't really mod at all for wc3 anymore, so an extension by me is probably never going to happen. I can pretty much guarantee that =P.

 

[jim7777]

ohh that's unfair lol
perhaps you may mod wc3 into a new game.. something like NesCraft

LOL

 

[Magtheridon96]

Nestharus is actually planning on writing his own game in the future

 

[Adiktuz]

you know that buffs aren't removed immediately when the ability is removed....

->you should remove the buff too, not just the ability... that way, it will be removed "instantly"... then set lifesteal to 0.0 and set target to false so that only the unit that you wanna check if it has lifesteal or not will be affected...

 

[Yixx]

... DamageEvent needs a fix, ...

Why? What is wrong with it? Are there bugs, or is it just not up to your own performance standards? (or any other standard for that matter..)

 

[Nestharus]

It just has a couple of extra operations in it that shouldn't be there and do nothing

 

[Yixx]

So basically it is just not up to your standards, but there are no fundamental mistakes or bugs that prevent it from working correctly?

 

[Nestharus]

Yup ; )

 

[Nestharus]

Fixed a tiny behavior bug for attack type etc =)

 

[Nestharus]

Added support for a new extension! : D

 

[dungchung2]

Help me!
I want RegisterDamageEvent when unit type 'XXXX' got damaged then do some actions but I don't know how to use your DamageEvent and this extension AdvDamageEvent to do that. Make a tutorial or demo pls. Thanks

For detail: i'm using TriggerRegisterPlayerUnitEvent with event EVENT_PLAYER_UNIT_ATTACKED, normally it work well when unit attack unit then i can get attaker or attacking unit, but when using some spell system that mean unit attacked by dummy or this:

call UnitDamageTarget(.caster, theUnit, .dmg, false, false, ATTACK_TYPE_CHAOS, DAMAGE_TYPE_UNKNOWN, WEAPON_TYPE_WHOKNOWS)

then TriggerRegisterPlayerUnitEvent cant help anymore. That why i want use your DamageEvent

 

[Nestharus]

Read the docs man..

*   module DamageEvent extends DamageEvent, AdvDamageEvent (if exists)
*
*       Interface
*       ------------------
*           private static constant method PRIORITY takes nothing returns integer       (optional)
*               -   without this declared, the priority will be set to 0 (no priority)
*           private static method onDamage takes nothing returns nothing                (optional)
*           private static method filter takes nothing returns boolean

struct Demo extends array

private static constant method PRIORITY takes nothing returns integer
    return 5
endmethod

private static method onDamage takes nothing returns nothing
endmethod

implement DamageEvent
endstruct

 

[dungchung2]

Yup now i got it, sorry for my miserable .
Anyway Is there a way to have merge your DamageEvent with this one: http://www.hiveworkshop.com/forums/jass-resources-412/extension-unit-event-172365/
I can register envent like that:

static constant Event UnitEvent.DAMAGED

 

[Nestharus]

Yea, you can put them both into the same map. I have plenty of maps with both of them in it.

 

[Nestharus]

Graveyarding due to deprecation