[Snippet] Bounty

[Nestharus]

This resource has moved here.

--

gone

 

[Nestharus]

Optimized comparisons and removed extra space

 

[BBQ]

                set m=null
                set z=null

Players don't leak, so there's no need to do that.

 

[Nestharus]

Actually, according to a friend of Bribe's, his map lagged until he nulled player handles.


I now null all handles.


The reason for this is because all handles, even if they are never destroyed, still count references.. what this means is that the ref counter just keeps going up and up and up and up =P.


yaaa, it's stupid =), but if you don't want a huge ref count, then you gotta null

 

[BBQ]

The reference count serves absolutely no purpose for agents that are never destroyed. That's exactly the case with players.

I just tried executing a function that had 12 local player variables in it (each pointing to a certain player, of course), 20000 executions with nulling and 20000 without. Guess what? There was no difference whatsoever.

And I have no idea what stuff Bribe's friend was on.

 

[Nestharus]

lol, well... I'm just playing it safe until there is a memory test done ^)^.

 

[BBQ]

My "Guess what? There was no difference whatsoever." was referring to, among other things, to the memory usage. But it's up to you.

 

[Magtheridon96]

Also, nulling all handles is a good programming practice.
Get used to it.
Just null everything.
In some very rare cases, even strings need to be 'nulled'.

local integer i=0
loop
    exitwhen i>8190
    set s[i]="djipwejfiwejfewjpwje'okweewiljweligjfreioe;jroeoigtt/reokgkreg;iojtr;gjrtojiweijgrerjglreijlwgerihjwreoijgeriwjgrewoijewirojiwjiowjguwjgwjgoiwjoirjergjoirewjgrjeglksdjfijetiu4hreewjgkhuikhw7y"
    set i=i+1
endloop

That would leak a total of 1.8 MB 0.o (Equivalent to about 180 special effects)

 

[BBQ]

Also, nulling all handles is a good programming practice.
Get used to it.
Just null everything.
In some very rare cases, even strings need to be 'nulled'.

local integer i=0
loop
    exitwhen i>8190
    set s[i]="djipwejfiwejfewjpwje'okweewiljweligjfreioe;jroeoigtt/reokgkreg;iojtr;gjrtojiweijgrerjglreijlwgerihjwreoijgeriwjgrewoijewirojiwjiowjguwjgwjgoiwjoirjergjoirewjgrjeglksdjfijetiu4hreewjgkhuikhw7y"
    set i=i+1
endloop

That would leak a total of 1.8 MB 0.o (Equivalent to about 180 special effects)

Okay now, I agree that it might be "good practice" to null players, but strings? You've got to be kidding me.

Each time a new string is used, it is cached and stored into a table for further access and usage. And they are never removed from the table during run-time. That is WC3's way of optimizing the speed at which strings are accessed and operations with them are done.

In your example, you don't create 8190 strings, but instead you create just a single one.

So I can safely tell you that nulling strings does absolutely nothing.

 

[Nestharus]

So I can safely tell you that nulling strings does absolutely nothing.

/agree with all of what BBQ said

 

[Magtheridon96]

Each time a new string is used, it is cached and stored into a table for further access and usage. And they are never removed from the table during run-time. That is WC3's way of optimizing the speed at which strings are accessed and operations with them are done.

I never knew that
But still, you should null absolutely everything that extends a handle.

 

[Nestharus]

Fixed Bounty to catch lumber or gold. Before it only caught lumber and gold. Now it catches all 3 cases.

 

[Nestharus]

Updated to use RegisterPlayerUnitEvent and removed nulling of players


this is ready for approval whenever Bribe is ready : p

 

[Bribe]

Removed nulling of players? R U srs???

 

[Troll-Brain]

It makes sense, since it fits with the short name convention. (joke ofc)

Seriously i would null every local handle, just to be sure.

 

[Magtheridon96]

It makes sense, since it fits with the short name convention. (joke ofc)

I'm going to submit an empty resource and say it's the fastest resource

 

[Nestharus]

Player reference counting doesn't do anything since they are never destroyed, so there is no point to nulling them : )

 

[Troll-Brain]

Player reference counting doesn't do anything since they are never destroyed, so there is no point to nulling them : )

That makes sense , if ... we are not talking about jass

Also i know someone with a map which was (is ?) played and he says that players complained about lag/desync/memory usage/whatever (can't remember what lame thing)
He did nothing but nulled player locals and he said that was fixed.

To be honest i don't believe that much in it, even if he is not usually a liar, it's more likely he has missed something.

Moar safety is always good since the speed advantage of not nulling it is ridiculous.

 

[Nestharus]

All righty then, put the nulls back in >.>.

 

[Bribe]

Approved. Good resource.

 

[Bribe]

Opening thread

 

[pred1980]

Hallo Nestharus,

can you give me an example how to use your Bounty Snippet?
Just the part how to execute it... Bounrty.create(...) ?? or ?

 

[Nestharus]

static readonly Event event

Look up Event API : )

 

[pred1980]

Ok, i checked your API but i've still a question.
If a unit dies i want to give the killer gold. For this i want to use a table, hashtable or an array. I'll see. In this object i want to save the unitId and the bounty. So if a unit die, i look in this obj and so i get the bounty. And now, how i use your Snippet to give the killer the bounty?

Reg.
Patrick

 

[Nestharus]

It doesn't work like that =). This runs when the bounty is given via a unit death, so latching on to this event will get you that bounty. From there, you can use the bounty however you want. For example, in a footies map, I gave people bonus bounty and so forth, so I did a little +bonus bounty text tag alongside the regular bounty.

 

[pred1980]

ah ok. Thx.

 

[-Kobas-]

Don't get me wrong but isn't this somehow useless?
I really don't see any practical use of this, even WE newbies that code terrible triggers
using simple GUI can easily create decent bounty system that will with a little more work
even calculate experience, handle floating texts and so on.

And even if you wanted to do that above, simple small library or struct without external
required scripts won't be longer than maybe 40 lines of code if we keep things simple.

If we decide to register each unit type or even handle on it's own, it can increase size
but that's map maker decision.

 

[PurgeandFire]

This will register when regular bounty occurs and provide an interface for it. So this is useful as long as you use regular bounty. If you don't, you probably won't have as much of a use for it.

I understand what you mean though. In most cases, you'll want a custom bounty system. However, it is always nice to have scripts for these kinds of things in the off chance that someone needs it.

 

[Nestharus]

For mass kill maps, like footman wars, this is useful. Those are the types of maps that I use this in.

In an ORPG? Not so useful.