Snipeshot v1.1

[Antares]

You should add the passive tag to this spell.

This is quite an interesting variant for a splash damage attack, but I can't make heads or tails of the config. What does the SnipeS_DamageOffset variable do? It is not the same as the LSE_Offset, because that is hardcoded to be 100 in the SnipeshotRealDamage trigger.

From my understanding of what the ability is supposed to do, if I set the armor pierce to 0, the main target should take the same amount of damage whether the unit has the ability or not. But I find that it still increases the damage dealt to the main target.

Please provide better descriptions for your config and see that all the math is correct.

Awaiting Update

 

[Daffa]

You should add the passive tag to this spell.

This is quite an interesting variant for a splash damage attack, but I can't make heads or tails of the config. What does the SnipeS_DamageOffset variable do? It is not the same as the LSE_Offset, because that is hardcoded to be 100 in the SnipeshotRealDamage trigger.

From my understanding of what the ability is supposed to do, if I set the armor pierce to 0, the main target should take the same amount of damage whether the unit has the ability or not. But I find that it still increases the damage dealt to the main target.

Please provide better descriptions for your config and see that all the math is correct.

Awaiting Update

v1.1:

• Changed AfterDamageEvent to PreDamageEvent
• Reconfigure conditions to ensure proper safety and prevent potential recursions
• Added debug messages to validate damage values
• Restructure the unit group to prevent double damage on main target

Forgot to add on the changelog since I am rushing the push, but the offset variable is now properly set. Anyway, time for proper commenting.

---

Well, you love to give me a number of headache, Antares

Fixed the tag.

Fixed this variable. Must've slipped when I was going to release this.

Yes. The main target got double-damaged (from the main attack and this system) which was fixed in v1.1. It was something from the unit group conditioning that caused it.

All maths are correct, have fun with the log I added
I think the comment is sufficient, but if that is mandatory I can make another round of change.

 

[Antares]

DamageOffset is a confusing name for what this parameter does. I would recommend DamageLineWidth or DamageLineHalfWidth, depending on how it's defined.

An optional special effect on the damaged units would be nice.

Well, you love to give me a number of headache, Antares

That's my job!

All in all, nice passive ability.

Approved