[JASS] Simple Jass Code

[Deep Sea Kraken]

Ok, I made this code is JASS and i was wondering if it will leak or not

function Trig_Chain_Lightning_Caster_no_leak_Conditions takes nothing returns boolean
        return  ( GetUnitTypeId(GetAttacker()) == 'hC36' ) )
endfunction

function Trig_Chain_Lightning_Caster_no_leak_Actions takes nothing returns nothing
    set udg_TempLoc = GetUnitLoc(GetAttacker())
    call CreateNUnitsAtLoc( 1, 'h00I', GetOwningPlayer(GetAttacker()), udg_TempLoc, bj_UNIT_FACING )
    call UnitAddAbilityBJ( 'ACcl', GetLastCreatedUnit() )
    call IssueTargetOrderBJ( GetLastCreatedUnit(), "chainlightning", GetAttackedUnitBJ() )
    call UnitApplyTimedLifeBJ( 0.50, 'BTLF', GetLastCreatedUnit() )
    set TempLoc = null
endfunction

//===========================================================================
function InitTrig_Chain_Lightning_Caster_no_leak takes nothing returns nothing
    set gg_trg_Chain_Lightning_Caster_no_leak = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Chain_Lightning_Caster_no_leak, EVENT_PLAYER_UNIT_ATTACKED )
    call TriggerAddCondition( gg_trg_Chain_Lightning_Caster_no_leak, Condition( function Trig_Chain_Lightning_Caster_no_leak_Conditions ) )
    call TriggerAddAction( gg_trg_Chain_Lightning_Caster_no_leak, function Trig_Chain_Lightning_Caster_no_leak_Actions )
endfunction

 

[Xarwin]

Meh, you just converted GUI to custom script.
Just use custom scripts if u don't know JASS.
Anyway I doubt that

set udg_TempLoc = GetUnitLoc(GetAttacker())

and

set TempLoc = null

will work anyway.
It should be:

local location TempLoc = GetUnitLoc(GetAttacker())

before

Set TempLoc = null

you should add:

call RemoveLocation(TempLoc)

and then :

Set TempLoc = null

 

[Deep Sea Kraken]

Well, right now TempLoc is a global var that im using in several other triggers.

 

[Xarwin]

Well if you change the trigger like I did, you don't need a global in it anymore.
Altough it leaks if u keep it.
To fix it with your version :

Replace

set TempLoc = null

with:

call RemoveLocation(udg_TempLoc)

 

[PurplePoot]

*Ahem* there is no such thing as a 'point' in JASS. It's called a location *Ahem*

By the way, your code seems to be cleaner than GUI in some places and messier in others.

A fully fixed up version of that would be;

function Trig_Chain_Lightning_Caster_no_leak_Conditions takes nothing returns boolean
return GetUnitTypeId(GetAttacker()) == 'hC36'
endfunction

function Trig_Chain_Lightning_Caster_no_leak_Actions takes nothing returns nothing
local unit u = CreateUnit( GetOwningPlayer( GetAttacker() ), 'h00I', GetUnitX( GetAttacker() ), GetUnitY( GetAttacker() ), 0 )
call UnitAddAbility( u, 'ACcl' )
call IssueTargetOrder( u, "chainlightning", GetTriggerUnit() )
call UnitApplyTimedLife( u, 'BTlf', .5 )
set u = null
     endfunction

 function InitTrig_Chain_Lightning_Caster_no_leak takes nothing returns nothing
set gg_trg_Chain_Lightning_Caster_no_leak = CreateTrigger()
call TriggerRegisterAnyUnitEventBJ( gg_trg_Chain_Lightning_Caster_no_leak, EVENT_PLAYER_UNIT_ATTACKED )
call TriggerAddCondition( gg_trg_Chain_Lightning_Caster_no_leak, Condition( function Trig_Chain_Lightning_Caster_no_leak_Conditions ) )
call TriggerAddAction( gg_trg_Chain_Lightning_Caster_no_leak, function Trig_Chain_Lightning_Caster_no_leak_Actions )
endfunction

As you can see, we can A) avoid even touching locations, and B) use the advantages of JASS to skip globals and BJs.

If you actually plan on using JASS more, try to learn to use X/Y coordinates, as they are faster and don't leak.

 

[Xarwin]

*Ahem* there is no such thing as a 'point' in JASS. It's called a location *Ahem*

Aight, I knew I was somewhere wrong. Thanks for pointing me on it PurplePoot!