1. Updated Resource Submission Rules: All model & skin resource submissions must now include an in-game screenshot. This is to help speed up the moderation process and to show how the model and/or texture looks like from the in-game camera.
    Dismiss Notice
  2. DID YOU KNOW - That you can unlock new rank icons by posting on the forums or winning contests? Click here to customize your rank or read our User Rank Policy to see a list of ranks that you can unlock. Have you won a contest and still havn't received your rank award? Then please contact the administration.
    Dismiss Notice
  3. The Lich King demands your service! We've reached the 19th edition of the Icon Contest. Come along and make some chilling servants for the one true king.
    Dismiss Notice
  4. The 4th SFX Contest has started. Be sure to participate and have a fun factor in it.
    Dismiss Notice
  5. The poll for the 21st Terraining Contest is LIVE. Be sure to check out the entries and vote for one.
    Dismiss Notice
  6. The results are out! Check them out.
    Dismiss Notice
  7. Don’t forget to sign up for the Hive Cup. There’s a 555 EUR prize pool. Sign up now!
    Dismiss Notice
  8. The Hive Workshop Cup contest results have been announced! See the maps that'll be featured in the Hive Workshop Cup tournament!
    Dismiss Notice
  9. Check out the Staff job openings thread.
    Dismiss Notice
Dismiss Notice
60,000 passwords have been reset on July 8, 2019. If you cannot login, read this.

[JASS] Script runs and lags on start

Discussion in 'Triggers & Scripts' started by Rugarus, Aug 10, 2019.

  1. Rugarus

    Rugarus

    Joined:
    Dec 2, 2016
    Messages:
    709
    Resources:
    0
    Resources:
    0
    I've got a few scripts that lag the game for some reason when they first run. I think this was caused by Blizzard patches.

    This script which runs when a unit builds a "Time Tower" for the first time in game, it lags the game for like half a second. I've tested with older versions of the game that never had any of these issues and they also have similar lag spikes upon certain scripts running. Is there any way to fix this?
    This script for example is one that lags the game upon running for the first time:


    Code (vJASS):


    library timeTower requires libMisc, libSetup, unitClassification, bloodTower {

    public boolean unitHas_timeTower[12];
    public integer timeTower_time[12];
    public unit timeTowers[12];

    function OnTimy60() {

      integer i;
      timer t=GetExpiredTimer();
      //DisplayTextToForce(GetPlayersAll(), "Current test");
      for (0 <= i < 13) {
    if (unitHas_timeTower[i-1] == true) {
       timeTower_time[i-1] = timeTower_time[i-1] + 1;
       // + add damage
           SetUnitAbilityLevelSwapped('A04R', (timeTowers[i-1]),timeTower_time[i-1]+1);
        //DisplayTextToForce(GetPlayersAll(), "Current time: " + I2S(timeTower_time[i-1]));
       }
      }


    }





    function onStarty() {
    timer t=CreateTimer();
    TimerStart(t, 15, true, function OnTimy60);
    //TimerStart(CreateTimer(), 15, true, function OnTimy60);
            t=null;
    }




    function onCreation() {
    unit u = GetTriggerUnit();

    if (GetUnitTypeId(u) == 't00T') {
    timeTowers[GetConvertedPlayerId(GetOwningPlayer(u))-1] = u;
    timeTower_time[GetConvertedPlayerId(GetOwningPlayer(u))-1] = 0;
    unitHas_timeTower[GetConvertedPlayerId(GetOwningPlayer(u))-1] = true;
    UnitAddAbilityBJ( 'A04R', (timeTowers[GetConvertedPlayerId(GetOwningPlayer(u))-1]));
    //DisplayTextToForce(GetPlayersAll(),"Has tower?: " + B2S(unitHas_timeTower[GetConvertedPlayerId(GetOwningPlayer(u))-1]));
     //DisplayTextToForce(GetPlayersAll(), "Tower: " + GetUnitName(timeTowers[GetConvertedPlayerId(GetOwningPlayer(u))-1]));
    }
    }

    function onDeath() {
    unit d = GetDyingUnit();
    if (GetUnitTypeId(d) == 't00T') {
    timeTower_time[GetConvertedPlayerId(GetOwningPlayer(d))-1] = 0;
    unitHas_timeTower[GetConvertedPlayerId(GetOwningPlayer(d))-1] = false;
    //DisplayTextToForce(GetPlayersAll(),"Has tower?: " + B2S(unitHas_timeTower[GetConvertedPlayerId(GetOwningPlayer(d))-1]));
    // DisplayTextToForce(GetPlayersAll(), "Tower: " + GetUnitName(timeTowers[GetConvertedPlayerId(GetOwningPlayer(d))-1]));
    }
    }


    private function onInit() {
      trigger trg = CreateTrigger();
      trigger creation = CreateTrigger();
      trigger death = CreateTrigger();
      TriggerRegisterAnyUnitEventBJ( creation, EVENT_PLAYER_UNIT_UPGRADE_FINISH );
      TriggerRegisterAnyUnitEventBJ( death, EVENT_PLAYER_UNIT_DEATH );
      TimerStart(CreateTimer(), 60, true, function OnTimy60);
      TriggerAddAction(creation, function onCreation);
      TriggerAddAction(death, function onDeath);
    }

    }
     
     
  2. Pyrogasm

    Pyrogasm

    Joined:
    Feb 27, 2007
    Messages:
    2,901
    Resources:
    1
    Spells:
    1
    Resources:
    1
    Best guess is it's just that the abilities (and any associate models) need to be preloaded once. You can preload models with the Preload() function, and abilities just need to be added a dummy unit (afaik they don't need to be cast).
     
  3. Rugarus

    Rugarus

    Joined:
    Dec 2, 2016
    Messages:
    709
    Resources:
    0
    Resources:
    0
    That must be it, thanks.