Rheiko's Fear System [RFS] v1.0.2

[Rheiko]

Tested this on @Daffa 's Shadow Requiem v1.2
This is the comparison:

 

[Daffa]

This is splendid! I have been having bad taste with issues I ran into with Fear System on my version, so seeing yours really is a good sight for sore eyes

Would need to test it more extensively, but if it is superior in every way possible, it is time to deprecate mine in favor of yours

 

[Daffa]

Had to double post since I saw the comparison video after I send my first post. If there's no issues and this gets approved, mine should be deprecated in favor of Rheiko's

 

[Rheiko]

Thanks for the kind words!
I totally get the frustration, I'm really glad RFS came across as a breath of fresh air for you.
Definitely take your time to test it thoroughly—I'd love to hear any feedback or edge cases you might uncover.
If it ends up working better for your needs, it’d be an honor to have it take the torch forward.
Big thanks to you—without your version, I wouldn't have been inspired to make this one in the first place!

 

[Daffa]

I am tagging @Dominus15 since he seeks a version compatible with 1.26 in my Fear System thread.

Thanks for the kind words!
I totally get the frustration, I'm really glad RFS came across as a breath of fresh air for you.
Definitely take your time to test it thoroughly—I'd love to hear any feedback or edge cases you might uncover.
If it ends up working better for your needs, it’d be an honor to have it take the torch forward.
Big thanks to you—without your version, I wouldn't have been inspired to make this one in the first place!

This is from a quick glance at the code, but is there a way for RFS to allow different special effects being used for showing fear from different sources? (There's no sfx editing in the example)

My version allows different effects to be shown to indicate under effect of fear, allowing different spells to show different fear effect. I think it would be a great addition, not mandatory though.

Can't promise much right now, but a compatibility script to help people transfer from mine to yours will be on my list since this is VERY promising for me.

 

[Rheiko]

This is from a quick glance at the code, but is there a way for RFS to allow different special effects being used for showing fear from different sources? (There's no sfx editing in the example)

My version allows different effects to be shown to indicate under effect of fear, allowing different spells to show different fear effect. I think it would be a great addition, not mandatory though.

Unfortunately, there is none at the moment. Although, it is definitely possible to be added. My main concern was the special effects piling up even though it's coming from the same fear mechanic.

I planned to allow user to define their own fear type, so they can have multiple fear effects on a unit. Is it really necessary, though? since the effects will be all the same, I scraped the idea. I mean they are just gonna move around uncontrollably.
But I guess it's fine to have different spell show different fear effect.

 

[Daffa]

Unfortunately, there is none at the moment. Although, it is definitely possible to be added. My main concern was the special effects piling up even though it's coming from the same fear mechanic.

I planned to allow user to define their own fear type, so they can have multiple fear effects on a unit. Is it really necessary, though? since the effects will be all the same, I scraped the idea. I mean they are just gonna move around uncontrollably.
But I guess it's fine to have different spell show different fear effect.

Yeah, it is preference so I don't really mind it not being added

I just mentioned it so at least the matter exists. Fear Types would be very excessive in my opinion, though Dota 2 technically has fear types with different fear behaviors, but that's another beast to handle

 

[Rheiko]

I just mentioned it so at least the matter exists. Fear Types would be very excessive in my opinion, though Dota 2 technically has fear types with different fear behaviors, but that's another beast to handle

Oh really? I need to check that out. I'm not up-to-date with games these days.

Honestly, I was just trying to avoid excessive special effects to keep the system's performance high (although special effect shouldn't be that much of a problem). I think fear type could solve that since each type could have different special effect and it makes more sense that way.

I'll see what I can do.

 

[Rheiko]

Bumped the thread for a minor update per @Daffa 's suggestion

Updated to v1.0.1

• Typing -debug now has a message feedback.
• Fixed revive unit trigger did not revive units properly for the testmap.
• Added two new optional parameters: RFS_Param_SfxModel & RFS_Param_AttachPoint.
  • Users can now modify the model file and its attachment point directly without needing to change the system's config. Newer effect will replace older effect. These parameters are optional, meaning if they are not used when you ApplyFear, the system will automatically use RFS_SfxModelDefault and RFS_AttachPointDefault (can be configured as well).
• Updated some of the example triggers to feature new parameters.

I am very fond of this system the way it is right now, so I have decided to avoid adding fear type for the time being. I will probably do so in the future and perhaps in a different resource. Only time will tell.

 

[Antares]

Do the functions need the Trig_ prefix? They seem unnecessary as you're not adding the callbacks to the triggers with GUI.

The method of disabling the order overwrite trigger is a bit slow and needlessly convoluted. It would be easier to just disable the trigger, issue the command, then enable it again. The trigger can also be optimized. There should be an early return if isTerrified != 1 and all variables not needed at that point should be retrieved afterwards.

These are minor issues though. The system is working as intended and is easy-to-use.

Approved

 

[Rheiko]

Thanks for the approval!

Do the functions need the Trig_ prefix? They seem unnecessary as you're not adding the callbacks to the triggers with GUI.

Nein! They are completely unnecessary! It's just something I learned from Dr Super Good. I read his code and found it funny but made me want to try it myself so I did.

It would be easier to just disable the trigger, issue the command, then enable it again.

But if a user accidentally made a trigger that could catch the order and order them to move, it would possibly cause an infinite loop and crash. I wouldn't be able to disable their trigger because I wouldn't have known which one it could be.
Yeah, it works. I'm dumb.

all variables not needed at that point should be retrieved afterwards.

I don't really get this. Could you elaborate?

 

[Antares]

I don't really get this. Could you elaborate?

function Trig_RFS_Order_Actions takes nothing returns boolean
    //-- Local variables
    local real x
    local real y

    //-- GetIssuedOrderId
    local integer oId = GetIssuedOrderId()

    //-- Get the unit and its id
    local unit u = GetOrderedUnit()
    local integer uId = GetHandleId(u)

    //-- Load unit's current flag (IsTerrified)
    local integer isTerrified = LoadInteger(udg_RFS_Table, uId, 0)

    //-- Load unit's current flag (IsOrdered)
    local integer isOrdered = LoadInteger(udg_RFS_Table, uId, 5)

    if isTerrified == 1 and oId != 851973 then
        //...

The case isTerrified == 0 will be true 99% of the time, so it makes sense to optimize the function as much as possible for that case. However, if the unit is not terrified, the call to get the issued order id and isOrdered flag is wasted. How you want to structure such a function is as such:

//Get everything needed for guard 1
if not guard1 then
    return
end

//Get everything needed for guard 2
if not guard2 then
    return
end

//Code

So, in this specific case, it would be:

function Trig_RFS_Order_Actions takes nothing returns boolean
    //-- Local variables
    local real x
    local real y

    //-- Get the unit and its id
    local unit u = GetOrderedUnit()
    local integer uId = GetHandleId(u)

    //-- Load unit's current flag (IsTerrified)
    local integer isTerrified = LoadInteger(udg_RFS_Table, uId, 0)

    if isTerrified == 0 then
        set u = null
        return false
    endif

    //-- GetIssuedOrderId
    local integer oId = GetIssuedOrderId()

    if oId == 851973 then
        set u = null
        return
    endif

    //-- Load unit's current flag (IsOrdered)
    local integer isOrdered = LoadInteger(udg_RFS_Table, uId, 5)

    //...

 

[Rheiko]

Ah, sure. I see what you mean now. Got it.
This isn't Lua btw, can only declare local on top

 

[Antares]

This isn't Lua btw, can only declare local on top

 

[Rheiko]

Another minor update to optimize the code per @Antares suggestion, big thanks.

Updated to v1.0.2

• Code Optimization