Random Discussion

[Rheiko]

Discuss random things here


guys, i did it!!
my very first jass spell! (well actually it is a simple spell. cast a spell => special effect => deals damage = > done)
check out the code :3

Code

function Trig_War_Stomp_Conditions takes nothing returns boolean
   if (GetSpellAbilityId() == 'AHca')
endfunction

function Trig_War_Stomp_Actions takes nothing returns nothing
   local unit a = GetTriggerUnit()
   local unit b = GetSpellTargetUnit()
   local string c = "Abilities\\Spells\\Human\\ThunderClap\\ThunderClapCaster.mdl"
   local real x = GetUnitX(b)
   local real y = GetUnitY(b)
   call DestroyEffect(AddSpecialEffect(c, x, y))
   call UnitDamageTarget(a, b, 30, true, false, ATTACK_TYPE_CHAOS, DAMAGE_TYPE_COLD, null)
   set a = null
   set b = null
endfunction

//===========================================================================
function InitTrig_War_Stomp takes nothing returns nothing
    set gg_trg_War_Stomp = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(gg_trg_War_Stomp, EVENT_PLAYER_UNIT_SPELL_EFFECT)
    call TriggerAddAction(gg_trg_War_Stomp, function Trig_War_Stomp_Actions)
    call TriggerAddCondition(gg_trg_War_Stomp, function Trig_War_Stomp_Conditions)
endfunction

 

[FUJI]

function Trig_War_Stomp_Conditions takes nothing returns boolean
   if (GetSpellAbilityId() == 'AHca') then
   return TRUE
   endif
   return FALSE
endfunction

Inefficient :/

function Trig_War_Stomp_Conditions takes nothing returns boolean
   if GetSpellAbilityId() == 'AHca'
endfunction

Efficient =))

   local real x = GetUnitX(b)
   local real y = GetUnitY(b)

Slower :/

   local real x = GetWidgetX(b)
   local real y = GetWidgetY(b)

Faster =))

set gg_trg_War_Stomp = CreateTrigger()

(

local trigger t = CreateTrigger()

Yey! XD

local string c = "Abilities\\Spells\\Human\\ThunderClap\\ThunderClapCaster.mdl" and 'AHca'

://

// This can be used in vJASS but I don't know if it is accesible in JASS :((
globals
    constant integer ABILITY_RAW_CODE_OR_ID_XD = 'AHca'
    constant string YOUR_SPECIAL_EFFECT = "Abilities\\Spells\\Human\\ThunderClap\\ThunderClapCaster.mdl"
endglobals
// If you want JASS then write a function that returns a value like:
constant function ABILITY_CODE takes nothing returns integer // Ability_Raw_Code is integer
    return 'AHca'
endfunction
// Then so on..

Nice!

remember that if you call a function then you must call it like this: call ABILITY_CODE() // calls a function
the "()" thing is the function what it takes, example: if you want the function to takes integer level then write it in takes part.
After you call it like this: call DAMAGE(lvl) // calls a function and it takes integer parameters

EDIT:
I forgot to add these constant that you must add:
ATTACK_TYPE_CHAOS, DAMAGE_TYPE_COLD

 

[Rheiko]

okay
thanks ^^

 

[Rheiko]

someone said GetUnitX/Y is faster than GetWidgetX/Y, which one is true? :/
https://www.hiveworkshop.com/forums/lab-715/getunitx-y-vs-getwidgetx-y-243449/
https://www.hiveworkshop.com/forums/jass-resources-412/snippet-item-position-184566/

 

[Rheiko]

what is constant for?

[offtopic]triple posts, lol[/offtopic]

edit: nah, i forgot this is not w3m.. lol

 

[FUJI]

Lol I don't know which one is faster, but Malhorne spread said that GetWidget.. is faster than GetUnitX, XDD so I think Bribe, Nestharus agreed that GetUnitX is faster .
Constant is the value of which can never change

 

[FUJI]

Anyway welcome to magic JASS!

 

[Rheiko]

for just a simple spell like this, i still make so many flaws

so jass is a magic now? =P

 

[FUJI]

no vJASS is better

 

[Malhorne]

function Trig_War_Stomp_Conditions takes nothing returns boolean
   local unit a
   local unit b
   local real x
   local real y
   if GetSpellAbilityId() == 'Ahca' then
      set a = GetTriggerUnit()
      set b = GetSpellTargetUnit()
      set x = GetUnitX(b)
      set y = GetUnitY(b)
      call DestroyEffect(AddSpecialEffect("Abilities\\Spells\\Human\\ThunderClap\\ThunderClapCaster.mdl", x, y))
      call UnitDamageTarget(a, b, 30, true, false, ATTACK_TYPE_CHAOS, DAMAGE_TYPE_COLD, null)
      set a = null
      set b = null
   endif
   return false
endfunction

//===========================================================================
function InitTrig_War_Stomp takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_SPELL_EFFECT)
    call TriggerAddCondition(t, Condition(function Trig_War_Stomp_Conditions))
    set t = null
endfunction

 

[Rheiko]

thanks for fixing it malhorne :3

 

[Malhorne]

You're welcome dude
I didn't talk about my magic trick of conditions inside my tutorial ^^
It will be in my pro trick

 

[chobibo]

Faster =))

Jass:
set gg_trg_War_Stomp = CreateTrigger()
(
Jass:
local trigger t = CreateTrigger()

NO. It wastes a reference. (gg_trg_War_Stomp)

function Trig_War_Stomp_Conditions takes nothing returns boolean
   local unit a
   local unit b
   local real x
   local real y
   if GetSpellAbilityId() == 'Ahca' then
      set a = GetTriggerUnit()
      set b = GetSpellTargetUnit()
      set x = GetWidgetX(b)
      set y = GetWidgetY(b)
      call DestroyEffect(AddSpecialEffect("Abilities\\Spells\\Human\\ThunderClap\\ThunderClapCaster.mdl", x, y))
      call UnitDamageTarget(a, b, 30, true, false, ATTACK_TYPE_CHAOS, DAMAGE_TYPE_COLD, null)
      set a = null
      set b = null
   endif
   return false
endfunction

//===========================================================================
function InitTrig_War_Stomp takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_SPELL_EFFECT)
    call TriggerAddCondition(t, Condition(function Trig_War_Stomp_Conditions))
    set t = null
endfunction

Pointless optimization. Use for dynamic triggers.

It will be in my pro trick

It's not, it's a fucking hack.

Okay, cohadar mode disabled.

 

[Malhorne]

Ahah !
For the local trigger it is reference yes ^^
But there speed difference if I remember well between globals and locals :/

It is not really a fucking hack since actions leak

 

[chobibo]

Actions don't leak dude, triggeraction do when you destroy the trigger it is attached to, and it causes handle corruption too. The point is if you're not destroying the trigger, the triggeraction won't leak because it's in use.

It's really a hack, Vexorian was experementing with dynamic triggers when he discovered that triggerconditions were safer to use than triggeractions on dynamic triggers. It is indeed faster than triggeractions on execution because it doesn't create a seperate thread when the event fires, unlike the triggeraction which does, but you can't make the triggercondition sleep. (thread skipping)

 

[Malhorne]

type triggercondition   extends     agent

type triggeraction      extends     handle

One extends agent the other handle.
Agent are way safer since they don't need to be nulled whereas handle needs to.

 

[chobibo]

type agent extends handle

fuck that. Handles are agents.

 

[Malhorne]

So why there is only a bug with handle oO ?
Holy shit ^^'

 

[chobibo]

Which bug?

 

[Malhorne]

That any handle have to be nulled while agent not ^^'

 

[chobibo]

type group extends agent

Who taught you that bullshit?

 

[Malhorne]

Don't know xD !
Maybe I misunderstood something :/

 

[chobibo]

Sup guys, looks like today is a busy day for everyone, I hope your all fine and dandy.

 

[FUJI]

^Yeah I'm busy making spell in JASS XD

 

[chobibo]

XD I thought you were learning vjass? Anyway, good luck with your jass spells.

 

[Malhorne]

I just woke up one hour ago

 

[defskull]

GetWidget vs GetUnit.

Maker told me that the speed is indeed negligible, therefore you can use either one without feeling bad about it.

 

[chobibo]

It's not negligible, Maker did a benchmark in this post. Unless you think a 10 fps lost is negligible.

 

[Malhorne]

Yes we have to use GetUnitX > GetWidgetX > GetItemX

 

[chobibo]

Yo guys, new addition to warcraft 3 modding, jaws and vjaws. I have a request Malhorne, can you change my request type to jaws/vjaws? please I beg you. xD kidding.

 

[Malhorne]

Okay I'll change this on mine and yours

 

[Paliouras]

Vjaws?

 

[Malhorne]

I DIT IT xD

 

[Malhorne]

Just Another Weird Syntax
Instead of
Just Another Scripting Syntax

 

[chobibo]

<-- coconut likes that, coconut say thanks, Yuno Barry, you cool! like coconut!

KEWL!

 

[Paliouras]

You aint a coconut.I think.

 

[Malhorne]

Ya I'm KEWL like coconut oh ye

 

[chobibo]

What the fuck, why is this group so quiet? I'm going COCONUTS!

 

[Malhorne]

Ahah ^^'
I'll be more active when I'll finish those exams~

 

[chobibo]

I was just kidding Malhorne. T_T

 

[Malhorne]

No problem dude I wasn't mad at all

 

[GreeN!X]

Just a little suggestion guys, what if we make some little template map so that we would have some uniformity? We could import one DDS in one map so that if one of us makes a spell with a specific DDS, we could just pick the one with the DDS and make the spell for it. No more hassle importing for the DDS.

I dunno, Just a thought from me.

 

[Malhorne]

I didn't understand what you want to say xD

EDIT : NVM -> There is so many DDS and we can say that we prefer GDD but take everything.
Guys who are using Nes DDS are often good at coding.

 

[chobibo]

That sounds nice!
@Malhorne, people good at coding would just make their own systems lol, kinda like you.

 

[Malhorne]

Ahah I don't like programming DDS I use GDD or StructuredDD (Love this one)

 

[chobibo]

What's structuredDD?

 

[Malhorne]

A library written by CokeMonkey
I luv his coding style I learned many many things from him (like dynamic indexing with structs/how to instanciate missile ect...)

 

[chobibo]

Linkzorz plox!

 

[Malhorne]

https://www.hiveworkshop.com/forums...uctureddd-structured-damage-detection-216968/

 

[chobibo]

Thanks man!