[JASS] Problem with redirecting spells

[Josemite]

I'm trying to set up a trigger so if a unit targets a certain unit for a spell, the target of that spell changes to another unit. The problem is that it doesn't work with spells (but it does work with attack). So basically the problem is that the redirected spell fails to cast successfully.

Here's the part of the code that is supposed to redirect the spell

call IssueImmediateOrder(u, "stop")
        call PolledWait2(0.1)
        call IssueImmediateOrder(u, "spellbook")
        call SetUnitAnimation(u, "stand")
        call PolledWait2(0.1)
        call IssueTargetOrderById(u, o, udg_Heroes[i])

and here's the whole function

function Order_Action takes nothing returns nothing
    local unit u = GetOrderedUnit()
    local unit t = GetOrderTargetUnit()
    local integer i = 0
    local integer j = GetPlayerId(GetOwningPlayer(u))
    local integer o = GetIssuedOrderId()
    
    if (u != t and GetOwningPlayer(u) == GetOwningPlayer(t) and GetUnitTypeId(t) != 'h00Q' and GetUnitTypeId(u)!='h00Q') then
        loop 
            exitwhen i>9 or t == PFArr[j*10+i]
            set i = i+1
        endloop
        call IssueImmediateOrder(u, "stop")
        call PolledWait2(0.1)
        call IssueImmediateOrder(u, "spellbook")
        call SetUnitAnimation(u, "stand")
        call PolledWait2(0.1)
        call IssueTargetOrderById(u, o, udg_Heroes[i])
    endif
    set u = null
    set t = null
endfunction

 

[Josemite]

oh, one note, all the spells are inside, so part of the problem could be ordering units to cast spells that are in spell books... (the only part that isn't working is that the new spell is failing to successfully cast. I've tried ordering the unit to open the spellbook first, but that doesn't seem to be working, and the spell book is already open...)

 

[Alkonis]

Perhaps the polled wait disrupts things. Maybe add another local at the beginning:

local integer id = GetIssuedOrderId()

Then, use:

call IssueTargetOrderById(u, id, udg_Heroes[i])

See if that helps any.

By the way, edit instead of double-posting.

 

[Josemite]

Yeah sorry for the double post.... I edited the top post to be updated. I tried saving it to a local variable but that didn't help (though I doubt it'd work without saving it)

 

[Alkonis]

Add a condition function to this:

function bla takes nothing returns boolean
    return GetIssuedOrderId() != OrderId("stop") //I don't know teh order Id off the top of my head.  This'll work, but if you know the OrderId, use it insteaed.
endfunction

Right now, it's ordering it to stop every time it stops. Maybe that'll fix it?

Edit: Or maybe not. You can probably ignore that... v.v Can you tell me what kind of events/conditions you already have?

 

[Josemite]

It's an EVENT_PLAYER_UNIT_ISSUED_TARGET_ORDER, no conditions. So that shouldn't be the problem

 

[Alkonis]

Uhhh... No, that is your problem. When it does this:

call IssueTargetOrderById(u, o, udg_Heroes[i])

It fires function Order_Actions and it causes the unit to stop. ...Or is that what those other conditions are for?

 

[Josemite]

yeah, the other function basically check to make sure the targeted unit is the dummy unit (a unit that is owned by the same player) and then redirects the casted spell at a different hero (owned by a different player stored in the heroes array) so the

GetOwningPlayer(u) == GetOwningPlayer(t)

part fails