Mortal Strike v0.02a

[Moderator]

17:49, 17th Nov 2012
Magtheridon96: Approved.
Code looks good and clean, and there are plenty of configurables. Well done.

 

[doomhammer99]

EDIT: CREDITS TO ME

Ok your coding are clean and well.

My Suggestions

But Instead off using to triggers, you can use 1 triggers at once like this:
Add & Destroy Effects:

• Custom script: call DestroyEffect(AddSpecialEffectTarget(udg_YourSFX, udg_YourUnit, udg_YourAttachment))

You can move a unit by using this, this is the fastest and cleaner way

• Custom script: call SetUnitX(udg_YourUnit,GetUnitX(udg_YourUnit) + udg_YourOffset/Speed * Cos(udg_YourAngle * bj_DEGTORAD))
• Custom script: call SetUnitY(udg_YourUnit,GetUnitY(udg_YourUnit) + udg_YourOffset/Speed * Sin(udg_YourAngle * bj_DEGTORAD))

As you can see above, they're not similar. The 1st SetUnitX and the 2nd is SetUnitY .
Instead of Putting this:

• Else - Actions
• Unit - Turn collision for MoS_Caster[MoS_Current_Index] On
• Animation - Change MoS_Caster[MoS_Current_Index]'s animation speed to 100.00% of its original speed
• Animation - Reset MoS_Caster[MoS_Current_Index]'s animation
• Special Effect - Destroy MoS_SE_1[MoS_Current_Index]
• Special Effect - Destroy MoS_SE_2[MoS_Current_Index]
• Special Effect - Destroy MoS_SE_3[MoS_Current_Index]
• Special Effect - Destroy MoS_SE_4[MoS_Current_Index]
• Set MoS_Index_Listener = (MoS_Index_Listener - 1)
• Set MoS_Index_Container[MoS_Loop] = MoS_Index_Container[MoS_Index_Listener]
• Set MoS_Recycle_Container[MoS_Recycle_Size] = MoS_Current_Index
• Set MoS_Recycle_Size = (MoS_Recycle_Size + 1)
• Set MoS_Loop = (MoS_Loop - 1)
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)

You can just do this:

• Animation - Reset MoS_Caster[MoS_Current_Index]'s animation
• Special Effect - Destroy MoS_SE_1[MoS_Current_Index]
• Special Effect - Destroy MoS_SE_2[MoS_Current_Index]
• Special Effect - Destroy MoS_SE_3[MoS_Current_Index]
• Special Effect - Destroy MoS_SE_4[MoS_Current_Index]
• Set MoS_Timer[udg_MoS_Index] = 0.00

You don't really need this, It's only for the Rarity of the Animation

• Animation - Reset MoS_Caster[MoS_Current_Index]'s animation

Instead of using this:

• Animation - Change MoS_Caster[MoS_Current_Index]'s animation speed to 100.00% of its original speed

You can use This:

• Custom script: call SetUnitTimeScale( udg_MoS_Caster[udg_MoS_Index], udg_MoS_AnimSpeed / 100.)

and the 100.00% must be Configurable.

Spell Resource Rating System by doomhammer99

Note: 5 is the highest point that can be given, and 1 is the lowest.

Documentation: - Triggering: 4 Idea: 5 Usefulness: 3 Overall Aspects: 3

Overall Rating: 3

Rating Comment: Useful[r] Changes will be made Until Update

 

[BUP]

doomhammer99,,thanks for advising the faster way with custom scripts..
But I'm having problems with the moving thing,,you can check it out in the attachment.
The spin animation stops how should i fix that??

 

[doomhammer99]

doomhammer99,,thanks for advising the faster way with custom scripts..
But I'm having problems with the moving thing,,you can check it out in the attachment.
The spin animation stops how should i fix that??

Ok Wait up

 

[ThisPOT]

0.03 millisecond = 0.00003 lol ;O

its 0.03 second

Cool spell tho

 

[BUP]

Doom,i've fixed the animation i'll update this later

 

[GaAg0]

Nice magic i love it testing it

 

[BUP]

Nice magic i love it testing it

Thank you!!

 

[john2_gadi]

Found an Error! Please fix this!

When I cast it looks very fine. But as I am testing the ability I see something which really unusual when the unit cast/activate the spell when its time for the final blow it damages itself.. or (200 Damage for Enemy/Targeted Unit and 200 Damage to Self??


but this is a good spell idea...just fix the self damage. 3/5