Lasso

[Moderator]

12th Dec 2015
IcemanBo: For too long time as NeedsFix. Rejected.

19th Jul 2011
Bribe:

Review

(Position of (Target unit of ability being cast)) -> (Target point of ability being cast)

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • Lasso_Distance[Dynamic_Index] Greater than or equal to 300.00
  • Then - Actions
    • Set Lasso_PullOn[Dynamic_Index] = true
  • Else - Actions
    • Set Lasso_PullOn[Dynamic_Index] = false

Does GUI not let you do something like this?:

Set Lasso_PullOn[Dynamic_Index] = Lasso_Distance[Dynamic_Index] Greater than or equal to 300.00

If you examine your code carefully, you will notice that sometimes
"Lasso_TargetLoc" will be set multiple times before the location
can be removed.

The casting trigger is disable by default, check it.

 

[Justify]

What happens when a unit had crow form as a real skill? What happens when a unit gains invulnerability in time? Just two things I saw so far

 

[Magtheridon96]

What happens when a unit had crow form as a real skill?

That shouldn't be a problem actually. We always add and remove crow form to a unit if we want it to have a "fly height"

 

[Justify]

That shouldn't be a problem actually. We always add and remove crow form to a unit if we want it to have a "fly height"

No. If done correctly you check if the unit had crow form already because it would bug otherwhise AND you don't even need to add it.

 

[Magtheridon96]

No. If done correctly you check if the unit had crow form already because it would bug otherwhise AND you don't even need to add it.

It never caused problems in the past.
It shouldn't cause problems here.
If we add crow form to a unit then remove it, if it already had crow form, nothing would bug. Check out "Autofly" by Nestharus. There's another one by azlier at The Helper.

 

[Justify]

It never caused problems in the past.
It shouldn't cause problems here.
If we add crow form to a unit then remove it, if it already had crow form, nothing would bug. Check out "Autofly" by Nestharus. There's another one by azlier at The Helper.

Removing an ability is not a problem? For sure this only happens with the original crow form but a single check is worth this.
If the original crow form is used for a unit, adding does nothing and removing will cause crow form to be removed.

 

[Magtheridon96]

The solution is to use a custom morph ability instead of 'Arav'/'Amrf'

 

[timothyhuth]

yhislooks like its just the Aerial Shackles

 

[Adiktuz]

yeah, Adding/removing can cause error if the unit has a crow form on the OE... which is fixable by replacing the Add/Remove actions with this...

• Custom script: if UnitAddAbility(blahblah) then
• Custom script: call UnitRemoveAbility(blahblah)
• Custom script: endif

 

[.OmG.]

Do you really need giant empty test map?

 

[Vorgh]

The spell can only target ground units so if the target already has crow form it can't be the target. And the test map, yeah I will create a new one.

 

[Adiktuz]

Then its a bad spell, spells submitted here are supposed to be able to support any target that the user wants...

 

[Vorgh]

I created a custom crow form so it doesn't cause bugs anymore. Also I'm working on the air unit support. I will update in 30 min.

Updated: Now can target air units, fixed some bugs in the throw part when the unit flies above a lower terrain and now destroys trees when the target lands.

 

[Magtheridon96]

Here's your BEST solution:

if UnitAddAbility(unit,'Arav') then
    call UnitRemoveAbility(unit,'Arav')
endif

 

[Vorgh]

Here's your BEST solution:

if UnitAddAbility(unit,'Arav') then
    call UnitRemoveAbility(unit,'Arav')
endif

Changed, thanks.

 

[Vorgh]

(Position of (Target unit of ability being cast)) -> (Target point of ability being cast)

Changed.

Does GUI not let you do something like this?:

Set Lasso_PullOn[Dynamic_Index] = Lasso_Distance[Dynamic_Index] Greater than or equal to 300.00

No, it doesn't.

If you examine your code carefully, you will notice that sometimes
"Lasso_TargetLoc" will be set multiple times before the location
can be removed.

Can't find it. It can't be set twice at the same unit in the loop.

 

[Adiktuz]

I believe GUI lets you do that, just make sure that Lasso_PullOn[Dynamic_Index] is a boolean and Lasso_Distance[Dynamic_Index] is a real...