[Solved] Kill and Replace...

[mckill2009]

SOLVED!


The ReplaceUnitBJ function has so many callings, now in order to simplify this, it can be...

local unit tar = LoadUnitHandle(udg_HASH, metkey, 2)
local unit newunit
call UnitApplyTimedLife(tar, 'BTLF', 0.03)
call ShowUnit(tar, false) //Is this necessary?...
call RemoveUnit(tar)
if random==1 then
   set newunit = CreateUnit(GetOwningPlayer(tar), MET_WARLOCK(), GetUnitX(tar), GetUnitY(tar), 0)   
endif

Now forget about the 'random' coz its in another function...also forget about the statelife and mana coz Im not applying it yet...

My questions are;
1. Does the RemoveUnit leak?...
2. What's the use of bj_lastReplacedUnit?...
3. Is this the simplified setup?, well I know that there's better...

 

[Garfield1337]

1. According to some people, yes. To clear it, you would need to explode the unit instead of removing it ExplodeUnitBJ
2. It's a global variable that gets the replaced unit assigned as value after ReplaceUnitBJ
3. I'm not sure what you mean but your example wouldn't work since you're removing the old unit and then trying to retrieve it's owner and coordinates; you have to save those values before removing the unit.

 

[mckill2009]

1. Ok, when exploding, does it play it's death animation? coz if it does
then it's no good...ReplaceUnitBJ has also "call RemoveUnit(oldUnit)",
but before that, it kills the old unit first...

3. The 'saving' was already done in another function so no need to worry
about it and I already tested and it worked, as you can see, I already
Load the 'tar' unit...

 

[Garfield1337]

1. Ok, when exploding, does it play it's death animation? coz if it does
then it's no good...ReplaceUnitBJ has also "call RemoveUnit(oldUnit)",
but before that, it kills the old unit first...

I'm not sure if exploding the unit causes it to play some animation; test it and if it does, you can hide it first then explode it.

3. The 'saving' was already done in another function so no need to worry
about it and I already tested and it worked, as you can see, I already
Load the 'tar' unit...

If you assign a unit to a variable, it will just point to that unit so if the unit is removed, you can't retrieve it's information.
Are you sure that your trigger worked?
Just tested it and strangely it worked ;o

 

[mckill2009]

Yeah, put the ShowUnit(tar, false) then explode...unfortunately I cant rep
you coz I must spread it first, My bad ...thanks anyway...

Problem SOLVED!

 

[Dr Super Good]

Be aware when replacing units that the new unit starts with initial values so could ultimatly gain life and lose/gain mana. It will also lose all earned tomes and stat mods, speed mods, buffs, and abilities.

 

[Bribe]

ReplaceUnitBJ also doesn't factor in Get/SetUnitFlyHeight. You might be able to hide any "explode" art by setting the unit's scale to 0. The RemoveUnit leak is also questionable and needs to be better tested because the problem could have been fixed in recent patches.