[JASS] Itempool help

[thedragiin]

Im new to Jass. Im trying to make a simple trigger where when any unit owned by brown player dies it has a 20% chance to drop an item, of which can be one of the three stat increasing tome (tdex, tint, tstr). So I half GUI half Jass'd this:

function Trig_ItemDrops_Conditions takes nothing returns boolean
    if ( not ( GetOwningPlayer(GetDyingUnit()) == Player(11) ) ) then
        return false
    endif
    return true
endfunction

function Condtionz takes integer i returns boolean
    if i > 21 then
        return false
    endif
    return true
endfunction

function Trig_ItemDrops_Actions takes nothing returns nothing
    local itempool ip
    local item i
    local integer chance
    call ItemPoolAddItemType(ip, 'tdex', 1)
    call ItemPoolAddItemType(ip, 'tint', 1)
    call ItemPoolAddItemType(ip, 'tstr', 1)
    set chance = GetRandomInt(0, 100)
    if ( Condtionz(chance) ) then
        call PlaceRandomItem(ip, GetLocationX(GetUnitLoc(GetDyingUnit())), GetLocationY(GetUnitLoc(GetDyingUnit())))
    else
    endif
endfunction

//===========================================================================
function InitTrig_ItemDrops takes nothing returns nothing
    set gg_trg_ItemDrops = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_ItemDrops, EVENT_PLAYER_UNIT_DEATH )
    call TriggerAddCondition( gg_trg_ItemDrops, Condition( function Trig_ItemDrops_Conditions ) )
    call TriggerAddAction( gg_trg_ItemDrops, function Trig_ItemDrops_Actions )
endfunction

So, uh, whats wrong with it.

 

[PurplePoot]

local itempool ip = CreateItemPool()

And then destroy it later.

 

[SanKakU]

had you checked out that item pool tutorial? http://www.hiveworkshop.com/forums/f280/itempools-guide-35180/ i've been using that, works good. yeah i hope yours does too.

 

[Ciebron]

i would recommend using Vjass for this one using a globals itempool would be much much efficent

library ItemDrops initializer init

globals
    itempool IP = CreateItemPool()
endglobals

private function Actions takes nothing returns nothing
    local unit u = GetTriggerUnit()
    local P = GetOwningPlayer(u)
    local integer chance
    
    if P == Player(11) then

        set chance = GetRandomInt(0, 100)

        if chance <= 20 then then
            call PlaceRandomItem(ip,GetUnitX(u),GetUnitY(u))
        endif

    endif

    set P = null
    set u = null
endfunction

//===========================================================================
private function init takes nothing returns nothing
    local trigger trig = CreateTrigger( )
    call TriggerRegisterAnyUnitEventBJ(trig, EVENT_PLAYER_UNIT_DEATH )
    call TriggerAddCondition(trig, Condition( function Actions ) )
    
    
    call ItemPoolAddItemType(IP, 'tdex', .33)
    call ItemPoolAddItemType(IP, 'tint', .33) //the total value of these much be 1 else it can create 0 items
    call ItemPoolAddItemType(IP, 'tstr', .34)

    set trig = null
endfunction

endlibrary