[Trigger] is spell target/no target/point

[ShaDowPoWeR]

I made this but I'm not sure if it's 100% correct, is there an easier way to check if a skill is target/no target/point ?
for some reason thunder clap has a target unit but invalid point while some other no target skills don't have either target or point, the target skills I tested have both target and point so I arranged the triggers this way so that it's more correct. I only tested a few abilities though. I also could check with orders but it seems a bit too excessive.
I know that the location leaks, I'm gonna turn it into jass later so if there is a relevant jass only function please tell me.

• Starting Trigger
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
  • Actions
    • Set p = (Target point of ability being cast)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (X of p) Not equal to 0.00
        • (Y of p) Not equal to 0.00
      • Then - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Target unit of ability being cast) Not equal to No unit
          • Then - Actions
            • Game - Display to (All players) the text: target
          • Else - Actions
            • Game - Display to (All players) the text: point
      • Else - Actions
        • Game - Display to (All players) the text: not point

 

[MyPad]

My suggestion is to use issued order events, to track whether an order is immediate, point, or target-oriented. On spell cast, get unit's current order, and infer the type of targeting from the order mapped in the immediate, point or target-oriented trigger.

 

[ShaDowPoWeR]

I guess orders it is, my system didn't work well with some auto casted spells but it works ok with orders.

 

[Bribe]

You have to use some JASS but you can do it without orders:

If the target unit is null, check if GetSpellTargetLoc is null (you'll have to remove it if not).

 

[Lord_Earthfire]

A little trick, if you want to check for a unit targeted spell only is to check if the target unit of ability being cast is alive. It will return false in that case. But if you want to differentiate between point casted/no target spell, i would stick to bribe's approach.

 

[Bribe]

A little trick, if you want to check for a unit targeted spell only is to check if the target unit of ability being cast is alive. It will return false in that case. But if you want to differentiate between point casted/no target spell, i would stick to bribe's approach.

That's completely unnecessary to check if the target is alive and, under the hood, creates more work for the game engine. Checking if the spell target is equal to "no unit" is best and even more accurate.

 

[ShaDowPoWeR]

there is a problem with GetSpellTargetLoc, sometimes it returns even if it's "null" (xy = 0,0) so I'm using getLocationX/Y and it works. also some no target spells like thunderclap return a target unit but target spells always have a non xy 0,0 location so my conclusion is:
valid X/Y+unit = target
0,0 XY+unit = no target
point+nounit = point