[Trigger] how do i fix this leak i have read the leak sticy i didnt get it......

[ace992]

well i am getting leaks from units being spwned and i read how to fix it but it didnt work so i think i dont get it and stuffed it up some were pleaze help me


thanx for help in advance

 

[Dr Super Good]

Your leaking locations, you need to store the locations in a point variable and then remove them. I might be able to help you more if you acually converted your trigger to text and used our handy GUI trigger tags but since you did it the horribly difficult and innefficent way. . .

Under one of the menues it should have copy trigger as text, use that instead of screenshots.

 

[ace992]

• Events
  • Time - Every 35.00 seconds of game time
• Conditions
• Actions
  • For each (Integer A) from 1 to 1, do (Unit - Create 5 Ghoul for Player 11 (Dark Green) at (Center of Holding 2 <gen>) facing (Random point in Holding 2 <gen>))
  • For each (Integer A) from 1 to 1, do (Unit - Create 4 Crypt Fiend for Player 11 (Dark Green) at (Center of Holding 2 <gen>) facing (Random point in Holding 2 <gen>))
  • For each (Integer A) from 1 to 1, do (Unit - Create 2 Necromancer for Player 11 (Dark Green) at (Center of Holding 2 <gen>) facing (Random point in Holding 2 <gen>))
  • For each (Integer A) from 1 to 1, do (Unit - Create 1 Champion for Player 11 (Dark Green) at (Center of Holding 2 <gen>) facing (Random point in Holding 2 <gen>))
  • Set groupundead = (Units in Camp 2 <gen>)
  • Unit Group - Pick every unit in (Units in Camp 2 <gen>) and do (Unit - Hide (Picked unit))
  • Custom script: call DestroyGroup(udg_groupundead)

• Events
  • Time - Every 35.00 seconds of game time
• Conditions
• Actions
  • For each (Integer A) from 1 to 1, do (Unit - Create 5 Footman for Player 12 (Brown) at (Center of Holding <gen>) facing (Random point in Holding <gen>))
  • For each (Integer A) from 1 to 1, do (Unit - Create 4 Rifleman for Player 12 (Brown) at (Center of Holding <gen>) facing (Random point in Holding <gen>))
  • For each (Integer A) from 1 to 1, do (Unit - Create 2 Priest for Player 12 (Brown) at (Center of Holding <gen>) facing (Random point in Holding <gen>))
  • For each (Integer A) from 1 to 1, do (Unit - Create 1 Capatin Train capatin for Player 12 (Brown) at (Center of Holding <gen>) facing (Random point in Holding <gen>))
  • Set Grouphuman = (Units in camp 1 <gen>)
  • Unit Group - Pick every unit in (Units in camp 1 <gen>) and do (Unit - Hide (Picked unit))
  • Custom script: call DestroyGroup(udg_Grouphuman)

 

[Dr Super Good]

Firstly remove thoes actions that are in the loops since it is pointless doing them in the loops.
Secondly store all your locations (points) in variables and only use them from the variables and destroy them before asigning a new location (point) to the variable.
Finally do the same as you did for the points for the groups.

I recommend reading some of our leak tutorials, they can really be helpfull.

 

[ace992]

Secondly store all your locations (points) in variables and only use them from the variables and destroy them before asigning a new location (point) to the variable.
QUOTE]

umm im lost

 

[PurplePoot]

K

New variable TempPoint.

It's a variable of type Point.

Instead of

• Unit - Create 1 Footman at (...)

You would do

• Set TempPoint = (...)
• Unit - Create 1 Footman at TempPoint
• Custom script: call RemoveLocation(udg_TempPoint)

That's about as simple as it gets.

 

[ace992]

dosnt work... un its still leak(even more then what they did)
so i do not know what im doing

 

[PurplePoot]

No, that fixes the leak.

If you're still getting problems, it's because you didn't do it right -.-

Post your triggers.

 

[ace992]

• Time - Every 35.00 seconds of game time
• Set TempPoint = (Center of Holding 2 <gen>)
• Unit - Create 5 Ghoul for Player 11 (Dark Green) at TempPoint facing (Random point in Holding 2 <gen>)
• Unit - Create 4 Crypt Fiend for Player 11 (Dark Green) at TempPoint facing (Random point in Holding 2 <gen>)
• Unit - Create 4 Crypt Fiend for Player 11 (Dark Green) at TempPoint facing (Random point in Holding 2 <gen>)
• Unit - Create 5 Necromancer for Player 11 (Dark Green) at TempPoint facing (Random point in Holding 2 <gen>)
• Custom script: call RemoveLocation(udg_TempPoint)

• Time - Every 35.00 seconds of game time
• Set TempPoint = (Center of Holding <gen>)
• Unit - Create 5 Footman for Player 12 (Brown) at TempPoint facing (Random point in Holding <gen>)
• Unit - Create 4 Rifleman for Player 12 (Brown) at TempPoint facing (Random point in Holding <gen>)
• Unit - Create 1 Capatin Train capatin for Player 12 (Brown) at TempPoint facing (Random point in Holding <gen>)
• Unit - Create 2 Priest for Player 12 (Brown) at TempPoint facing (Random point in Holding <gen>)
• Custom script: call RemoveLocation(udg_TempPoint)

 

[PurplePoot]

The 'facing Random Point in Holding <gen>' is also leaking.

 

[ace992]

how do i fix that i couldent find just create unit has to be faveing a point or be in a random postion......

 

[PurplePoot]

Well

You could

A) make another Point variable and do the same as the above

B) use Facing Angle, and use (Random Real Between 0 and 360) or (Random Angle) for the random angle. (wouldn't be facing random point in region though, just around them)

 

[HamzahA]

the leak is on the region Holding, Holding2 as i think

 

[PurplePoot]

Nah, it's in the Point, as I've already said -.-

The region is preset, it's not recreated every time you reference it.