[JASS] Help With Events

[Mr_Bean]

Hi guys,

I am trying to learn more JASS, so I tried to make event scripts. Here is a simple test one:

function Test takes nothing returns nothing
    call RemoveUnit(GetTriggerUnit())
endfunction

function Trig_Test takes nothing returns nothing
    local trigger t
    set t = CreateTrigger()
    call TriggerRegisterUnitEvent(t, GetTriggerUnit(), EVENT_UNIT_SPELL_EFFECT)
    call TriggerAddAction(t, function Test)
    call DestroyTrigger(t)
    set t = null
endfunction

However, nothing happens! What am I doing wrong?

 

[mckill2009]

coz there's no GetTriggerUnit() yet...

remove this >>> call DestroyTrigger(t) and put it in the 'Test' function

this >>> Trig_Test to this >>> InitTrig_Test

 

[Garfield1337]

Just don't delete the trigger.

 

[Mr_Bean]

Okay, thanks. Now I have this:

function Test takes nothing returns nothing
    call RemoveUnit(GetTriggerUnit())
endfunction

function InitTrig_Test takes nothing returns nothing
    local trigger t
    set t = CreateTrigger()
    call TriggerRegisterUnitEvent(t, GetTriggerUnit(), EVENT_UNIT_SPELL_EFFECT)
    call TriggerAddAction(t, function Test)
endfunction

And still nothing happens. Suggestions?

 

[dudeim]

You cannot register the event to triggerunit as there is no triggerunit yet. Instead use TriggerRegisterAnyUnitEventBJ(t,EVENT_PLAYER_UNIT_SPELL_EFFECT)
The above line is freehand so it might be a little off but it's something like this.

 

[Mr_Bean]

function Test takes nothing returns nothing
    call RemoveUnit(GetBuyingUnit())
endfunction

function InitTrig_Test takes nothing returns nothing
    local trigger t
    set t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_SELL_ITEM)
    call TriggerAddAction(t, function Test)
endfunction

Still nothing. Any more ideas? :/

 

[Garfield1337]

I don't think buying unit corresponds to that event. Try GetSellingUnit() instead.

 

[Mr_Bean]

Okay. But won't selling unit refer to the shop?

 

[Garfield1337]

Test it. I think it doesn't refer to shop.
Maybe TriggerUnit() refers to shop, idk.

 

[Mr_Bean]

Ya, okay will do. I'm not at my computer now, so will let you know when I test it.

 

[cohadar]

If you are going to use jass download NewGen and learn to use scopes.
This can also help:
http://www.wc3c.net/vexorian/jasshelpermanual.html

 

[mckill2009]

selling unit refferes to the shop and replace GetSellingUnit() to GetTriggerUnit()...

if you wanna reffer it to the hero the replace the EVENT_PLAYER_UNIT_SELL_ITEM to EVENT_PLAYER_UNIT_PAWN_ITEM

 

[Dr Super Good]

local trigger t
set t = CreateTrigger()

This can be done in 1 line.

local trigger t = CreateTrigger()

More efficient to run as well.

 

[Mr_Bean]

If you are going to use jass download NewGen and learn to use scopes.
This can also help:
http://www.wc3c.net/vexorian/jasshelpermanual.html

I already know JASS, I am just trying to learn how to make events.

selling unit refferes to the shop and replace GetSellingUnit() to GetTriggerUnit()...

if you wanna reffer it to the hero the replace the EVENT_PLAYER_UNIT_SELL_ITEM to EVENT_PLAYER_UNIT_PAWN_ITEM

Won't EVENT_PLAYER_UNIT_PAWN_ITEM refer to when a unit sells an item TO a shop?

This can be done in 1 line.

More efficient to run as well.

I know this, I just copied that part from a tutorial, to make sure I wasn't doing anything wrong.

EDIT: Still nothing happens. What am I doing wrong? :/

function act_Test takes nothing returns nothing
    call RemoveUnit(GetTriggerUnit())
    call RemoveUnit(GetBuyingUnit())
endfunction

function InitTrig_Test takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_SELL_ITEM)
    call TriggerAddAction(t, function act_Test)
endfunction

Also, GetTriggerUnit() refers to the shop (just tested it).

 

[mckill2009]

Won't EVENT_PLAYER_UNIT_PAWN_ITEM refer to when a unit sells an item TO a shop?

I already explained that in post #12 "if you wanna reffer it to the hero"

Still nothing happens. What am I doing wrong?

buy an item...

 

[Mr_Bean]

buy an item...

I'm not stupid...

function act_Test takes nothing returns nothing
    call RemoveUnit(GetTriggerUnit())
    call RemoveUnit(GetBuyingUnit())
endfunction

function InitTrig_Test takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_PAWN_ITEM)
    call TriggerAddAction(t, function act_Test)
endfunction

Still nothing (EVEN WHEN I BUY AN ITEM)...

 

[mckill2009]

not that...

this >>> call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_PAWN_ITEM), the hero will be removed...

this >>> call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_SELL_ITEM), the shop will be removed...

call RemoveUnit(GetTriggerUnit()) is fine...

 

[Mr_Bean]

Would you mind sending the whole script? I'm a bit confused...

 

[mckill2009]

This code removes the Hero which pawns or sells the item...

function act_Test takes nothing returns nothing
    call RemoveUnit(GetTriggerUnit())
endfunction
function InitTrig_Test takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_PAWN_ITEM)
    call TriggerAddAction(t, function act_Test)
endfunction

This code removes the shop if the hero BUYS an item...

function act_Test2 takes nothing returns nothing
    call RemoveUnit(GetTriggerUnit())
endfunction

function InitTrig_Test2 takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_SELL_ITEM)
    call TriggerAddAction(t, function act_Test2)
endfunction

lastly, your code will NOT WORK if your trigger name is NOT Test and Test2...

InitTrig_Test >>> trigger name must be Test
InitTrig_Test2 >>> trigger name must be Test2

 

[Mr_Bean]

Okay thanks. Will try it when I can.

 

[Garfield1337]

Maybe the Init function doesn't fire; is your trigger named Test?

 

[Garfield1337]

...I pointed out a solution 30 hours ago.

You didn't point the solution, you just told him to use JNGP.

 

[cohadar]

If you are going to use jass download NewGen and learn to use scopes.
This can also help:
http://www.wc3c.net/vexorian/jasshelpermanual.html

Must I really quote myself?

 

[Garfield1337]

That's an alternative. Even though it's better to use it, it's not a solution to the problem.
I'd rather find out what's the cause of malfunction of that code first.

Also not everyone wants to use vJASS.

 

[Mr_Bean]

@cohadar:
Sorry for being so noob - please have patience.

Would someone else mind testing this map and tell me if it works?

Thanks.

 

[cohadar]

Here I fixed it for you.

 

[Garfield1337]

@cohadar:
Sorry for being so noob - please have patience.

Would someone else mind testing this map and tell me if it works?

Thanks.

Just what i said, the init function doesn't get executed; and why would it.
In vanilla JASS, for an Initialization function (such as adding events to triggers) to get executed, you have to create a so called trigger in GUI, convert it to custom text (select trigger > edit > convert to custom text) and then add code there while init function has to be named: InitTrig_TriggerNameHere.

 

[Mr_Bean]

Sorry, I was unaware that you had to make an actual trigger in GUI and convert it!

Thanks guys, much appreciated!

(Again, sorry for my noobiness)

 

[mckill2009]

(Again, sorry for my noobiness)

everybody starts as a noobsss, even Einstein...anyway, post #19 already answers your query, I even stated this...

InitTrig_Test >>> trigger name must be Test
InitTrig_Test2 >>> trigger name must be Test2