Help with a trigger

[RuaH]

I need help with a trigger... i want to :

If a player types: "-buy sword"
then: create a sword object at position of "Unit" owned by typped player and substract X gold
if a player types "-buy shield"
then: create a shield object at position of "Unit" owned by typped player and substract X gold
if....(the same thing but another item typped)
then...(the same thing creating the specific object) and substract X gold

whats the best way to do this?

 

[cohadar]

Wow a fresh cookie.
1 post and does not even know to register a chat event.

And people say wc3 is dead.

 

[RuaH]

you really didnt understand me ....
try do this with only 1 trigger ( 2 max ) if you can post here how

 

[cohadar]

You need two arrays, one for item names, one for item types:

"Sword", "Sheild", "Boots"
I001, I002, I003

Than when someone types -buy something
you search for something in array of names, and if you find the name at array index 7 for example, you give him item 7

Probably need one more array for gold if your prices are not the same for all items.

 

[RuaH]

i got it! ty u vry much

 

[Dr Super Good]

Consider using a hashtable to map with better efficiency using the hash of the strings.

Not really a problem if you only doing it for like 5 items but does start to count with 30+.

 

[cohadar]

Consider using a hashtable to map with better efficiency using the hash of the strings.

Not really a problem if you only doing it for like 5 items but does start to count with 30+.

Omg are you serious?
A hashtable for user typing trigger that does a simple array search?
Even if he had 8192 items it would not matter.

Another imaginary optimization junkie....

 

[Dr Super Good]

A hashtable for user typing trigger that does a simple array search?
Even if he had 8192 items it would not matter.

8192 items will cause a linear search routine to hit the op limit unless you start new threads.

A single hashtable lookup would likly evaluate faster for 8192 items than checking a 1-2 elements via linear search of the 8192 items. Even if the hashtable is poorly configured so ends up with a high collision density it will still perform better than a linear search due to it running native code instead of JASS interpreted instructions.

 

[cohadar]

OP limit is 300000. (five zeros)

Besides if op limit was just 200 it would still all be imaginary optimization talk because no one will ever make even 100 items for this.
(Because people would have to remember 100 item names to type)

Now stop arguing and just admit to yourself that you suffer from BJism.

 

[RuaH]

i tried to do it ... and no... i didnt got it xD

someone can upload a photo showing how to do it please?


edit: i'm using 18 items

 

[haxel96]

Trigger

• Untitled Trigger 001
  • Events
    • Player - Player 1 (Red) types a chat message containing -buy as A substring
    • Player - Player 2 (Blue) types a chat message containing -buy as A substring
    • Player - Player 3 (Teal) types a chat message containing -buy as A substring
    • Player - Player 4 (Purple) types a chat message containing -buy as A substring
    • ----- Add as many players that you need here -----
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Substring((Entered chat string), 6, (Length of (Entered chat string)))) Equal to sword
        • ((Triggering player) Current gold) Greater than or equal to 500
      • Then - Actions
        • Hero - Create Sword and give it to ("The hero that should have the item")
        • Player - Add -500 to (Triggering player) Current gold
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Substring((Entered chat string), 6, (Length of (Entered chat string)))) Equal to bow
            • ((Triggering player) Current gold) Greater than or equal to 500
          • Then - Actions
            • Hero - Create Bow and give it to ("The hero that should have the item")
            • Player - Add -500 to (Triggering player) Current gold
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Substring((Entered chat string), 6, (Length of (Entered chat string)))) Equal to shield
                • ((Triggering player) Current gold) Greater than or equal to 500
              • Then - Actions
                • Hero - Create Shield and give it to ("The hero that should have the item")
                • Player - Add -500 to (Triggering player) Current gold
              • Else - Actions

Use this if you dont have that many items, cus making like 20 items in this is NOT FUNNY...

Edit: Hmm, i posted this just before you edited your last post LOL, well 18 items in this is possible but i dont recommend it xD

 

[RuaH]

LOL if there isnt another way to do it, ill do that... XDD

 

[haxel96]

Maybe i could make this tomorrow, it will be alot shorter then and allow many! items, but i have to go now.

 

[RuaH]

ok haxel no problem, ill w8 for tomorrow

 

[haxel96]

And school first too, if nobody else helped you i might do it if i have time, it wont take long

 

[RuaH]

No problem, anyways, i did it like you, but i used 22 items XDDD

 

[-Kobas-]

Are you sure you want to create that, it will be pain in the ass to remember 22 items and to actually write that each time when you want to buy something.

Better create custom interface and when player write -buy show it to him with all items presented, when he click on icon, item can be sold to him, if he has enough gold/lumber or even some other custom resource.

 

[Meticulous]

Trigger

• Untitled Trigger 001
  • Events
    • Player - Player 1 (Red) types a chat message containing -buy as A substring
    • Player - Player 2 (Blue) types a chat message containing -buy as A substring
    • Player - Player 3 (Teal) types a chat message containing -buy as A substring
    • Player - Player 4 (Purple) types a chat message containing -buy as A substring
    • ----- Add as many players that you need here -----
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Substring((Entered chat string), 6, (Length of (Entered chat string)))) Equal to sword
        • ((Triggering player) Current gold) Greater than or equal to 500
      • Then - Actions
        • Hero - Create Sword and give it to ("The hero that should have the item")
        • Player - Add -500 to (Triggering player) Current gold
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Substring((Entered chat string), 6, (Length of (Entered chat string)))) Equal to bow
            • ((Triggering player) Current gold) Greater than or equal to 500
          • Then - Actions
            • Hero - Create Bow and give it to ("The hero that should have the item")
            • Player - Add -500 to (Triggering player) Current gold
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Substring((Entered chat string), 6, (Length of (Entered chat string)))) Equal to shield
                • ((Triggering player) Current gold) Greater than or equal to 500
              • Then - Actions
                • Hero - Create Shield and give it to ("The hero that should have the item")
                • Player - Add -500 to (Triggering player) Current gold
              • Else - Actions

Use this if you dont have that many items, cus making like 20 items in this is NOT FUNNY...

Edit: Hmm, i posted this just before you edited your last post LOL, well 18 items in this is possible but i dont recommend it xD

oh god my brain...

Create your items here

• Hashtable
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Hashtable - Create a hashtable
    • Set items = (Last created hashtable)
    • Item - Create Cheese at (Player 1 (Red) start location)
    • Hashtable - Save Handle Of(Last created item) as (Key cheese) of 0 in items
    • Item - Hide (Last created item)
    • Hashtable - Save 25 as (Key cheese) of 1 in items

Only need one buy trigger

• Buy
  • Events
    • Player - Player 1 (Red) types a chat message containing -buy as A substring
  • Conditions
    • (Load (Key (Substring((Entered chat string), 6, (Length of (Entered chat string))))) of 1 from items) Less than or equal to ((Triggering player) Current gold)
  • Actions
    • Item - Create (Item-type of (Load (Key (Substring((Entered chat string), 6, (Length of (Entered chat string))))) of 0 in items)) at (Player 1 (Red) start location)
    • Player - Set (Triggering player) Current gold to (((Triggering player) Current gold) - (Load (Key (Substring((Entered chat string), 6, (Length of (Entered chat string))))) of 1 from items))

P.S. obviously you need to alter a lot of that

There's probably a more eloquent way to set the items, but this way is at least functional if not stylish. You have to hide the items rather than removing them or else the handle won't work.

 

[haxel96]

I was gonna make something like that when i get home, im at school right now.

 

[cohadar]

...lots of crazy triggers...

oh spagetti monster my brain...

Look people just stop inventing crazy alternatives and someone make it to him with two arrays as I explained early in the thread.
I would do it but I coded GUI so long ago I probably would not know how any more...

@-Kobas-
When you post advice like that, include a link.

 

[-Kobas-]

There is no link, I just edited my hero pick system to show him interface.

 

[cohadar]

There is no link, I just edited my hero pick system to show him interface.

And how is that helping him?

 

[-Kobas-]

He already said that he want thing with typing words, so I just showed him picture with different idea how everything can look like.

If he found it interested he can ask for help if he need any

 

[Meticulous]

oh spagetti monster my brain...

Look people just stop inventing crazy alternatives and someone make it to him with two arrays as I explained early in the thread.
I would do it but I coded GUI so long ago I probably would not know how any more...

I notice you're very good at criticizing and not very good at offering any real help. I'll give you the benefit of the doubt and say you coded GUI "so long ago" that it was before hash tables were added, which are actually a lot easier to use, more versatile, and more efficient than arrays.

 

[RuaH]

its solved. thanks to haxel96, cohadar, meticulous and -kobas- for your help

 

[haxel96]

So you solved it yourself? Good job
EDIT: I'm still gonna make one myself could be useful later or maybe it could get advanced enough to be posted

 

[RuaH]

no lol, i used your way to do this XD
i dont know how to use hash tables so i had no choice XD