Hell Rising v1.3

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

Hell Rising v1.3 | Reviewed by Maker | 23rd Feb 2013

Needs Fix

Required changes You leak HR_TempLocUnit in loop trigger Suggested changes Set cast point of dummy to 0 Make the caster deal all the damage Remove structures built and upgrades used from the dummy, reduce the dummy's sight range Rename your triggers, the names are so generic

[td]
[/td]

Old reviews Required changes: Add importing instructions Set the dummy's death type to Can't raise, does not decay in object editor Delete Dummy trigger Suggested changes: You could add a configurable variable for the ability, use it in the spell s main condition You're setting Position of triggering unit twice in the cast trigger. Only set it once. You could filter out dead units from being damaged You don't need to set special effects into variables when you destroy them right away. Use "Destroy last created special effect" Firebolt(multi) could have a variable 04:21, 1st Jan 2013 Magtheridon96: - Code Set HR_Temploc_point = HR_Point[HR_CurrentIndex] Custom script: call RemoveLocation(udg_HR_Temploc_point) You can totally remove this. - The special effects need to be configurable - All spells submitted to Hiveworkshop need to have support for multiple levels, so the configuration trigger should be using arrays for spell data instead of regular variables. You should also add comments to the configuration trigger to explain what each variable is responsible for. - In the Cast trigger, you can first store the (Triggering unit) into your spell variable, then use that variable twice so you don't have to repeat (Triggering unit) more than once. - I'd recommend storing the (Triggering player) into a spell variable so you wouldn't have to keep calling (Owner of HR_unit[..]) inside your loop trigger. - You don't need the "Skip remaining actions" at the end of the loop. - HR_Point is being leaked. In the cast trigger, you're giving it a value. Then, in the loop trigger, you're overwriting that value. When the spell instance is done, you're removing the wrong point. To fix this, just remove this line: Set HR_Point[HR_CurrentIndex] = HR_Temploc_Unit from the loop trigger, and the same goes for this line: Set HR_Temploc_Unit = HR_Point[HR_CurrentIndex] and then change the custom script that removes HR_Temploc_Unit near the end of the trigger so that it removes HR_Point. - The expiration timer duration (2.00) should be configurable as well.

 

[Ofel]

Use this for special effect :

• Custom script: call DestroyEffect(AddSpecialEffectLoc("Abilities\\Spells\\Other\\Doom\\DoomDeath.mdl", udg_HC_Temploc_Unit))

Also, you should add an explanation (documentation) and how to import the spell and configuration

 

[Wolf_Wing]

Oh ok (-_-")

 

[Almia]

Review:
1: What's this for?

Hidden

• Set HR_Temploc_Unit = HR_Pont[HR_CurrentIndex]
• Custom script: call RemoveLocation(udg_HR_Temploc_Unit)

2:Set HR_Distance[HR_CurrentIndex] = (HR_Distance[HR_CurrentIndex] - 10.00)
Make 10 configurable
3:Unit - Cause HR_Unit[HR_CurrentIndex] to damage (Picked unit), dealing 25.00 damage of attack type Chaos and damage type Unknown
Make damage value configurable
4ick every unit in (Units within 200.00 of HR_Temploc_Unit)
Make AoE configurable
5: Create a special effect at HR_Temploc_Unit using Abilities\Spells\Other\Doom\DoomDeath.mdl
Make model configurable
6:Add a configuration trigger
7:I really dont understand 1. you are not even using it

 

[Wolf_Wing]

What Should I do?

 

[Almia]

Do all the following duh

 

[Ofel]

Review:
1: What's this for?

Hidden

• Set HR_Temploc_Unit = HR_Pont[HR_CurrentIndex]
• Custom script: call RemoveLocation(udg_HR_Temploc_Unit)

2:Set HR_Distance[HR_CurrentIndex] = (HR_Distance[HR_CurrentIndex] - 10.00)
Make 10 configurable
3:Unit - Cause HR_Unit[HR_CurrentIndex] to damage (Picked unit), dealing 25.00 damage of attack type Chaos and damage type Unknown
Make damage value configurable
4ick every unit in (Units within 200.00 of HR_Temploc_Unit)
Make AoE configurable
5: Create a special effect at HR_Temploc_Unit using Abilities\Spells\Other\Doom\DoomDeath.mdl
Make model configurable
6:Add a configuration trigger
7:I really dont understand 1. you are not even using it

Come on, he just a beginner...!!

Edit: Oh...yeah...Btw you have leak :

• Set HR_Temploc_Unit = (HR_Pont[HR_CurrentIndex] offset by 10.00 towards HR_Angle[HR_CurrentIndex] degrees)

 

[Wolf_Wing]

How to fix it ^_^"

 

[Almia]

You CODE IT!

 

[BUP]

ouch!! Too many Special Effects (occuring per 0.03sec)
you should use a timer for that
(check my attachment---i reduced the lag)

 

[Almia]

Or use a random chance

 

[BUP]

@Almia
Hey!! I think the dummy units need to be removed with another trigger

 

[Almia]

^Correct
or maybe using some conditions like:
Unit is dead Equal to True

 

[Wolf_Wing]

yes but i get a error message
can anyone help me?

 

[BUP]

What did you do to that??
I can't find any cause....
and

• Dummy
  • Events
    • Map initialization
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Last created unit) is dead) Equal to True
      • Then - Actions
        • Unit - Remove (Last created unit) from the game
      • Else - Actions

What's that??
You should store the unit-type of the spell into a variable and do like this

My Opinion

• Dummy
  • Events
    • Unit - A unit Dies
  • Conditions
    • (Unit-type of (Triggering unit)) Equal to Your_Saved_Unit_Type_Variable
  • Actions
    • Unit - Remove (Triggering unit) from the game

 

[Wolf_Wing]

^^Updated^^

 

[BUP]

You saved the damage variable and did u use it?

 

[Wolf_Wing]

of course "

 

[Almia]

Review #2
1) Set HR_Temploc_Unit = (HR_Point[HR_CurrentIndex] offset by 10.00 towards HR_Angle[HR_CurrentIndex] degrees)
10 should be configurable
2) Special Effect - Create a special effect at HR_Temploc_Unit using Abilities\Spells\Other\Doom\DoomDeath.mdl
Model path should be configurable,same w/:
Custom script: call DestroyEffect(AddSpecialEffectLoc("Abilities\\Spells\\Other\\Doom\\DoomDeath.mdl", udg_HR_Temploc_Unit))
3)Explain to me why are you not using the following:
Set HR_Temploc_Unit = HR_Point[HR_CurrentIndex]
Custom script: call RemoveLocation(udg_HR_Temploc_Unit)
Set HR_Temploc_point = HR_Point[HR_CurrentIndex]
Custom script: call RemoveLocation(udg_HR_Temploc_point
4)move the interval value to the configuration trigger

 

[Wolf_Wing]

(1) yes i will do it
(2) I not save special effect on variable cause i get error message
(3)Set HR_Temploc_point = HR_Point[HR_CurrentIndex]
Custom script: call RemoveLocation(udg_HR_Temploc_point
yes i used its
Explain to me why are you not using the following:
Set HR_Temploc_Unit = HR_Point[HR_CurrentIndex]
No im not used it cause the special effect will be gone for 1 second and its move to target and its really bad
(4) yes you right i will do it

 

[Ofel]

Yes...BUP is right you should use timer for creating the special effect

Example :

• Set Timer[Index] = (Timer[Index] + 0.03)
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • Timer[Index] greater than 0.15
  • Then - Actions
    • Create your special effect here
    • Set Timer[Index] = 0.00
  • Else - Actions

 

[Tank-Commander]

My Opinion

• Dummy
  • Events
    • Unit - A unit Dies
  • Conditions
    • (Unit-type of (Triggering unit)) Equal to Your_Saved_Unit_Type_Variable
  • Actions
    • Unit - Remove (Triggering unit) from the game

I would disagree, something along these lines is better:

Clicky

• Dummy
  • Events
    • Unit - A unit Dies
  • Conditions
  • Actions
    • Set TempU = Triggering unit
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Unit-type of (TempU) Equal to Your_Saved_Unit_Type_Variable
      • Then - Actions
        • Unit - Remove (TempU) from the game
      • Else - Actions

Eitherway, besides being pedantic I wanted to point out that the damage from the ability should be of type spell, not type unknown or chaos or whatever else there is for options

 

[Almia]

^ that is the quicker method

 

[Wrda]

Please wolf_wing use HIDDEN tags while posting triggers, or it will increase the the thread...
Edit: Do you know how much damage (25) per 0.03 seconds does per second? 833,(3)
It should be lower, even you should put a configuration trigger with damage and etc.
The spell description has grammar errors.

 

[BUP]

I would disagree, something along these lines is better:

Clicky

• Dummy
  • Events
    • Unit - A unit Dies
  • Conditions
  • Actions
    • Set TempU = Triggering unit
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Unit-type of (TempU) Equal to Your_Saved_Unit_Type_Variable
      • Then - Actions
        • Unit - Remove (TempU) from the game
      • Else - Actions

Eitherway, besides being pedantic I wanted to point out that the damage from the ability should be of type spell, not type unknown or chaos or whatever else there is for options

I was just telling him the way I know
You're a Pro and I agree that you disagree my opinion

 

[Ofel]

I would disagree, something along these lines is better:

Clicky

• Dummy
  • Events
    • Unit - A unit Dies
  • Conditions
  • Actions
    • Set TempU = Triggering unit
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Unit-type of (TempU) Equal to Your_Saved_Unit_Type_Variable
      • Then - Actions
        • Unit - Remove (TempU) from the game
      • Else - Actions

Eitherway, besides being pedantic I wanted to point out that the damage from the ability should be of type spell, not type unknown or chaos or whatever else there is for options

It's because if we using (Triggering unit), it will call GetTriggerUnit() in map scripts...you save it in a variable so it will only call once...

Is that correct ??

 

[Tank-Commander]

Indeed

 

[Wolf_Wing]

oh......:-D

 

[Ofel]

Suggest :
Create a unit group (with array) and if some unit need to be damaged, check it if that unit is in the unit group, if false deals them the damage and add them to unit group, if true do nothing...

For Example look at my spell on my signature

 

[Wolf_Wing]

___(*****Updated*****)____
___)- - (___)
___) - - (___)
___) +_____________+ (___)
([][]) ([][])

 

[Almia]

Review#3
1) Set HR_DAMAGE[HR_CurrentIndex] = ((Real(HR_Level[HR_CurrentIndex])) x 5.00)
and
Set HR_AoE[HR_CurrentIndex] = ((Real((Level of Hell Rising for HR_Unit[HR_CurrentIndex]))) x 100.00)
Make 100 and 5 configurable.
2)Special Effect - Create a special effect at HR_Temploc_Unit using HR_SE
Set HR_SE_LCS = (Last created special effect)
Special Effect - Create a special effect at HR_Temploc_Unit using HR_SE_2
Set HR_SE_LCS_2 = (Last created special effect)
Special Effect - Create a special effect at HR_Temploc_Unit using HR_SE_3
Set HR_SE_LCS_3 = (Last created special effect)
Set HR_Timer[HR_CurrentIndex] = HR_SE_Interval
Special Effect - Destroy HR_SE_LCS
Special Effect - Destroy HR_SE_LCS_2
Special Effect - Destroy HR_SE_LCS_2
-> Special Effect - Create a special effect at HR_Temploc_Unit using HR_SE
Special Effect - Destroy (Last created special effect)
Special Effect - Create a special effect at HR_Temploc_Unit using HR_SE_2
Special Effect - Destroy (Last created special effect)
Special Effect - Create a special effect at HR_Temploc_Unit using HR_SE_3
Special Effect - Destroy (Last created special effect)

also make the model's array.Then,create them inside a Integer Loop
3)Remove both of this
Set HR_Temploc_point = HR_Point[HR_CurrentIndex]
Custom script: call RemoveLocation(udg_HR_Temploc_point)

and

Set HR_Temploc_Unit = HR_Point[HR_CurrentIndex]
Custom script: call RemoveLocation(udg_HR_Temploc_Unit)

This is the third time im going to ask you.WHY ARE YOU NOT REMOVING THIS???YOU ARE NOT EVEN USING IT!!

 

[BUP]

He's immune to questions,I think.

 

[Almia]

No,he is sending me pms