[JASS] Function problem

[Insk]

Could someone just tell me whats wrong with this line of code (WE don't like it)

call GroupEnumUnitsOfType(towns, h000, null)

WE says something about an expected name. And btw towns is a unit group, h000 is a unit id and null is a boolean expression.

 

[Pharaoh_]

call GroupEnumUnitsOfType(towns, GetObjectName('h000'), null)

Try that.

 

[Insk]

Yay! worked +rep

{EDIT}
even though i got the line right the whole trigger don't work. Its meant to give all players the same amount of towns.

function Trig_Give_Towns_Actions takes nothing returns nothing
    local group towns = CreateGroup()
    local integer number_of_towns = CountUnitsInGroup(towns)
    local unit town
    local integer player_number = 0
    call GroupEnumUnitsOfType(towns, GetObjectName('h000'), null)
    loop
        set town = FirstOfGroup(towns)
        exitwhen town == null
        call SetUnitOwner(town, Player(player_number), true)
        call GroupRemoveUnit(towns, town)
        if player_number == 11 then
            set player_number = 0
        else
            set player_number = 1 + player_number
        endif 
    endloop
    call DestroyGroup(towns)
endfunction

//===========================================================================
function InitTrig_Give_Towns takes nothing returns nothing
    set gg_trg_Give_Towns = CreateTrigger(  )
    call TriggerRegisterTimerEventSingle( gg_trg_Give_Towns, 1.00 )
    call TriggerAddAction( gg_trg_Give_Towns, function Trig_Give_Towns_Actions )
endfunction

Anyone wanna help?

 

[Pharaoh_]

    local group towns = CreateGroup()
    local integer number_of_towns = CountUnitsInGroup(towns)

Don't get it; you create the group and afterwards you count the units in it?
Anyway, why don't you just create a unit for each player, instead of doing this? Apart from that,

call SetUnitOwner(town, Player(player_number), true)

-> Player(player_number + 1)

 

[Insk]

Hmm don't know what i was doing there tbh. The number_of_towns variable is never used lol. However even after removing that line the trigger wont work :S

 

[Pharaoh_]

call SetUnitOwner(town, Player(player_number), true)

Try

call SetUnitOwner(town, ConvertedPlayer (udg_player_number), true)

 

[Insk]

Anyway, why don't you just create a unit for each player, instead of doing this?

Well tbh the trigger is not yet completely done. Well yea i know its not even working, but anyway. When its completed it will split upp all the towns between all players, which means that if you are less players you will start with more towns.
Edit: YES! Finaly i got it, used:

set towns = GetUnitsOfTypeIdAll('h000')

instead of

call GroupEnumUnitsOfType(towns, GetObjectName('h000'), null)