efficiency of triggers

[GIMLI_2]

hi everyone, i have a REALLY simple question

first case:
Set Caster[1] = Casting unit
Set Target[1] = Targeted unit of ability being cast
cause Caster[1] to damage Target[1] dealing 500 damage

second case:
Set Caster = Casting unit
Set Target = Targeted unit of ability being cast
cause Caster to damage Target dealing 500 damage


is the second trigger more efficient than the first?
are there any other negative points for first case EXCEPT of the variables cost more bytes?

 

[defskull]

Actually, both triggers are inefficient
Why ?

Because you actually can directly call the function and use it (because you just use it once per run-time, it's fine).

So, this is the most efficient by far:

• Unit - Cause (Triggering unit) to damage (Target unit of ability being cast), dealing 500.00 damage of attack type Spells and damage type Normal

If you're gonna call the function only once per run, you should just call it without saving them into a variable.

 

[Erkki2]

Correct me if I'm wrong, but I think there's no difference in your examples in terms of efficiency (speed). However, the first example uses much more memory (as far as I know the size of all arrays is 8192).

As defskull said, only if you refer to a value more than once, set it to a variable. Also triggering unit is more efficient than casting unit or target unit.

Well, if it is a negative point, using arrays when you can use variables makes the trigger look messy, at least in my opinion.

 

[defskull]

Arrays is used for, well, to reduce the amount of variable;

Let's say you need to have 12 Player variable, you need only 1 array variable to represent all 12 of them, instead of creating 12 variable, 1 variable for each player.

Each of it has its own advantage, use it wisely.

 

[GIMLI_2]

i didnt ask if both are efficient or not, ofc triggers are more complex than this one, it was an example

so theres no difference in speed right?

 

[defskull]

Arrays runs slower than non-array variable, but the speed, really...
You can't see it with naked eyes.

So I'd say it's negligible.

 

[GIMLI_2]

i ask because i wanna create for example one unit variable with array for every trigger

trigger1:
unit[1] = caster

trigger2:
unit[2] = caster

if i do that with EVERY trigger, does it start lag more than without array?

 

[defskull]

It is VERY unefficient to do that, since each array slot will keep increasing (takes more space) unless you dynamic indexing (clears the array after use).

I suggest to use 1 (depends how many) global variable for all unit in the map.

For example, you have TempUnit1 and TempUnit2 variable.
Just use both of these variable at all times.

But make sure that those spells are instant, this way, the variable will not be overwritten and can be MUI by just using those 2 variables for all triggers.

You don't need to create 1 variable for 1 trigger, dude.

That's why we name it "Temp", to acknowledge users that the variable is just used for "Temporarily".

 

[GIMLI_2]

so i should use TempUnit for each instant spell and a own variable for duration spells?
about dynamic indexing..
im using bribes unit indexer, and i have some skills where i need array (to load some data i did based on the units value), for example a Spellpower stat that i add to a unit.
so i have to load the Integer_Spellpower[UnitValue] to get the spellpower.
do i need to do dynamic indexing in that case?

 

[defskull]

Not to advertise or something but, can you check on my Signature the Spell Power system ?
It does the same thing, you get the Spell Power value from an item that is pre-set via triggers before the game starts.

Also, don't get confuse with Unit Indexer and Indexing, they're both different thing.

For more info (difference between Hashtable/Unit Indexer/Indexing):
http://www.hiveworkshop.com/forums/triggers-scripts-269/arrays-hashtables-223616/#post2225726
http://www.hiveworkshop.com/forums/triggers-scripts-269/arrays-hashtables-223616/#post2225735