[Trigger] Drop chance

[gagarin699]

Hi Guys!

can u help me with this.

if a unit kill
there are 50% chance to drop a item!
if 50% chance fail then kill (killing unit)


anyone?

 

[rulerofiron99]

You already have most of the code you need, the only other tool you need is a way to get the 50%. Make a real variable, and set it to a random number between 0 and 100 when your event triggers, then for your if/then/else function, you can check if that real is less than or equal to 50.

 

[edo494]

between 1 and 100 for total 50%
0 to 50 is 51 numbers, 50.49% because there will be total of 101 numbers

 

[rulerofiron99]

Make a real variable

So it goes from 0.01 - 50.00, and 50.01 - 100.00

There's also a function, set to random percentage which will return the same.

 

[-Kobas-]

• Here you go
  • Events
    • Unit - A unit Dies
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Random integer number between 1 and 2) Equal to 1
      • Then - Actions
        • Unit - Kill (Killing unit)
      • Else - Actions
        • Item - Create Tome of Experience at (Position of (Triggering unit))

Edit values, clean leaks.

 

[Kingz]

Just wanted to point that using integers for % chance is better than reals, however odd that might sound.

This is speaking for personal experience because if you use reals you can get:

23.124
23.121
13.166
13.133

And the chances seem actually less than using integers due to the amount of numbers and randomness.
Just a thing you guys could think about.

 

[-Kobas-]

If you need 0.001 chance just compare GetRandomInt( 1, 1000 ) == 1 and problem solved

 

[gorillabull]

Just wanted to point that using integers for % chance is better than reals, however odd that might sound.

This is speaking for personal experience because if you use reals you can get:

23.124
23.121
13.166
13.133

And the chances seem actually less than using integers due to the amount of numbers and randomness.
Just a thing you guys could think about.

no that is incorrect you can have a random real between 0.000 and 1.000 or a random real between 1.000 and 100.000 , 100.000 and 1000.000 or even 1,000,000 and 100,000,000.. anything will do as long as you keep the ratio equal, you can get a 0%-100% chance this is the advantage of reals over integers but in theory of course random number generation is not the best in wc3

in any case say you want a 50.555% chance to trigger critical strike
all you have to do is:
if random real number between 1.000 and 100.000 LESS THAN OR EQUAL TO
50.555
then...
and the two values above can be anything else of the mentioned, however the only advantage of reals is that they provide you with a slight accuracy advantage over integers, an accuracy which is not needed in wc3.

 

[Kingz]

I am just saying i had better results when doing tests with integer % than real %.

 

[gorillabull]

well i tested too and here is what results i got with this trigger:

trigger

[trigger=trig]Untitled Trigger 021
Events
Time - Elapsed game time is 3.00 seconds
Conditions
Actions
For each (Integer A) from 1 to 100, do (Actions)
Loop - Actions
Set AAAAAAAAAAAAAAAAAAAAAAA = (Random integer number between 1 and 100)
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
AAAAAAAAAAAAAAAAAAAAAAA Less than or equal to 50
Then - Actions
Game - Display to (All players) the text: IT WORKS
Set counter = (counter + 1)
Else - Actions
Wait 2.00 seconds
Game - Display to (All players) the text: (String(counter))
Wait 4.00 seconds
Set counter = 0
For each (Integer A) from 1 to 100, do (Actions)
Loop - Actions
Set AAAAAAAAAAAAAAAAAAAAAAA = (Integer((Random real number between 1.00 and 100.00)))
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
AAAAAAAAAAAAAAAAAAAAAAA Less than or equal to (Integer(50.00))
Then - Actions
Game - Display to (All players) the text: IT WORKS
Set counter = (counter + 1)
Else - Actions
Wait 2.00 seconds
Game - Display to (All players) the text: (String(counter))
[/trigger]

as u can see numbers range from 1 to 100 i tested 7 individual times with this trigger and here are the results:

int values / real values
1- 54 / 56
2- 58 / 60
3- 57 / 58
4- 50 / 56
5- 52 / 52
6- 60 / 50
7- 56 / 63

not much of a difference i suppose but the reals did trigger a few more times than the integers try it out for yourself if you dont believe this

 

[Kingz]

I belive you, i am simply saying i had more precise/concise results with integers.
Tho it would probably be the same if i had run more tests but i am speaking for what i did test.

 

[-Kobas-]

I think as well that integers are more accurate, for simple example: 3/10 isn't 0.33 because this array go into infinity.

 

[gorillabull]

if you have a .3333 that goes to infinity it will eventually be rounded else the computer will run out of memory trying to store it, integers only exist so that the program will use less memory when storing numbers and they are used so store less important values, reals on the other hand are used to store very accurate information it is not possible to say that an integer is more accurate than a real in terms of accuracy