[Trigger] Does this leak?

[plumsy460]

• Trigger
  • Events
    • Unit - A unit Dies
  • Conditions
  • Actions
    • Set TempPG = (All allies of (Owner of (Killing unit)))
    • Player Group - Pick every player in KillingBlowAllies and do (Actions)
      • Loop - Actions
        • Set TempUG = (Units owned by (Picked player) matching (((Matching unit) is A Hero) Equal to True))
        • Unit Group - Pick every unit in U1GTemp and do (Actions)
          • Loop - Actions
            • Hero - Add 25 experience to (Picked unit), Show level-up graphics
        • Custom script: call DestroyGroup(udg_TempUG)
    • Custom script: call DestroyForce(udg_TempPG)

 

[jonhysone]

I don't get it... You create an unit group then after it you pick units from an individual unit group...
This is what I mean:

You create a group called TempUG, then you pick every unit in U1GTemp.... I think there is an interference between them , it may cause bugs..

It doesn't leak though.

 

[Legal_Ease]

Why not just pick every (unit owned by (allies of KillingBlowAllies))? This will save you running a loop inside a loop.

 

[Dr Super Good]

Why not just pick every (unit owned by (allies of KillingBlowAllies))? This will save you running a loop inside a loop.

Because the group returned takes a player not a force.

The largest performance improvement would come from caching the hero results of the players in a group and using their player id as an index in a group array to retrieve it. This would eliminate searching for heroes each time. However unless performance is noticeably a problem then the above is fine.

Does this leak?

No it does not leak. At least it looks that way.

 

[plumsy460]

Ups! I made a mistake in rewritting the variables before posting. This is how the trigger really looks:

• Trigger
  • Events
    • Unit - A unit Dies
  • Conditions
  • Actions
    • Set TempPG = (All allies of (Owner of (Killing unit)))
    • Player Group - Pick every player in TempPG and do (Actions)
      • Loop - Actions
        • Set TempUG = (Units owned by (Picked player) matching (((Matching unit) is A Hero) Equal to True))
        • Unit Group - Pick every unit in U1GTemp and do (Actions)
          • Loop - Actions
            • Hero - Add 25 experience to (Picked unit), Show level-up graphics
        • Custom script: call DestroyGroup(udg_TempUG)
    • Custom script: call DestroyForce(udg_TempPG)

Well I'm happy it's not leaking. Thank you all for checking