Damage System Request

[Shdow89]

Guys I need a Damage Counter system. It should count which hero dealt most damage in a round and then to show it in a multiboard. That kind of system is used in map called: WoW Arena. Please, if anyone can help I would be grateful and would put him/her in credits area and give rep. Thank you.

 

[roguo]

in this save/load system there is a damage counter system not sure but maybe you can use it Warcraft III Spells - Kode

 

[Devine]

• damage system
  • Events
    • Unit - A unit Is attacked
  • Conditions
    • ((Attacking unit) is A Hero) Equal to True
    • ((Owner of (Attacked unit)) is an enemy of (Owner of (Attacking unit))) Equal to True
  • Actions
    • Set dmg[(Player number of (Owner of (Attacking unit)))] = (dmg[(Player number of (Owner of (Attacking unit)))] + (Integer((Damage taken))))
    • Game - Display to (All players) the text: (String(dmg[(Player number of (Owner of (Attacking unit)))]))

This is all i have. It doesnt work but i can't see why. You'l probably find the answer

 

[PatruX]

• damage system
  • Events
    • Unit - A unit Is attacked
  • Conditions
    • ((Attacking unit) is A Hero) Equal to True
    • ((Owner of (Attacked unit)) is an enemy of (Owner of (Attacking unit))) Equal to True
  • Actions
    • Set dmg[(Player number of (Owner of (Attacking unit)))] = (dmg[(Player number of (Owner of (Attacking unit)))] + (Integer((Damage taken))))
    • Game - Display to (All players) the text: (String(dmg[(Player number of (Owner of (Attacking unit)))]))

This is all i have. It doesnt work but i can't see why. You'l probably find the answer

For starters Damage Taken does not respond to A unit Is attacked.
The problem is the event which must point at a specific unit, not a generic one.
The second problem arise once you've changed the event to a specific unit, since Attacking Unit does not work with Damage Taken, you'll have a hard time getting the Attacking Unit without using JASS.

 

[ANdROnIQ]

Maybe we need to add each created unit on the map into a trigger as an event that this unit takes damage (one trigger, many events). And then, referring to the Damage Source, we check whether it is a Hero with dmg counter (maybe having all such Heroes added to a special group) and, if so, add the damage to its counter. Should I write this triggerly?

 

[PatruX]

Maybe we need to add each created unit on the map into a trigger as an event that this unit takes damage (one trigger, many events). And then, referring to the Damage Source, we check whether it is a Hero with dmg counter (maybe having all such Heroes added to a special group) and, if so, add the damage to its counter. Should I write this triggerly?

That would work with pre-spawned units, but what about units created/bought/trained at a later stage of the map?

 

[ANdROnIQ]

So, we need one more trigger like that: when a unit is summoned/trained or what, add its 'dmg taken' event to the main trigger. I meant that in the previous post...

The problem now is, how to clean the trigger when the unit has died? NewGen could do this, but I don't use NewGen.

 

[graystuff111]

Here you go
It's damage detection.
OMG!
View attachment Damage Detection.w3x

 

[Razorbrain]

So, we need one more trigger like that: when a unit is summoned/trained or what, add its 'dmg taken' event to the main trigger. I meant that in the previous post...

The problem now is, how to clean the trigger when the unit has died? NewGen could do this, but I don't use NewGen.

can NewGen remove events from a trigger?

 

[ANdROnIQ]

Even JASS can, but JASS can't 'remember' what event must be removed. NewGen can link together different typed handles, as handle to unit and handle to event.

 

[Ribenamania]

• Unit Attacked
  • Events
    • Unit - A unit Is attacked
  • Conditions
  • Actions
    • Set Target[(Player number of (Owner of (Attacking unit)))] = (Attacked unit)
    • Trigger - Add to Count Damage <gen> the event (Unit - Target[(Player number of (Owner of (Attacking unit)))] Takes damage)
    • Trigger - Add to Clear Damage <gen> the event (Unit - Target[(Player number of (Owner of (Attacking unit)))] Dies)

• Count Damage
  • Events
  • Conditions
  • Actions
    • Set DamageTaken[(Player number of (Owner of (Attacking unit)))] = (Damage taken)

• Clear Damage
  • Events
    • Unit - A unit Dies
  • Conditions
    • (Dying unit) Equal to Target[(Player number of (Owner of (Attacking unit)))]
  • Actions
    • Set DamageTaken[(Player number of (Owner of (Attacking unit)))] = 0.00

Can this work ?

 

[ANdROnIQ]

Er, I think that rather must look like this.

• Unit Attacked
  • Events
    • Unit - A unit Is attacked
  • Conditions
  • Actions
    • Set Target[(Player number of (Owner of (Attacking unit)))] = (Attacked unit)
    • Trigger - Add to Count Damage <gen> the event (Unit - Target[(Player number of (Owner of (Attacking unit)))] Takes damage)

• Count Damage
  • Events
  • Conditions
  • Actions
    • Set DamageTaken[(Player number of (Owner of (Attacking unit)))] = DamageTaken[(Player number of (Owner of (Attacking unit)))] + (Damage taken)

However, this is also not too clear. It will make some trash.

 

[Razorbrain]

it will stack with itself

add every unit to a UnitGroup and then check if the unit is in the UnitGroup before it is added to the event

EDIT:

Even JASS can, but JASS can't 'remember' what event must be removed. NewGen can link together different typed handles, as handle to unit and handle to event.

and this function is called?

 

[ANdROnIQ]

what called? NewGen has ABC system and HSAS system developed for these purposes, that's all I know. For the JASS function, actually, I meant to create another trigger for each unit and call DestroyTrigger(...), but it anyway can't link together trigger and unit. The only handle-linking may be GetTriggeringTrigger(). (didn't think somebody will pay attention to removing events from triggers :/)

 

[Razorbrain]

DestroyTrigger destroys the trigger, not the events

very different stuff you know

 

[ANdROnIQ]

it destroys the trigger WITH its events. And it wouldn't suck if a different trigger will 'hang' over each unit, what I actually meant.

 

[Razorbrain]

but then you need (atleast) 1 more trigger, and transfering events such as "Unit Takes Damage" when they have been added in the first place does not require NewGen

 

[ANdROnIQ]

Honestly, I didn't get all of what you said, but actually I meant in-game creating triggers:

function AddTrigger takes unit u returns nothing
    local trigger trig = CreateTrigger( )
    call TriggerRegisterUnitEvent(trig, u, EVENT_UNIT_DAMAGE)
    call TriggerAddCondition(trig, Condition(function Trig_SomeConditions))
    call TriggerAddAction(trig, function Trig_SomeActions)
    set trig = null
endfunction

, where SomeConditions and SomeActions can be taken from the needed trigger converted to JASS (each unit will have a trigger), and UnitIsAttacked event-reacting trigger generates the local trigger, calling AddTrigger(GetAttackedUnit()) to wait until it is attacked damaged. In SomeActions, we should call DestroyTrigger(GetTriggeringTrigger()) and add to Damage Source's counter the Damage Taken value.

 

[Shdow89]

Here you go
It's damage detection.
OMG!
View attachment 35768

errr... Thx for this I find it very useful, but that's not what I needed. I need something to count damage delt by a player through a whole game while storing it in an integer. And if possible to only register damage delt by a hero of a player.