[JASS] Damage over time trigger

[xD.Schurke]

So I'm a newbie in jass and so i tried my best with this, and my question is, is there a better way to do it

i noticed it starts to lag when the spell is 5 times active

function dot_action takes nothing returns nothing
 local unit caster = GetSpellAbilityUnit()
 local unit target = GetSpellTargetUnit()  
 local real damage = ( ( GetUnitAbilityLevelSwapped('A000', caster) * 10 ) + GetHeroInt(caster,true) )
 local integer start = 0
 local integer stop = 5
    
    loop
        exitwhen start > stop
        call UnitDamageTarget(caster,target,damage,true,false,ATTACK_TYPE_NORMAL,DAMAGE_TYPE_NORMAL,WEAPON_TYPE_WHOKNOWS)
        call TriggerSleepAction(3.00)
        set start = start + 1
    endloop 
 set caster = null
 set target = null
endfunction

function Condition_Function takes nothing returns boolean
  return GetSpellAbilityId() == 'A000'
endfunction

function InitTrig_dot takes nothing returns nothing
  local trigger dot= CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(dot,EVENT_PLAYER_UNIT_SPELL_EFFECT)
    call TriggerAddCondition(dot,Condition(function Condition_Function))
    call TriggerAddAction(dot,function dot_action)
  set dot = null    
endfunction

 

[Squiggy]

Why don't you use Shadowstrike?
It also does damage over time D:

 

[xD.Schurke]

i know, but the damage each 3 seconds should scale with int and spelldamage of the hero

 

[xD.Schurke]

please help

 

[Soga-]

Do you know how to use handle vars?

 

[xD.Schurke]

ok i now i set the vars to null (unit vars) but it still start to lag when the dot is 3 times active

 

[Yddohu]

Try to use native TriggerSleepAction(real duration) istead of function PolledWait.
I did not understand why it lag but natives are faster than functions, so it may work for you. Just replace;
call PolledWait(3.00) with
call TriggerSleepAction(3.00)

Tell me if it works.

 

[xD.Schurke]

yes i changed but it still lages when the spell is 3 times+ active, i think its the loop but i don't know

 

[Yddohu]

It's not the loop, I tried the spell and works fine for me. Even I cast it for 20 guys, I didn't lag quite a bit. So the problem must be sth else about your other codes or your computer.

 

[xD.Schurke]

yes looks like, thanks for help