Cover of Darkness 1.02

[Moderator]

21:30, 28th Dec 2009
TriggerHappy:

Why are you using forces?
Anyways, I suppose the code and spell is decent enough.

 

[MortAr]

The spell in HoN is instant, and sight range is bigger than in HoN, which doesn't make any sense, 'cause its makes it easier to focus on your hero if you are in danger. It should only show your hero, and I think you can add a function that reduces the target's acquistion range (imo)

Still its a good one. 4/5, vote for approval.

PS: DARKNESS FALLS!

 

[Deaod]

• Dont inline TriggerRegisterAnyUnitEventBJ
• Use a group stack. GroupUtils
• Dont use dummy filters, do whatever you want to do to all enumed units inside those filters.
• constant handles are a no-go.
• your recycling algorithm sucks. Tell me one reason why a stable algorithm is required.
• Changing alliances inside a spell is a bad idea.

 

[Kruemel]

@Mortar- : Sry i dont get what you mean with the sight range ( my english sucks )
I tryed it with the acquire range but it didnt work, the creeps still autoattack me :/. Will try it again with 0 acquire range.
@Deaod :
1. Where i inlinded TriggerRegisterAnyUnitEventBJ ? you mean the GUI Triggers ?
2. I didnt want to require more Systems.
3. I dont get what you mean, i dont have a dummy filter ?!? Do you want that i disable the sight thing inside the Filter ?
4. Why ? :O
5. Hm so it (should) gets MUI. Tell me whats wrong with the resycling system pls
6. Ye i know but i need to do or i cant break the shared sight

 

[MortAr]

What I meant is, you still have around 200 sight range, so you can still see if an enemy is coming, AFAIK in HoN you can't see it, only if its a melee that and its attacking you.

 

[Kruemel]

Ok i can change the sightrange loose to 575 so you can only see your unit,
BUT wc3 has a feature that gives you short time vision if you get attacked by a a unit outside your sight range.

Dont want to update you can easily change the value by your own:

private constant integer  SIGHT_MALUS = -575

I also checked the SetUnitAcquireRange again and it seems that this functions dont work, my units still attack (tested values: -1,0,1)

 

[Deaod]

1. Where i inlinded TriggerRegisterAnyUnitEventBJ ? you mean the GUI Triggers ?

No, in your initialization function

2. I didnt want to require more Systems.

Bad idea.

3. I dont get what you mean, i dont have a dummy filter ?!? Do you want that i disable the sight thing inside the Filter ?

I want you to actually DO something in the filter, instead of just returning true.

4. Why ? :O

Because Vex's Optimizer screws up the script when you do that, since it inlines constant expressions (and the content of constant variables).

5. Hm so it (should) gets MUI. Tell me whats wrong with the resycling system pls

Instead of moving every instance one down, you could just swap the instance you want to recycle with the last active instance in the array.

 

[Kruemel]

1. I dont get what i should do ?
Do you think that this is better ?:

call TriggerRegisterAnyUnitEventBJ(Trigger,EVENT_PLAYER_UNIT_SPELL_EFFECT)

2. I have uploaded now both
3. I have heard that null Boolexpr do leak so i created a true filter
4. Ok thats a fact i didnt know - > changed
5. y your right that was stupid -> changed


Update 1.01

 

[Deaod]

Do you think that this is better ?:

Exactly.

I have heard that null Boolexpr do leak so i created a true filter

First of all, patch 1.24c fixed that. Secondly, you can replace the return true with a return false, and instead do everything you want to do to those units before returning.

 

[Kruemel]

I dont get why i should use a BJ that exatly do what i do ? makes a BJ call it even faster or is it just for the readable ?

Update with the filter use 1.02

 

[Deaod]

Readability. If you want speed, you should use a Stack like SpellEvent by Anitarf.

 

[Kruemel]

fixed:
call TriggerRegisterAnyUnitEventBJ(Trigger,EVENT_PLAYER_UNIT_SPELL_EFFECT)

 

[RakEnRoL]

It's useful, yes. But I dislike the use of BonusMod.