Charge and Combine System by OgreMagi v3.5

[Bribe]

In all my years working with JassHelper, I have never seen set.var = val syntax. Isn't that throwing a syntax error? There are way too many dots in your map and in your examples

 

[SunLord]

In all my years working with JassHelper, I have never seen set.var = val syntax. Isn't that throwing a syntax error? There are way too many dots in your map and in your examples

It's working. I use 1.31+.

 

[Bribe]

JassHelper is so weird. It won't compile in pJASS nor via vanilla World Editor with them in-place, and this is clearly an unintentional bug. Please refrain from exploiting this bug, as it:

1) is extremely confusing
2) will fail with parses such as pJass or transcompilers such as vJass2Lua
3) is used inconsistently throughout your code

 

[SunLord]

1. im using vscode and my extension vjass auto format this syntax. (it's call pjass right?)
2. Yes, I will find extension format normaly syntax
=> It's ok. I need fix it, but my code working right?

JassHelper is so weird. It won't compile in pJASS nor via vanilla World Editor with them in-place, and this is clearly an unintentional bug. Please refrain from exploiting this bug, as it:

1) is extremely confusing
2) will fail with parses such as pJass or transcompilers such as vJass2Lua
3) is used inconsistently throughout your code

 

[Wrda]

I think you should follow the JPEG guideline somewhat more. It doesn't need to be strictly followed, but has certain things have strong grounds to be the way they are. For example, StructName and not STRUCTNAME and constants to be always capitalized with underscore (_) being the space.
local integer m = 1 isn't being used in the function. local item I = null better naming, please.
You have unit, item and triggers reference leaks, need to null them at the end of the functions.
This resource contains 2 systems, Item stacking/unstacking and item combine system. Item stack and unstack has been done to death, and Baradé's system supports more configurable parts rather than a globa max stack limit for every item, like this one. Item stack is natively possible recently by turning the following constant to true:

I don't remember if it is available on 1.31, but probably is.
I'm not sure why an array with 7 items, if max inventory is 6, from this line:

ITEM_RECIPE array Items[7]

Not every unit has 6 inventory slots, use UnitInventorySize (keep in mind you will need to -1 if you're going to iterate with UnitItemInSlot). Consequently, replace UnitItemInSlotBJ with UnitItemInSlot.
You don't need to do this set Combine = 0 nor setting bj_lastCreatedItem to null.

    private static method onInit takes nothing returns nothing
        call TimerStart(CreateTimer(), 0.5, false, function thistype.SetupEvent)
    endmethod

I don't understand why you need a timer at all, doing everything on onInit is fine. Even if you keep it this way, you're still leaking the timer.
set.i =.i + 1 set.Combines[.i] = ITEM_COMBINE.create() call.Combines[.i].Setup() if.Combines[n].RecipeID == recipeid and such is extremely bizarre sight to see, I'm surprised how it even works.
Having to scroll all the way down to configure the recipes isn't very acceptable. It would be better if you had a function up top for specifically the user to configure easily, which then you would call on the onInit. I'd say the same thing for the sucess and failure of the combine "events". You also need to put the system in a folder independent of the other scripts of this map, as it's easier for the user to import later.

Even though there has been quite a few item combine systems, this one supports charge based requirements, that's a plus.

 

[SunLord]

I think you should follow the JPEG guideline somewhat more. It doesn't need to be strictly followed, but has certain things have strong grounds to be the way they are. For example, StructName and not STRUCTNAME and constants to be always capitalized with underscore (_) being the space.
local integer m = 1 isn't being used in the function. local item I = null better naming, please.
You have unit, item and triggers reference leaks, need to null them at the end of the functions.
This resource contains 2 systems, Item stacking/unstacking and item combine system. Item stack and unstack has been done to death, and Baradé's system supports more configurable parts rather than a globa max stack limit for every item, like this one. Item stack is natively possible recently by turning the following constant to true:
View attachment 455639
I don't remember if it is available on 1.31, but probably is.
I'm not sure why an array with 7 items, if max inventory is 6, from this line:

ITEM_RECIPE array Items[7]

Not every unit has 6 inventory slots, use UnitInventorySize (keep in mind you will need to -1 if you're going to iterate with UnitItemInSlot). Consequently, replace UnitItemInSlotBJ with UnitItemInSlot.
You don't need to do this set Combine = 0 nor setting bj_lastCreatedItem to null.

    private static method onInit takes nothing returns nothing
        call TimerStart(CreateTimer(), 0.5, false, function thistype.SetupEvent)
    endmethod

I don't understand why you need a timer at all, doing everything on onInit is fine. Even if you keep it this way, you're still leaking the timer.
set.i =.i + 1 set.Combines[.i] = ITEM_COMBINE.create() call.Combines[.i].Setup() if.Combines[n].RecipeID == recipeid and such is extremely bizarre sight to see, I'm surprised how it even works.
Having to scroll all the way down to configure the recipes isn't very acceptable. It would be better if you had a function up top for specifically the user to configure easily, which then you would call on the onInit. I'd say the same thing for the sucess and failure of the combine "events". You also need to put the system in a folder independent of the other scripts of this map, as it's easier for the user to import later.

Even though there has been quite a few item combine systems, this one supports charge based requirements, that's a plus.

1. Just change struct name , remove variable m, rename I,set null unit for remove leak ! 1.31 charge stack not have option, I added it for the older version as well.
2. Used UnitInventorySize, fix some syntax, Removing timer when using event on timer in this case is not necessary.
3. Makes the code flexible and can be set anywhere
4. Use EventGameVariable for setting everywhere

I have completed the changes accordingly and properly. I feel my skills have improved. I look forward to your review @Wrda !

 

[Wrda]

I suspect you meant ItemCombine and not itemCommbine for the struct name, it's not deep.
You could expand the system to use the variable event "udg_EventSettingCombine" to simulate events when a combination was successfully and failed. Could be something such as udg_EventSettingCombine = 2 for success, udg_EventSettingCombine = 3 for failure, in this part:

if Combine.Match() then
                // call BJDebugMsg("Match")
                call Combine.GiveCombineItem(u)
                // You can make call something here if combine is success

            else
                // call BJDebugMsg("Unmatch")
                // You can make call something here if combine is fail
            endif

Note that you have to set it back to 0 after.
Furthermore, you could make event responses, such as GetCombinedItem as the result item, GetCombiningRecipe as the item recipe the player buys.

Overall, the system works fine.

Approved

 

[deepstrasz]

It doesn't work on 1.31.1 but does on 1.36.
Not sure what's that different from regular or the DotA type recipe system?

 

[Wrda]

It doesn't work on 1.31.1 but does on 1.36.
Not sure what's that different from regular or the DotA type recipe system?

Allows to create recipes that require a certain amount of charges, and the fusion is powerup based, so the combining works even with full inventory.

 

[deepstrasz]

Allows to create recipes that require a certain amount of charges, and the fusion is powerup based, so the combining works even with full inventory.

Thank you. I didn't quite really have proper time understanding the system as it was made like a mini-defense map so I was pretty much losing the game before doing enough combinations to get the gist of it.
Please in the future @SunLord try separating the gameplay from the actual system testing.

 

[P3in]

So, is this system updated?
I would like to use for my trinity orpg map, but I already have some glitches with the save that I didn't figure out, I wouldn't like to have some with the recipes aswell )
Thank you!

 

[SunLord]

Thank you. I didn't quite really have proper time understanding the system as it was made like a mini-defense map so I was pretty much losing the game before doing enough combinations to get the gist of it.
Please in the future @SunLord try separating the gameplay from the actual system testing.

I have edited a version that is only used to test the system!

So, is this system updated?
I would like to use for my trinity orpg map, but I already have some glitches with the save that I didn't figure out, I wouldn't like to have some with the recipes aswell )
Thank you!

Here is a video on how to create a combine, you can use multiple files to manage the types of items you want.

 

[nhocklanhox6]

Giỏi quá ta