[Trigger] boot player system

[PrisonLove]

okay so im trying to make a system in my map that boots team killers. basically if you kill an allied hero 3 times, the player you killed gets the option to boot you (through dialogue boxes) right now i have no way to test it so i was wondering if someone could take a look at my triggers and tell me if you see any bugs or mistakes and such. here they are

• boot player integer
  • Events
    • Unit - A unit Dies
  • Conditions
    • ((Triggering unit) is A Hero) Equal to True
    • ((Killing unit) belongs to an ally of (Owner of (Triggering unit))) Equal to True
  • Actions
    • Set BootPlayer[(Player number of (Owner of (Killing unit)))] = (BootPlayer[(Player number of (Owner of (Killing unit)))] + 1)

• boot player show
  • Events
    • Unit - A unit Dies
  • Conditions
    • ((Triggering unit) is A Hero) Equal to True
    • ((Killing unit) belongs to an ally of (Owner of (Triggering unit))) Equal to True
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • BootPlayer[(Player number of (Owner of (Killing unit)))] Greater than or equal to 3
      • Then - Actions
        • Set BootedPlayer = (Owner of (Killing unit))
        • Dialog - Clear boot_dialog
        • Dialog - Change the title of boot_dialog to (cc_player[(Player number of (Owner of (Attacking unit)))] + (end_tag + has killed you |nBoot Player?))
        • Dialog - Create a dialog button for boot_dialog labelled Yes
        • Set dialog_button[1] = (Last created dialog Button)
        • Dialog - Create a dialog button for boot_dialog labelled No
        • Set dialog_button[2] = (Last created dialog Button)
        • Dialog - Show boot_dialog for (Owner of (Triggering unit))
      • Else - Actions

• boot player
  • Events
    • Dialog - A dialog button is clicked for boot_dialog
  • Conditions
    • (Clicked dialog button) Equal to dialog_button[1]
  • Actions
    • Game - Defeat BootedPlayer with the message: You have been boote...

• no boot player
  • Events
    • Dialog - A dialog button is clicked for boot_dialog
  • Conditions
    • (Clicked dialog button) Equal to dialog_button[2]
  • Actions
    • Player Group - Pick every player in (All Players) and do (Actions)
      • Loop - Actions
        • Dialog - Hide boot_dialog for (Picked player)

 

[Hanky]

I see nothing wrong with it.

Edit: Uno momento, you destroy a global constant. Because the function GetPlayersAll() just returns bj_FORCE_ALL_PLAYERS so when you delete it it wouldnt be good, I guess.

 

[Huurka]

He made it a variable first, it should work, I guess.

 

[Hanky]

The function GetPlayersAll() dont create a force it just returns bj_FORCE_ALL_PLAYERS. So it would destroy bj_FORCE_ALL_PLAYERS. That means next time it returns a destroyed bj_FORCE_ALL_PLAYERS. There is the proof:

function GetPlayersAll takes nothing returns force
    return bj_FORCE_ALL_PLAYERS
endfunction

 

[Huurka]

That shows nothing for me, I don't know JASS.

 

[Hanky]

Ok I try to explain it better he also could write:

• Custom script: set AllPlayers = bj_FORCE_ALL_PLAYERS

Now when he destroy it he also could write:

• Custom script: call DestroyForce(bj_FORCE_ALL_PLAYERS)

Its exactly the same. But how you can return something that is destroyed? I hope now you understand.

 

[PrisonLove]

ok so i removed the destroy group and didnt set it to a varaible. will it work fine now?

 

[Hanky]

Yes now it should work fine I think.

 

[PrisonLove]

okay thanks everyone.

p.s. i was just wondering what everyone thought of using a system like this. i believe it to be more fair than giving someone the power to kick. what do you guys think?

 

[Seth21]

I dont like it. I think you should not permit team-killing in the first place.

 

[PrisonLove]

well this is an AoS so you should be able to kill your own ally right before an enemy does to prevent them from getting gold. thats just strategy in my opinion. then, if you tell your teammate why you did it, you wont get booted. also i need team killing for denying towers and such. but if a player attacks their fortress (the win condition building) they are first warned, then killed, if they do it again, theyre automatically booted. thats my anti team kill system