Better Dialog v1.1

[Wrda]

I like your use of emmy annotation

CreateBetterDialogForForce whichForce can be either a table or a force, you can use "|" to mean "or":

---@param whichForce table | force
---@param dialogTitle string
---@param buttonData table
function CreateBetterDialogForForce(whichForce, dialogTitle, buttonData)

Can also apply it to the ButtonsData case.

PlayButtonClickForPlayer could be local since it's not part of the API.

Otherwise, this is pretty good, very useful for host or players to get more detailed information about what a certain button does. Users can now blame the map maker for not doing this!

Approved

 

[Antares]

CreateBetterDialogForForce whichForce can be either a table or a force, you can use "|" to mean "or":

Oh nice, I was sure that was possible but I couldn't figure out the correct syntax.

Fixed the non-locality.

Thanks!

 

[DarkePacific]

Need the Jass version of this.

 

[Antares]

Need the Jass version of this.

Will work on it tomorrow!

 

[Antares]

Update:

• Added a vJass version.

 

[DarkePacific]

Update:

• Added a vJass version.

Hooray! I'll give this a test and integrate it into my map when I get a chance. Will let you know if I find any bugs

 

[Antares]

Hooray! I'll give this a test and integrate it into my map when I get a chance. Will let you know if I find any bugs

Thanks, please do! I had to restructure it quite a bit for the translation (back to the good ol' hashtable chains).

 

[Regno]

Thank you, its sweet

 

[Antares]

Thank you, its sweet

Thanks, glad you like it!

 

[DarkePacific]

Works well after the most recent JASS changes

Also, here's and additional function that I found useful

    function CloseOpenDialogForAll takes nothing returns nothing
        local integer i = 0
        loop
            exitwhen i > 23
            if GetPlayerSlotState(Player(i)) == PLAYER_SLOT_STATE_PLAYING and GetPlayerController(Player(i)) == MAP_CONTROL_USER then
                call CloseDialog(CurrentlyOpenDialog[GetPlayerId(Player(i))])
            endif
            set i = i + 1
        endloop
    endfunction

 

[Antares]

Thanks, that's a good function to add! You can simplify the condition though:

    function CloseOpenDialogForAll takes nothing returns nothing
        local integer i = 0
        loop
            exitwhen i > 23
            if CurrentlyOpenDialog[i] != null then
                call CloseDialog(CurrentlyOpenDialog[i])
            endif
            set i = i + 1
        endloop
    endfunction

Works well after the most recent JASS changes

What did I change again?

 

[Yevhen Snizhko]

1. Easy to use and modify. Recommended if you have 3+ options per button.

2. Can be used to save settings for maps and custom campaigns, although it seems to require script coding exclusively (not much of a problem for me).

3. In the library description probably should add a note that Config is in the library itself - I spent a few minutes checking the imported files.

4. I'm not sure if it is possible to register pressing these dialog buttons via GUI.

5. In placement (X,Y) should mention that (0,0) is at the bottom left corner. I expected it to be in top left.

6. Not sure for Lua, but for Jass should mention that this requires enabling the JassHelper - I did not have it enabled before this, and spent some time figuring out why these triggers were constantly disabling in my map.

7. Question: Can I rename the triggers ('better dialogs', 'test'), and if yes, what do I have to change in the code to keep it from breaking?

 

[Antares]

Thank you for your feedback!

3. It's probably not ideal that there the documentation is above the config; that's not how I would do it today, but there's only one script file that you need to import, so I don't really see this as a big issue.
4. There's no GUI version right now.
5. Yes, I can add that.
6. Sure.
7. The name of script files in your map is of no relevance.

 

[Aldeia]

Can you add GUI implementation please?

 

[Antares]

Can you add GUI implementation please?

Sorry, I have too many resources to attend to and I always feel like my GUI translations are terrible. Maybe someone who is currently working with this system can do a translation? I would add it here and give credit, of course. @Yevhen Snizhko @Regno @DarkePacific

 

[DarkePacific]

Can you add GUI implementation please?

My advice would be to provide the whole Jass library to an LLM and ask it to make the changes you want. Since this library is relatively small it should be able to handle modifications pretty well.

 

[Yevhen Snizhko]

Two questions:
1. Is it possible to make the dialog render above other UI? (On screenshot - health bars are rendering above the dialog)
2. Is it possible to make a dialog button that can't be pressed, yet has a tooltip?

 

[Antares]

1. Yes, I uploaded a fix to that.
2. Unfortunately, disabled buttons do not display tooltips when hovered over.

 

[Yevhen Snizhko]

1. Yes, I uploaded a fix to that.

Works nicely, but the Message Log (F12) still appears below it
Other menus (quests, main menu) are working fine.

 

[Antares]

Ok, used yet another parent frame.

 

[Yevhen Snizhko]

Found an interesting problem when HUD is scaled down.

What happens if I reduce HUD scale in Reforged 2.0.1 during gameplay:

Image 2:What happens if HUD is set to 0% in Reforged 2.0.1 when level starts:

All buttons work properly, but they have issues with scaling.

I'll just put a note for my campaign that users shouldn't open settings with downscaled HUD.

 

[Bain_Rebirth]

It would be awesome if CreateBetterDialogForPlayer returned the created dialog!

 

[Antares]

Fixed the scaling issue and added a return to the CreateBetterDialogForPlayer function.

 

[Aldeia]

Dark Tooltip is intended?

 

[Antares]

I updated the system by removing BlzDestroyFrame as it can cause desyncs. If you're using the previous version, I recommend updating it or simply replacing the BlzDestroyFrame calls with BlzFrameSetVisible(..., false) manually.

Thank you to @KenArok for the bug report.

 

[FlameofChange]

I got a serious problem.
I want to display very long strings, but Wc3 somewhat cuts at ~1000 chars.
How to circumvent that ?

 

[Antares]

I got a serious problem.
I want to display very long strings, but Wc3 somewhat cuts at ~1000 chars.
How to circumvent that ?

JASS has a string size limit that you're most likely hitting. In Lua, there is no string size limit.