attachment points in sanity checker

[stan0033]

1. I think sanity test must be made case-insensitive for names of attachment points.
2. Also to check an attachment point's name with ".StartsWith($"{name} ")" or even .Contains($" {name}"), because many models in the section have attachment
points of type "Head - Ref" (or another with dash) which works in-game but the sanity test flags it as warning.
If you have, for example, "Origin Head Overhead Chest Ref" the game can still use it.
3. because of that, check if two or more attachment points contain the same keywords (not exactly the same name) because that creates conflict


Attachment point names are conventions rather than strict requirements.. So if an attachment point contains a particular word, a trigger or the the game can attach to it,.
So I suggest to:
1. remove the warning "X is not a standard name for attachment"
and
2. make attachment name lowercase before checking if it's origin, for the warning "there is no origin attachment point"

Example pseudo func

Hidden

bool hasString(string Nodename, string lookFor){
string lowerName = Nodename.ToLower();
string lowerPart = lookFor.ToLower();
if (lowerName == lowerPart) return true;
if (lowerName.startsWith($"{lowerPart} ") return true;
if (lowerName.Contains($" {lowerPart}") return true;

return false;
}

 

[Ralle]

Hello stan, thanks for bringing this to our attention. Is this the case for both sanity checkers or only the new built-in one?

 

[stan0033]

Hello stan, thanks for bringing this to our attention. Is this the case for both sanity checkers or only the new built-in one?

the built-in, the one that dispays errors on the card of a model in the bundle

 

[tillinghast]

Hello stan, thanks for bringing this to our attention. Is this the case for both sanity checkers or only the new built-in one?

the built-in, the one that dispays errors on the card of a model in the bundle

actually the origin ref thing exists in proper sanity check too, not just built-in one

 

[loktar]

I've noticed this too, I even added an option to capitalize refs (although only the Origin one IIRC) to Model Optimizer. The dashes (e.g. Origin - Ref) I also noticed recently, but that one I only saw in the built-in one, never noticed it in the old separate one.

 

[Ralle]

I think this was updated. Did you see the change yet and does it work better? This is for the embedded sanity status and not the GhostWolf one.

 

[stan0033]

I think this was updated. Did you see the change yet and does it work better? This is for the embedded sanity status and not the GhostWolf one.

OK, I tested the embedded sanity check (on this) - now it does check for missing origin attahcment point with case-insensitive , and does not compare attachment names for similar keywords for conflict (bad) ("ref" is exception),;

one more thing: change the the warning "X is not a standard name for attachment" to "X is not a standard keyword for attachment" (typical are: head, overhead, chest, origin, foot, hand, left, right, weapon, mount, rallypoint, sprite, BirthLink, first, second, third, fourth)

EDIT: This validation for attachment point names is a bit complex, I asked chatGPT to write example: Check out this chat