Atomic bomb

[Moderator]

7 November 2015
Bribe: Rejecting due to the status of this resource being "needs fix" for years.

13:05, 22nd Jan 2010
TriggerHappy:

Your spell is 90% jass, so just use jass instead of lame GUI. This also means I am going to review it like a Jass spell.
First off, remove all the BJ's, including GetLastCreatedUnit which can be replaced by bj_lastCreatedUnit.

I would highly suggest using timers over TSA's as well.

Furthermore, nothing is configurable so copying this spell over will be a pain and not to mention that its a very simply and overdone spell. And because of that it probably won't get approved.

But we will see.

 

[Pharaoh_]

Ok, things to mention

1) Lack of documentation.
2)

• Custom script: call CreateNUnitsAtLocFacingLocBJ( 1, 'h001', Player(PLAYER_NEUTRAL_PASSIVE), GetSpellTargetLoc(), GetUnitLoc(GetTriggerUnit()) )

Why are you using this function to create 1 unit only?
Use "call CreateUnitAtLoc" instead.
3) You use this script

• Custom script: set u = GetLastCreatedUnit()

after the unit's creation. You could instead use this:

• Custom script: local unit u = CreateUnitAtLoc (Player(PLAYER_NEUTRAL_PASSIVE), 'h001', GetSpellTargetLoc(), 0)

4) You use Sleep actions; you'd better use Timers instead.
5) The effect is laggy.
6) You have a leak in a group:

• Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
  • Loop - Actions
    • Special Effect - Create a special effect attached to the chest of (Picked unit) using Environment\LargeBuildingFire\LargeBuildingFire1.mdl
    • Unit - Kill (Picked unit)
    • Animation - Change (Picked unit)'s animation speed to 50.00% of its original speed

Above the Pick Unit action, you could use this script:

• Custom script: set bj_wantDestroyGroup = true

or add the "Units in (Playable Map area)" in a Unit Group variable.
6) Basically your triggers are based on scripts; why don't you use Jass instead? You obviously tried to do something unique, yet ineffective.
7) The effect is really useless and we've seen loads of it already. Practise your triggering skills, unless you have something really good to supply us with.

Rating: 1/5 (Unaccepted)

 

[mazahaka]

OK, I will train.

 

[Klingo]

I don't have time to see what you did but post trigger in description

 

[X-OMG-X]

All i see from the screenshot is a red thing.

 

[mazahaka]

there is a dying paladin.

 

[Vengeancekael]

Lol "there is a dying paladin.", i lol'ed but i would really recommend you to read some tutorials first This will probably be rejected.

 

[jms]

why didnt u just do it in jass instead of using custom scripts !!:S
and it is a very simple spell
this is soo going to be
Rejected

 

[yamigosaya]

Lol It even kills the caster and Invulnerables

 

[togera90]

Could be used for a modern warfare 2 game, i would love to see one of those, :]

 

[Magtheridon96]

you might want to rewrite the code... i'll rewrite it and post my version to show you how it's done. but u know, 1/5 is pretty harsh - i'd give you a 2/5